Received-SPF: pass (google.com: domain of linux-kernel+bounces-141841-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <15b31289dfafa2516e524aadcb02a6af.sboyd@kernel.org>
Content-Type: text/plain; charset="utf-8"
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <SEZPR06MB69596A0104AA2385391049EA96052@SEZPR06MB6959.apcprd06.prod.outlook.com>
References: <20240225-pll-v1-0-fad6511479c6@outlook.com> <20240225-pll-v1-1-fad6511479c6@outlook.com> <d8dc639c2c6d188d2ce3728573d9a53d.sboyd@kernel.org> <SEZPR06MB6959E563B692827A3E5152DD96052@SEZPR06MB6959.apcprd06.prod.outlook.com> <fa5fe57faeda3323174e4caddc1ac2a6.sboyd@kernel.org> <SEZPR06MB69596A0104AA2385391049EA96052@SEZPR06MB6959.apcprd06.prod.outlook.com>
Subject: Re: [PATCH RFC 1/2] clk: hisilicon: rename hi3519 PLL registration function
From: Stephen Boyd <sboyd@kernel.org>
Cc: David Yang <mmyangfl@gmail.com>, Igor Opaniuk <igor.opaniuk@foundries.io>, Jorge Ramirez-Ortiz Gmail <jorge.ramirez.ortiz@gmail.com>, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org
To: Michael Turquette <mturquette@baylibre.com>, Yang Xiwen <forbidden405@outlook.com>, Yang Xiwen via B4 Relay <devnull+forbidden405.outlook.com@kernel.org>
Date: Thu, 11 Apr 2024 20:03:04 -0700
User-Agent: alot/0.10

Quoting Yang Xiwen (2024-04-11 03:31:58)
> On 4/11/2024 3:53 PM, Stephen Boyd wrote:
> > Quoting Yang Xiwen (2024-04-11 00:44:33)
> >> On 4/11/2024 2:52 PM, Stephen Boyd wrote:
> >>> Quoting Yang Xiwen via B4 Relay (2024-02-24 08:56:09)
> >>>> diff --git a/drivers/clk/hisilicon/clk-hi3559a.c b/drivers/clk/hisil=
icon/clk-hi3559a.c
> >>>> index ff4ca0edce06..77fa4203a428 100644
> >>>> --- a/drivers/clk/hisilicon/clk-hi3559a.c
> >>>> +++ b/drivers/clk/hisilicon/clk-hi3559a.c
> >>>> @@ -452,7 +452,7 @@ static const struct clk_ops hisi_clk_pll_ops =3D=
 {
> >>>>           .recalc_rate =3D clk_pll_recalc_rate,
> >>>>    };
> >>>>   =20
> >>>> -static void hisi_clk_register_pll(struct hi3559av100_pll_clock *clk=
s,
> >>>> +static void _hisi_clk_register_pll(struct hi3559av100_pll_clock *cl=
ks,
> >>> Prefix it with hi3559a then to be SoC specific please. But this is al=
so
> >>> static so I'm not sure why this patch is needed at all.
> >>
> >> it includes the header that marks this function non-static. Also the
> >> prototype is incompatible.
> > What is 'it'?
>=20
>=20
> The line 18 `#include "clk.h"`, and please see patch 2.
>=20
>=20
> Patch 2 added 2 functions to "clk.h", one of them reused the=20
> `hisi_clk_register_pll` name with a different prototype.
>=20
>=20
> >
> >   $ git grep hisi_clk_register_pll
> >   drivers/clk/hisilicon/clk-hi3559a.c:static void hisi_clk_register_pll=
(struct hi3559av100_pll_clock *clks,
> >   drivers/clk/hisilicon/clk-hi3559a.c:    hisi_clk_register_pll(hi3559a=
v100_pll_clks,
>=20
>=20
> a snippet copied from patch 2:
>=20
>=20
> +int hisi_clk_register_pll(struct device *dev, const struct hisi_pll_cloc=
k *clks,
> +                         int nums, struct hisi_clock_data *data);
>=20
>=20

Ok, got it. Prefix the existing hisi_clk_register_pll() as
hi3559a_clk_register_pll().