Received-SPF: pass (google.com: domain of linux-kernel+bounces-141843-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Thu, 11 Apr 2024 23:06:50 -0400
From: Frank Li <Frank.li@nxp.com>
To: Joy Zou <joy.zou@nxp.com>
Cc: peng.fan@nxp.com, vkoul@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
	conor+dt@kernel.org, imx@lists.linux.dev, dmaengine@vger.kernel.org,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v3 2/2] dma: dt-bindings: fsl-edma: clean up unused
 "fsl,imx8qm-adma" compatible string
Message-ID: <ZhilSv5xh0hJ2vdX@lizhi-Precision-Tower-5810>
References: <20240412030436.2976233-1-joy.zou@nxp.com>
 <20240412030436.2976233-3-joy.zou@nxp.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240412030436.2976233-3-joy.zou@nxp.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?CGtMzMdbQIHy3G3GrWDO9vyjNF03A3XPmT9j1uI6Ft3Lz6P/YfMYgI9nqiQY?=
 =?us-ascii?Q?LK/EDB0vjwWoef99lFqr81n2i6Udxpo45HAuJXVHl2BUh2mki1OCMr+sk0HQ?=
 =?us-ascii?Q?8Nc0OYqDN8WkhSuxV1pdGcwRI41OVv0BmsCbv9gbfJrXC8/K8JXvhhTtiiZ4?=
 =?us-ascii?Q?HGVDmqfFXX0LJKwKaIzbFPQKjWjew9CFD629IaRrREUeqL3XvqksRQb5vO9W?=
 =?us-ascii?Q?dpHPKqyHqcuIsnZHoh2XzX8AYxl+isdLpjPfyOc4AOWdAx0tGSC6bWssxoG4?=
 =?us-ascii?Q?teVlU6IrxwSK9ksMlwAjnvgbX5b99oi4Gw6HTvpFjMZWOUp2YCs5Uoxh0sp/?=
 =?us-ascii?Q?re7uKc70ogxv1G1xjfetEWZkUQLj7thi6rDKCeOw/qdyutEeEA7jMp6jnTev?=
 =?us-ascii?Q?E8qzqHOXaiuum8qeysgqRgCUwUSrrdBASy5OnL0iklXFxpCeDIlrUq7HJwlI?=
 =?us-ascii?Q?YPaIwMFxLPQdK3ocwgXtiw6DpPhJMPLHdhiOPzmLhuZH+Mgb187pU3GemFa/?=
 =?us-ascii?Q?aHGyR6HTQvvQJOuPZIc0KaLZpPRKN4EBKXwFADjVscOWJ4PoJis/J8aoVzWe?=
 =?us-ascii?Q?lNcfG0YcgFJo5h6CQDwFTQ21ooUHMhJn6A40N+TFIOXEDQZJEt7owxQaGxWU?=
 =?us-ascii?Q?ShWjbio/H4pNjg2KUnQnvU7/XGQYtpnM34vX+hV83bLQbNU/3bruQ6nLX3iM?=
 =?us-ascii?Q?YqRonSx3R42FozpdK+802JrcgHGId152Ee8f+X3h9xhX5dmmmZdBpJxkDJWH?=
 =?us-ascii?Q?Cd6y50NEIK3MWnvjiiGEOnaR4d+rWq/rRLcjoVYdu4V/Y/nh59FF1lJEVMBB?=
 =?us-ascii?Q?8zYcg901nopXV0+pLJhDuiSb6E8spxqwlon+MroK0H/TlJxMywnvux7KWKdb?=
 =?us-ascii?Q?JSnDl6EOgnu7VZ9gArLmb7EZ8j+t775cYrGJXx+kyudqNiFIJtJOFFIdxcAH?=
 =?us-ascii?Q?gIHbjdBRjRgYYbR6M1ba4Qwbjba9NZzAb+p+G34EfjzWlMG1jyOpah2qo5kR?=
 =?us-ascii?Q?BelBCGrLkIBeCRmie4D8Eo+aJYToerDFgv2DeKRXFzUbDCteJy1LoWX/YyRq?=
 =?us-ascii?Q?K3A5/spqGiCDF2h7nGdkqHiLRbxsCyXoTJD6fsEYCen99MMiOSsQvhn06CvR?=
 =?us-ascii?Q?mAPBkklhmPGEihmv1y3DHGp8ql95H7H4GB5Kfe5/GXOup8jPqu83NkGsvvEH?=
 =?us-ascii?Q?QFTmV8uq0/VbRUB37LxwKY1nDYyrWe+4Bnp9JGqgr2WMvRsVEseT+XRO0yXC?=
 =?us-ascii?Q?SrBTpwuJIOLzi0GaLto2NN9cfa5DfD9DoPWwTkVw0xu9/eK7BhJfm/zhmHgb?=
 =?us-ascii?Q?0L8ZXwBXCPD4pa/s105YdTrr0zY2gbI4C2ErMF+luv1m7xGnbYC9S8JX0PVe?=
 =?us-ascii?Q?s6fcBzSz6WmUfFO5WMKN2kWefZuZXJzAk6Tm/j9EzSgyO3WWbMg9k9SMYXj0?=
 =?us-ascii?Q?enRdkOkqmnYz/Zjw2vcYwnl0HvuV5yub3vuY7vlzRIFaWu6u4ZYW8oeKgKli?=
 =?us-ascii?Q?dYARYZQbUcuCcKBFj4V8qVg7IYBuktO8no8KsM0Ey6phFEKY2WJEmc/3rTuK?=
 =?us-ascii?Q?Se+cwnluFzgWlw49BE/H+IcxU3cx9ZwzdqtJs9Vl?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 25f16df9-367b-45ca-c43a-08dc5a9d9dfb
X-MS-Exchange-CrossTenant-AuthSource: DB9PR04MB9626.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Apr 2024 03:06:58.7834
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: q4WqXLfA2UZH9sOcRsUIoqa8FiZRqnPQBscBrmrbahumPNKnCHE3Pc+1T1WXA32WRwxyrOm5tFoKXTICNscjAA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9106

On Fri, Apr 12, 2024 at 11:04:36AM +0800, Joy Zou wrote:
> The eDMA hardware issue only exist imx8QM A0. A0 never mass production.
> The compatible string "fsl,imx8qm-adma" is unused. So remove the
> workaround safely.


You missed change subject:

dt-bindings: fsl-edma: clean up unused "fsl,imx8qm-adma" compatible string

dt-bindings should be first patch, then driver code.

I suggest use the same words, "clean up" or "Remove". keep consistent for
both patches

Frank

> 
> Signed-off-by: Joy Zou <joy.zou@nxp.com>
> ---
> Changes for v3:
> 1. modify the commit message.
> 2. remove the unused compatible string "fsl,imx8qm-adma" from allOf property.
> ---
>  Documentation/devicetree/bindings/dma/fsl,edma.yaml | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/dma/fsl,edma.yaml b/Documentation/devicetree/bindings/dma/fsl,edma.yaml
> index 825f4715499e..cf97ea86a7a2 100644
> --- a/Documentation/devicetree/bindings/dma/fsl,edma.yaml
> +++ b/Documentation/devicetree/bindings/dma/fsl,edma.yaml
> @@ -21,7 +21,6 @@ properties:
>        - enum:
>            - fsl,vf610-edma
>            - fsl,imx7ulp-edma
> -          - fsl,imx8qm-adma
>            - fsl,imx8qm-edma
>            - fsl,imx8ulp-edma
>            - fsl,imx93-edma3
> @@ -92,7 +91,6 @@ allOf:
>          compatible:
>            contains:
>              enum:
> -              - fsl,imx8qm-adma
>                - fsl,imx8qm-edma
>                - fsl,imx93-edma3
>                - fsl,imx93-edma4
> -- 
> 2.37.1
>