Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756829AbYAWSvm (ORCPT ); Wed, 23 Jan 2008 13:51:42 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754085AbYAWSve (ORCPT ); Wed, 23 Jan 2008 13:51:34 -0500 Received: from relay2.sgi.com ([192.48.171.30]:49768 "EHLO relay.sgi.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753386AbYAWSvd (ORCPT ); Wed, 23 Jan 2008 13:51:33 -0500 Date: Wed, 23 Jan 2008 10:51:32 -0800 (PST) From: Christoph Lameter X-X-Sender: clameter@schroedinger.engr.sgi.com To: Pekka J Enberg cc: Mel Gorman , akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org, "Aneesh Kumar K.V" , hanth Aravamudan , KAMEZAWA Hiroyuki , lee.schermerhorn@hp.com, Linux MM , Olaf Hering Subject: Re: [PATCH] Fix boot problem in situations where the boot CPU is running on a memoryless node In-Reply-To: Message-ID: References: <20080122214505.GA15674@aepfle.de> <20080123075821.GA17713@aepfle.de> <20080123105044.GD21455@csn.ul.ie> <20080123121459.GA18631@aepfle.de> <20080123125236.GA18876@aepfle.de> <20080123135513.GA14175@csn.ul.ie> <20080123155655.GB20156@csn.ul.ie> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1221 Lines: 34 On Wed, 23 Jan 2008, Pekka J Enberg wrote: > Fine. But, why are we hitting fallback_alloc() in the first place? It's > definitely not because of missing ->nodelists as we do: > > cache_cache.nodelists[node] = &initkmem_list3[CACHE_CACHE]; > > before attempting to set up kmalloc caches. Now, if I understood > correctly, we're booting off a memoryless node so kmem_getpages() will > return NULL thus forcing us to fallback_alloc() which is unavailable at > this point. > > As far as I can tell, there are two ways to fix this: > > (1) don't boot off a memoryless node (why are we doing this in the first > place?) Right. That is the solution that I would prefer. > (2) initialize cache_cache.nodelists with initmem_list3 equivalents > for *each node hat has normal memory* Or simply do it for all. SLAB bootstrap is very complex thing though. > > I am still wondering why this worked before, though. I doubt it did ever work for SLAB. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/