Received-SPF: pass (google.com: domain of linux-kernel+bounces-141928-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Precedence: bulk
MIME-Version: 1.0
References: <20240222051539.3001988-3-saravanak@google.com>
In-Reply-To: <20240222051539.3001988-3-saravanak@google.com>
From: Saravana Kannan <saravanak@google.com>
Date: Thu, 11 Apr 2024 21:33:16 -0700
Message-ID: <CAGETcx_zC_HKoFr=m_erAM+tWPQLe8TuLtJpZ6+dtac8UEYCWQ@mail.gmail.com>
Subject: Re: [PATCH 1/2] checkpatch: Don't check for 75 chars per line for
 create/delete mode lines
To: Andy Whitcroft <apw@canonical.com>, Joe Perches <joe@perches.com>, 
	Dwaipayan Ray <dwaipayanray1@gmail.com>, Lukas Bulwahn <lukas.bulwahn@gmail.com>
Cc: kernel-team@android.com, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, Feb 21, 2024 at 9:15=E2=80=AFPM Saravana Kannan <saravanak@google.c=
om> wrote:
>
> Cover letters have a "create/delete mode <mode> <filename>" line for file=
s
> added/deleted in the patch series. Ignore these lines when checking for t=
he
> maximum 75 chars per line limit.
>
> Signed-off-by: Saravana Kannan <saravanak@google.com>

I know patch 2/2 is not going to be picked up. But can we pick up this
one please?

-Saravana

> ---
>  scripts/checkpatch.pl | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 9c4c4a61bc83..f306634a938c 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -3271,6 +3271,8 @@ sub process {
>                                         # filename then :
>                       $line =3D~ /^\s*(?:Fixes:|$link_tags_search|$signat=
ure_tags)/i ||
>                                         # A Fixes:, link or signature tag=
 line
> +                     $line =3D~ /^\s*(?:delete|create) mode\s+[0-8]+\s+\=
S+\s*$/i ||
> +                                       # A "create/delete mode <mode> <f=
ilename>" line found in cover letters
>                       $commit_log_possible_stack_dump)) {
>                         WARN("COMMIT_LOG_LONG_LINE",
>                              "Prefer a maximum 75 chars per line (possibl=
e unwrapped commit description?)\n" . $herecurr);
> --
> 2.44.0.rc0.258.g7320e95886-goog
>