Received-SPF: pass (google.com: domain of linux-kernel+bounces-141946-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <fd22f818-f123-482a-97ff-6f113bc08164@ti.com>
Date: Fri, 12 Apr 2024 10:33:48 +0530
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 5/5] arm64: dts: ti: k3-j7200-mcu: Add the MCU domain
 watchdog instances
To: Neha Malcom Francis <n-francis@ti.com>, <robh@kernel.org>,
        <conor+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
        <vigneshr@ti.com>, <nm@ti.com>
CC: <linux-arm-kernel@lists.infradead.org>, <devicetree@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <kristo@kernel.org>
References: <20240412042537.666137-1-n-francis@ti.com>
 <20240412042537.666137-6-n-francis@ti.com>
Content-Language: en-US
From: "Kumar, Udit" <u-kumar1@ti.com>
In-Reply-To: <20240412042537.666137-6-n-francis@ti.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit

Hi Neha

On 4/12/2024 9:55 AM, Neha Malcom Francis wrote:
> There are 2 watchdog instances in the MCU domain. These instances are
> coupled with the MCU domain R55 instances. Reserve them as they are not
> used by A72.
>
> Signed-off-by: Neha Malcom Francis <n-francis@ti.com>
> ---
> Changes since v1:
> - patch added
>
>   .../boot/dts/ti/k3-j7200-mcu-wakeup.dtsi      | 26 +++++++++++++++++++
>   1 file changed, 26 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi
> index 7cf21c99956e..d1a42c3f30c0 100644
> --- a/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-j7200-mcu-wakeup.dtsi
> @@ -686,4 +686,30 @@ mcu_mcan1: can@40568000 {
>   		bosch,mram-cfg = <0x0 128 64 64 64 64 32 32>;
>   		status = "disabled";
>   	};
> +
> +	/*
> +	 * The 2 RTI instances are couple with MCU R5Fs so keeping them
> +	 * reserved as these will be used by their respective firmware
> +	 */
> +	mcu_watchdog0: watchdog@40600000 {
> +		compatible = "ti,j7-rti-wdt";
> +		reg = <0x00 0x40600000 0x00 0xbd>;


please refer  Table 2-3. MCU Domain Memory Map of TRM.

Size of wdt is 0x100 , with this change in size from 0xbd to 0x100.

you can use

Reviewed-by: Udit Kumar <u-kumar1@ti.com>  for whole series

> +		clocks = <&k3_clks 262 1>;
> +		power-domains = <&k3_pds 262 TI_SCI_PD_EXCLUSIVE>;
> +		assigned-clocks = <&k3_clks 262 1>;
> +		assigned-clock-parents = <&k3_clks 262 5>;
> +		/* reserved for MCU_R5F0_0 */
> +		status = "reserved";
> +	};
> +
> +	mcu_watchdog1: watchdog@40610000 {
> +		compatible = "ti,j7-rti-wdt";
> +		reg = <0x00 0x40610000 0x00 0xbd>;
> +		clocks = <&k3_clks 263 1>;
> +		power-domains = <&k3_pds 263 TI_SCI_PD_EXCLUSIVE>;
> +		assigned-clocks = <&k3_clks 263 1>;
> +		assigned-clock-parents = <&k3_clks 263 5>;
> +		/* reserved for MCU_R5F0_1 */
> +		status = "reserved";
> +	};
>   };