Received-SPF: pass (google.com: domain of linux-kernel+bounces-141968-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Fri, 12 Apr 2024 14:18:22 +0900
From: Masami Hiramatsu (Google) <mhiramat@kernel.org>
To: Yuntao Wang <ytcoode@gmail.com>
Cc: akpm@linux-foundation.org, arnd@arndb.de, changbin.du@huawei.com,
 christophe.leroy@csgroup.eu, geert@linux-m68k.org, jpoimboe@kernel.org,
 kjlx@templeofstupid.com, linux-kernel@vger.kernel.org,
 linux-trace-kernel@vger.kernel.org, ndesaulniers@google.com,
 peterz@infradead.org, tglx@linutronix.de, tj@kernel.org
Subject: Re: [PATCH v2] init/main.c: Remove redundant space from
 saved_command_line
Message-Id: <20240412141822.bc7cb44065dab62bf9f2e5ff@kernel.org>
In-Reply-To: <20240412032950.12687-1-ytcoode@gmail.com>
References: <20240412080839.c903a0058bd6594d31bc1d3e@kernel.org>
	<20240412032950.12687-1-ytcoode@gmail.com>
Precedence: bulk
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Fri, 12 Apr 2024 11:29:50 +0800
Yuntao Wang <ytcoode@gmail.com> wrote:

> There is a space at the end of extra_init_args. In the current logic,
> copying extra_init_args to saved_command_line will cause extra spaces
> in saved_command_line here or there. Remove the trailing space from
> extra_init_args to make the string in saved_command_line look more perfect.
> 
> Signed-off-by: Yuntao Wang <ytcoode@gmail.com>

OK, this looks good to me.

Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>

Let me pick this to bootconfig/for-next.

Thank you,

> ---
> v1 -> v2: Fix the issue using the method suggested by Masami
> 
>  init/main.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/init/main.c b/init/main.c
> index 881f6230ee59..0f03dd15e0e2 100644
> --- a/init/main.c
> +++ b/init/main.c
> @@ -627,8 +627,10 @@ static void __init setup_command_line(char *command_line)
>  
>  	if (extra_command_line)
>  		xlen = strlen(extra_command_line);
> -	if (extra_init_args)
> +	if (extra_init_args) {
> +		extra_init_args = strim(extra_init_args); /* remove trailing space */
>  		ilen = strlen(extra_init_args) + 4; /* for " -- " */
> +	}
>  
>  	len = xlen + strlen(boot_command_line) + 1;
>  
> -- 
> 2.44.0
> 

-- 
Masami Hiramatsu (Google) <mhiramat@kernel.org>