Received: by 2002:ab2:7407:0:b0:1f4:b336:87c4 with SMTP id e7csp232695lqn; Thu, 11 Apr 2024 22:21:09 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCV0VSPkdfxvqdgWGov/Ofs0rUPZdStxdYB+ukVvwagVddoZhEZlgAw0WDdMOYt8wVnCT5y6p5KrEJ9OvhzPvjhvr8w2EmhOE11q8Lcnsw== X-Google-Smtp-Source: AGHT+IFOqZyxjoCHctW2cHpkoEyIc1B8xtEhl/HB9MTdgy73aK9FX32jOVQ/fjlFtnYT/4NS8hwe X-Received: by 2002:a17:90b:1b47:b0:2a2:70c6:970c with SMTP id nv7-20020a17090b1b4700b002a270c6970cmr1621212pjb.11.1712899268753; Thu, 11 Apr 2024 22:21:08 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712899268; cv=pass; d=google.com; s=arc-20160816; b=XZ9v2xEYEm/Qh52MnNQnyOcP/cOn1F+SEy0HUA2hSi3bzHceM2/KudMKuhmTy0D8l9 WCnDJhAk3XxUWtlhzttNJlBHDSOjwU4nIBNB013zyBQz0jWOBGCy9+oP5YQmqJszCA8V PT/2hFfrrTQupZ9Yqmp85XYQOtMbdNgRiiMm0ZsZxrfbVB6+09EbQiiJu/AT49DdEpS4 mGJ3wQ+CRQKwqKVOwL5wb758nJWlq1297YrKPX1VwzADaOzH4N6vIE2+Qu9kJKDg2zCk KHOwUaiQgv6GyN9ZoD4OslxPU2qFSnOxVxDrxDpMTBeLf5dFg8oJIZ/l/6yqeUp6z485 mPfg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=MP15k8oIbm53O/H48fhBc/KWGrJTLsFd8hX2vHdbJes=; fh=d2uLX7C8aVXfGf+f034rZJIVKZHDtC7m2ff1sxC8oPI=; b=jiAKUsqDfVIvFWBp9RgPtzmxvGxr7QEQRlJVVkgqc9Pos4XJZ8cYx2SgDXFtzUGsCq hX+iLVNz+HIrXTQcwUyFJGbYobtuZljn+5Ic2rcqkLLGmOvd5PUXid0NIaTOfmykDCcW Sy0ONHnlTE5G1g56Y6r2Jg6jNHx/EBRl305/KLpjozO7IGmXpZ3J15yR0bij/adoSOCz h3SyMXB8mS2nGKCbbU9d7cgwf9Kxbs3k5zCy5nd7k5IJaszXmR0aZt7UcxZ9oLYdyXGU DRs6mH7K6Vr4QWYAD+Zp4eQI8vyBg37WLPo/6Obp086F1tLaIPSf8TU9/eOPsUvpD/oB X8KA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=qeqoms01; arc=pass (i=1 dkim=pass dkdomain=linuxfoundation.org); spf=pass (google.com: domain of linux-kernel+bounces-141973-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-141973-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id e17-20020a17090ab39100b002a03864ce2bsi4514946pjr.171.2024.04.11.22.21.08 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Apr 2024 22:21:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-141973-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=qeqoms01; arc=pass (i=1 dkim=pass dkdomain=linuxfoundation.org); spf=pass (google.com: domain of linux-kernel+bounces-141973-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-141973-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 67FCD28495C for ; Fri, 12 Apr 2024 05:21:08 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C87801BC23; Fri, 12 Apr 2024 05:20:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="qeqoms01" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E9F1618C1A; Fri, 12 Apr 2024 05:20:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712899259; cv=none; b=RcAwc4cfcE7VTfeUgnNXQs/xGKa16Zn9i0gT/JOP4jBZWnqi+g+gdKd3OLOTTdISnGyJntBTgroaRHou/0i0mDhh1kmw6XcClfLX6O3TT7h+QuNQV0R8Iwi4x3IJwLiMQ+i7FXyrj1GRtXm5j8drmSQJmUYZAxFS3NBbJcupNMM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712899259; c=relaxed/simple; bh=jpt7FUyFxKqQvoDaN0RnjXj5aEYMHYNMwBmKZvgoXgo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Z/Fac/cMFv7w3IEL1QJIo/i93mO6Tc+4PgglU5/CCp7Qiv20YXQnLbMBoz/Nfz600/FCoJLt/TkbwJWhWvUdjJSx3OLciiLZsgH77tx20G+bo5IkKX3t2NERbELVtAToTfbSEpty4fFLy1v1Ync+o/FBEEXWUP1g+7Oj7dvyr8M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=qeqoms01; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id CA1BBC2BD11; Fri, 12 Apr 2024 05:20:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1712899258; bh=jpt7FUyFxKqQvoDaN0RnjXj5aEYMHYNMwBmKZvgoXgo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qeqoms01kVM5QWF97ebRi0NwHNjJ1nqnkxhVo4WeNMijuKv9gKutyHog8Q3aQyV+c cI2PcgDdsLXG3iLkllfd0Pu2BIVWVu/cbmR7D69hGCcXZFBPkaU2Kgf4EeC89LlWpw loik1zxnBLN9kFGniRFi6jnwXM5dbP6YFhRS9BYo= Date: Fri, 12 Apr 2024 07:20:54 +0200 From: Greg KH To: Roman Storozhenko Cc: jirislaby@kernel.org, Julia.Lawall@inria.fr, skhan@linuxfoundation.org, javier.carrasco.cruz@gmail.com, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org Subject: Re: [PATCH] sysrq: Auto release device node using __free attribute Message-ID: <2024041245-surfboard-expenses-ba74@gregkh> References: <20240411180256.61001-1-romeusmeister@gmail.com> <2024041111-tummy-boil-a6aa@gregkh> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: A: http://en.wikipedia.org/wiki/Top_post Q: Were do I find info about this thing called top-posting? A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail? A: No. Q: Should I include quotations after my reply? http://daringfireball.net/2007/07/on_top On Thu, Apr 11, 2024 at 08:28:17PM +0200, Roman Storozhenko wrote: > This change allows us to put this pointer under automatic scope > management and get rid of node_put. Besides, if a new code path is > introduced we won't need to add a new of_node_put. We worry about future stuff then, in the future. So no need for changing code today for things that are not present at all, otherwise you would never be finished with anything, right? Don't make things more complex when it is not needed. Only add complexity when it is needed. thanks, greg k-h