Received-SPF: pass (google.com: domain of linux-kernel+bounces-142043-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Fri, 12 Apr 2024 12:03:50 +0530
From: Viresh Kumar <viresh.kumar@linaro.org>
To: Lizhe <sensor1010@163.com>
Cc: rafael@kernel.org, linux-pm@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cpufreq: Fixed kernel crash caused by cpufreq issues
Message-ID: <20240412063350.oozcb3awzbkk5zdt@vireshk-i7>
References: <20240411231818.2471-1-sensor1010@163.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240411231818.2471-1-sensor1010@163.com>

On 11-04-24, 16:18, Lizhe wrote:
> When the cpufreq_driver does not provide an exit() function.
> cpufreq offline operations can result in a kernel crash.
> 
> Signed-off-by: Lizhe <sensor1010@163.com>
> ---
>  drivers/cpufreq/cpufreq.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
> index 04d349372de3..e8660bc7d232 100644
> --- a/drivers/cpufreq/cpufreq.c
> +++ b/drivers/cpufreq/cpufreq.c
> @@ -1739,7 +1739,7 @@ static void cpufreq_remove_dev(struct device *dev, struct subsys_interface *sif)
>  	}
>  
>  	/* We did light-weight exit earlier, do full tear down now */
> -	if (cpufreq_driver->offline)
> +	if (cpufreq_driver->offline && cpufreq_driver->exit)
>  		cpufreq_driver->exit(policy);
>  
>  	up_write(&policy->rwsem);

Hmm, saw this just now.

Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

-- 
viresh