Received-SPF: pass (google.com: domain of linux-kernel+bounces-142044-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: Vamsi Krishna Attunuru <vattunuru@marvell.com>
To: Greg KH <gregkh@linuxfoundation.org>
CC: "arnd@arndb.de" <arnd@arndb.de>,
        "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>
Subject: RE: [EXTERNAL] Re: [PATCH v4 1/1] misc: mrvl-cn10k-dpi: add Octeon
 CN10K DPI administrative driver
Thread-Topic: [EXTERNAL] Re: [PATCH v4 1/1] misc: mrvl-cn10k-dpi: add Octeon
 CN10K DPI administrative driver
Thread-Index: AQHadGwMkJgd71lr6EOhyDALmTU76rFjOCSAgAEjI/A=
Date: Fri, 12 Apr 2024 06:34:10 +0000
Message-ID: 
 <MW4PR18MB5244C76290A15737DC94FFDBA6042@MW4PR18MB5244.namprd18.prod.outlook.com>
References: 
 <MW4PR18MB5244191AE625EE04141DAE2BA6272@MW4PR18MB5244.namprd18.prod.outlook.com>
 <20240312105657.1589333-1-vattunuru@marvell.com>
 <2024041152-symphony-strained-8370@gregkh>
In-Reply-To: <2024041152-symphony-strained-8370@gregkh>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?3UAwvx4SmPWZeyiTA4Az5/BO7jr1KReHOu2BxIoUE5OyGoPhOZr3Qn5KcG47?=
 =?us-ascii?Q?ekAbQi9cyBD7Xg0WV8YIafddWuyuBQ6S39wbTxj8lbwOqFoTTfzKqlhoFcDH?=
 =?us-ascii?Q?D+K+fcTYCAW/Pvj2YcZf49M0CWMYQzFfO8ECm9mBXk7yTVerwDVsNxBlnuUZ?=
 =?us-ascii?Q?oalDX6xf7LJhjXSubAVGf9xA2VkLTOf7oBfuX+WlUa6uDOYRHL4JMY7RFqnn?=
 =?us-ascii?Q?4Rsz7RK328P9Nr3k/yAyBL1Vj+O42dMf/cDsiaVmoYsDbB0PKXSgvLok7q9w?=
 =?us-ascii?Q?1WTYG2Eykrccx6+3+CtCffbnE3o3PURKLMJRBUCTCFvM9BB6d9uo+8n7c4ex?=
 =?us-ascii?Q?O46/smuMNTESfPl2ziL0rnoiJ58cRPynRpD4FHVlrFZahKPSm1J6ia2XPTLZ?=
 =?us-ascii?Q?OkouXYKVGSmX/Xnjwyk13rFdAdQFDvOOc1jld9X01z66+p8yg++KPgRzwcgC?=
 =?us-ascii?Q?HIGS5h1tYTU812HN7MuZux30mCvtjgCHmrEn3csgELWdptIwLD4Z8UElu6j5?=
 =?us-ascii?Q?R/OId4blZV1ivAxhmSZYsSbqaw0sAGiXA3/Q/O9vyLJvw2jrKCEb8588dl9g?=
 =?us-ascii?Q?0OQ+hqxblS6NTDmqPyd+ZhTlXN/7uB7RCTplud9yChoMmNhpE+PGKSRkaJU3?=
 =?us-ascii?Q?9d4lTSUJcwzNEKHBUsr2p1Kwp9S6wmy33kuC5WInfDjVej6cKGOvPBQ+JoOj?=
 =?us-ascii?Q?0SWMbNLtZOoc6QhxJHDCRJlG+TqUTLWUHZrGsuLTuIl3ASh9t1Ka+5Gnw8jG?=
 =?us-ascii?Q?A4eIjhGHRqa4NYCb4mALVojHlDSplYUZ49iBYKTmEDz2De5mFf1+q+oYJWtf?=
 =?us-ascii?Q?3VR6pXFO8uQfLd754va/1dk1LFW80f88YD+ikTMzODYxzHNJ1BmfN+6G8kbj?=
 =?us-ascii?Q?M5ke+O1ISKLuodyCWeIR0OYUuFMIG88wUb99YlQ+5IVUy11w+MXevckJ8H4G?=
 =?us-ascii?Q?gB7GTXlv+G1UrOMmEsT3f2ADD4wKwvZVnKV1EQCEIa8oUK3UuzdaH0VzCjbY?=
 =?us-ascii?Q?etXZWnxCMLQr9f6cZKNUd51JXp9CjyReSJuiShvlUCJcfuq7EoeBSGlXTeuB?=
 =?us-ascii?Q?mnPrYxobCNt0g0gJasdSXGLK7cp9sS3VwvaMJhVQfLR2HdsbY8KxHkfc1o44?=
 =?us-ascii?Q?aGbn7rXD+FQcBg0+lG7g1oNvzLzuFYI0i+Li95bBsJ7r036SMcpndUfQuXCx?=
 =?us-ascii?Q?bP3OPArdY4SrwnMUJKJm7DbFBKmltsvrwVGe0TO7gt1IG+LMDf82jEJ6870G?=
 =?us-ascii?Q?CyDA0fBU9R7Qv4h7B+/OE+KiAtDAdQODTgqjdHkZ6A1QttzcqoacQqhL8UxP?=
 =?us-ascii?Q?EHfMfoi1qY8Fmo+/WoHjT+FDt4I3/KGmWYYyyQwMw+T7iGoZwkIYxw8mjsN1?=
 =?us-ascii?Q?LkkMvPM3FVjDG3mz7tYLU3rP/B/bo5WHP4kcKuvrRaUNqotgV2jqHQTropLk?=
 =?us-ascii?Q?zKmt5nAiV2xAh8ZzB2/4DtDIHtJYMhyCGQTUwZA5fkuTDexGssiJ7zhMEFv2?=
 =?us-ascii?Q?nAN+Uk4ndT7lwF2KOzPtFemGThTpDj9X12EydFlVoVW/oqjWvBnc7fjQ3wnP?=
 =?us-ascii?Q?188TDilTRAKeOqRtrYt0sN/ZyT+bmFMe0UwA07xm?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MW4PR18MB5244.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7b48b021-a48f-485f-0367-08dc5aba8fb2
X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Apr 2024 06:34:10.0609
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: c7HOPCZymkQvuaGM6ok8+sf3iYibNqcndOt3wsAoxUGZ1hO1Aia7AVab74z8nb/AVKM0UJ/iyTaHBlX3priCPA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR18MB5447
X-Proofpoint-GUID: FY9jAZVSvgt9TLI6P32WtbXn_x5aTQmr
X-Proofpoint-ORIG-GUID: FY9jAZVSvgt9TLI6P32WtbXn_x5aTQmr
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-04-12_03,2024-04-09_01,2023-05-22_02


> -----Original Message-----
> From: Greg KH <gregkh@linuxfoundation.org>
> Sent: Thursday, April 11, 2024 6:32 PM
> To: Vamsi Krishna Attunuru <vattunuru@marvell.com>
> Cc: arnd@arndb.de; linux-kernel@vger.kernel.org
> Subject: [EXTERNAL] Re: [PATCH v4 1/1] misc: mrvl-cn10k-dpi: add Octeon
> CN10K DPI administrative driver
>=20
> Prioritize security for external emails: Confirm sender and content safet=
y
> before clicking links or opening attachments
>=20
> ----------------------------------------------------------------------
> On Tue, Mar 12, 2024 at 03:56:57AM -0700, Vamsi Attunuru wrote:
> > --- /dev/null
> > +++ b/include/uapi/misc/mrvl_cn10k_dpi.h
> > @@ -0,0 +1,35 @@
> > +// SPDX-License-Identifier: GPL-2.0
>=20
> Wrong license for a uapi file, right?  Please work with your lawyers to f=
igure
> out the correct one if you have any questions.
>=20

No concerns in using general licensing for uapi file, will fix in next vers=
ion.

> > +/* Marvell Octeon CN10K DPI driver
> > + *
> > + * Copyright (C) 2024 Marvell.
> > + *
> > + */
> > +
> > +#ifndef __MRVL_CN10K_DPI_H__
> > +#define __MRVL_CN10K_DPI_H__
> > +
> > +#include <linux/types.h>
> > +
> > +#define DPI_MAX_ENGINES 6
> > +
> > +struct dpi_mps_mrrs_cfg {
> > +	u64 mrrs; /* Max read request size */
> > +	u64 mps;  /* Max packet size */
> > +	u64 port; /* Ebus port */
> > +};
> > +
> > +struct dpi_engine_cfg {
> > +	u64 fifo_mask; /* FIFO size mask in KBytes */
> > +	u64 molr[DPI_MAX_ENGINES];
> > +	u64 update_molr; /* '1' to update engine MOLR */
>=20
> This is not how you create an ioctl, please read the kernel documentation=
 for
> how to do it properly please.  (hint, wrong data
> types.)
Sure, will send next version with the fixes( u64 --> __u64). Thanks.

>=20
> Also, a pointer to the userspace code that is going to use this new api y=
ou are
> creating would be apprecaited.
>=20
> thanks,
>=20
> greg k-h