Received-SPF: pass (google.com: domain of linux-kernel+bounces-142117-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>
To: Saranya Muruganandam <saranyamohan@google.com>
CC: "axboe@kernel.dk" <axboe@kernel.dk>, "hch@lst.de" <hch@lst.de>,
	"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"stable@vger.kernel.org" <stable@vger.kernel.org>, "tj@kernel.org"
	<tj@kernel.org>, "yukuai1@huaweicloud.com" <yukuai1@huaweicloud.com>
Subject: Re: [PATCH] block: Fix BLKRRPART regression
Thread-Topic: [PATCH] block: Fix BLKRRPART regression
Thread-Index: AQHaiwSINB8WBnJl30qPCQCcaD9o87FiKqMAgAIQ7IA=
Date: Fri, 12 Apr 2024 07:12:37 +0000
Message-ID: <zvmwp3n3yx55ogzb5gtfe2xdmsg53y3umgnezcwd4weq5vloru@w6qi7lfvezls>
References: <tnqg4la2bhbhfbty3aa74uorkfhz76v5sntd3md44lfctjhjb7@7qbx5z2o7hzm>
 <20240410233932.256871-1-saranyamohan@google.com>
In-Reply-To: <20240410233932.256871-1-saranyamohan@google.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?NBiioRM4Dq/XtoUpZT/zeWBkzBItj/n+bldykSkPMYxasHl6Fsu8p4wKfsXa?=
 =?us-ascii?Q?cqHNTQ/TiazGu4AeNHN/vk9AFYMPYe5zFfnLj9BJG08XqJlwoLKiVzvTnAUh?=
 =?us-ascii?Q?qUNr94xCkcmpNc8kBleEHkoDFu9gYdhWX36A/h4/M0gaLUvP2OFILIWNXTBF?=
 =?us-ascii?Q?Aa99Hz9xDYk/btQLtvxBOy657yUhXCmONI7p3xw5i0/EArEaX0sIt+cdNESP?=
 =?us-ascii?Q?PD+nIBWCKqHLg4v1cOUhTy4i1VyhltfjSxA7dXENAbDQRhjl+3eBvvPU70hw?=
 =?us-ascii?Q?B+meNIXzjHd8nZ45j3mBrcAIeWy0fd73lOhlIf+JscAYqt4jtHL23IFDsUti?=
 =?us-ascii?Q?yhCxGNnjDLV9ljd4qsMk1xvUPYJtovyXtELuCFGDxkeaXNwO5xB/hi2AQqzV?=
 =?us-ascii?Q?inUQnsvRal5JjS9vD5bIVBLyjpMLaiPX5BDizvvrpIboRo4UW00b94SRt72q?=
 =?us-ascii?Q?xia6pI3OCAgtPwZT0y1N8XxZb+eABXep3PDml4eX8tF7SEFdRUhaRySW/e4L?=
 =?us-ascii?Q?HYr+J2ftoozBqJQMwFgxlzKgsF/jxdBgasm4DUZltO9W4tisxq1+WnvQjyHc?=
 =?us-ascii?Q?3r2eIm9jc6OziNZMp+miaF+ITdIPzKb9r07rUnKbBlfCv2He23TwvuF7URBA?=
 =?us-ascii?Q?fMQoEynb+Zw4jaRuCRkmPoLEdODBT0YI38s94SvxZrNCMXoR8t0KG03vy5+7?=
 =?us-ascii?Q?/Ss+4IQVSLysJNLwGkvp4VLjIjHnNrBa5rpMCQJo1iW/LWnnqAfekcUfnl6g?=
 =?us-ascii?Q?iTu/uNYwIml+gGNwscpe588MVPPOlADyISJ2X2OMK8XHXwgL5FpOzQPPkZbN?=
 =?us-ascii?Q?6ARxYP6nBqHnWBS8B5qnJC7YxGIQHI55ZYKVZVtqicUSQrN5u9L3ej9S/Tpp?=
 =?us-ascii?Q?gvfWEkF45fOQCXUcsJEjVmvjJgqixdsMAs03v7U1765NjiRWMhtX6Ey1Z3Oo?=
 =?us-ascii?Q?PeDfEDgDaeEOrTZb2p8598y1IJr/GZxwH4jps6l5zMDuFFyBd1w918E6TQqb?=
 =?us-ascii?Q?uWprvo1MgVl22KprwtDxFnukgi3uDDlVdMj2+04x8FZEXfhO+NAZv1gQG+3p?=
 =?us-ascii?Q?i6G/W3NFClkhCh0CJJpS1ZqxyiUoE524k8e+TswXzZ+mvPUklz3Tw5R8Q08d?=
 =?us-ascii?Q?CLDNasp/lkg1q3vMnXzUOcVGXX62/6fUm+zW79pSDxMAZS4MFrNLNIwfEyG5?=
 =?us-ascii?Q?dJIxzN9dRrTh29j+Dcb9rw0967NgoF1sQdNho46OMonDu0uJ5FgTIAkPSd4c?=
 =?us-ascii?Q?QdETyvM0BSkmc/HPaW8WYius2di+v3mIn9pbmg6uNW400iFfz2WbX7oSYvWA?=
 =?us-ascii?Q?kD27zfMjf75y84QJyQP7yOl4fWlyccwWeRmuKsP8ZlGeGf7Tgh+syq/x/qU5?=
 =?us-ascii?Q?/bCM9y1i4c+WPn9TE2MtZpCf72rEFOGHnbmnPVBlMY/+LqJL7625VAO3qUX+?=
 =?us-ascii?Q?TbSjmT9tQNRdnuemN1uleBiqXXGRV+DD20JP8/pWYZkXCBxA38Ly+3oePDGw?=
 =?us-ascii?Q?yhcZPYNCVwweHqcBi82q/0jHGPxYfvldKl835mIbGhTv0mVgHrrVH+rcSJxA?=
 =?us-ascii?Q?tHGX8TD8/jSYdniND0SM76z6OBUuPs6QemiE7y+t5+4ucAojQ8MOwVnrgsXC?=
 =?us-ascii?Q?AFWv/ESif2QbDjL82rYRf+s=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <E7C95529097DDE429B38B49B8AA3ADB7@namprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0:
	xg7UqeNzbGyAiPEwLZ+C4zkLTlR46c3nKHVq0uLEbq7dpUWUBJLmSs0DLDLCCI8OQBsMOqFBnI9fuzR1SmI0RRV+9k9+DmIQpC4mGye22Zj1YIUrvi+II8I7/tuLzo2UeagAD91ag+WxitjBmGjwu7wen3xsbDjFqUk8I6laJqwdG0h3qQBrK/GuxYPwZmLN5yJF1Q411Q7k+CJYxc/zPEDZxhto1vbOy4KX4reW0dW3WDljCKe9n4sf2R5pZH5mlN43h4Hvsepji2BBkXAnOHFH7fWL9j2r/N4oLW6aC9A8ltKVh6hMBU3VK8Q42tb1bmgVBYPUaIoBeDaK/WIh3EwcNLCsyhsdtL+cIw3VeDzKAQtFI0ReN+R+C+QileFXLC8VZws7QyAMtxT43iuKJcfI+BOyAsklW8C/GPNNYhSwKeXgJ/IMoADPQRkcKVdvDocX1/HXBvaX0AaqZPC1oWXKLfbFD0hq44IlFyAiON1+KcNzW4qGoC35/BsgU35YkE0eGOfdAZFSvbcjV3sJf1izg5I0ggGpXG70PmvdFvmkkyTCsg9s6bA4MfcFAc+I/Eo5rdsiXtNz/IjuU6KsT/8+ROugXA17+dgD8zMzUhKCWSN9B6MPvAYCLecgj2VR
X-OriginatorOrg: wdc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM8PR04MB8037.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1c57d12d-f612-4dfa-a202-08dc5abfef38
X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Apr 2024 07:12:37.8052
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: J21s3qC8yMSJuPh9TwR74VXCTO7RvwZEf9v/GN/w5GPYUym/BKNEL+zS8+ksryjp5jDTj+sH5F5a1yOCVemaUK/2WZS2Ip/pZPV2AKM1gZ0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR04MB6309

On Apr 10, 2024 / 23:39, Saranya Muruganandam wrote:
> The BLKRRPART ioctl used to report errors such as EIO before we changed
> the blkdev_reread_part() logic.
>=20
> Add a flag and capture the errors returned by bdev_disk_changed()
> when the flag is set. Set this flag for the BLKRRPART path when we
> want the errors to be reported when rereading partitions on the disk.
>=20
> Link: https://lore.kernel.org/all/20240320015134.GA14267@lst.de/
> Suggested-by: Christoph Hellwig <hch@lst.de>
> Tested: Tested by simulating failure to the block device and will
> propose a new test to blktests.
> Fixes: 4601b4b130de ("block: reopen the device in blkdev_reread_part")
> Reported-by: Saranya Muruganandam <saranyamohan@google.com>
> Signed-off-by: Saranya Muruganandam <saranyamohan@google.com>

The change looks good to me. I also confirmed the fix with the new,
corresponding blktests test case.

Reviewed-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Tested-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>=