Received: by 2002:ab2:7041:0:b0:1f4:bcc8:f211 with SMTP id x1csp15962lql; Fri, 12 Apr 2024 02:02:52 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUvx9ySHvFvn9iT5x8LErG7yB6sJRQkm3lknoArpYcksxZck/sZvR6wZbJVcDfdu5LJi5yMK/RLbtgljd18hNfYAS5f8esA2tVurS+kqg== X-Google-Smtp-Source: AGHT+IFKUTYyktMJTA8iezJwqotBaEqUwAsCmy3YTmf16ziDUmknvNXvfoavPqnVmpw/9y6PYq45 X-Received: by 2002:a05:6e02:1a4e:b0:369:f74f:bbe8 with SMTP id u14-20020a056e021a4e00b00369f74fbbe8mr2087519ilv.14.1712912572074; Fri, 12 Apr 2024 02:02:52 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712912572; cv=pass; d=google.com; s=arc-20160816; b=qJWpiNmnwd1025E42lilzIuA7jiRMu1awvTuD41G+XgyzKPFto0ujQGd242oOnvwTl qZbJyJBjxJTEGPqvAT23VJ5ecfBPjjl9SKO0zwWshjyIjcFo/zAtRDzprs2C4daCNRUD 0RWMwQShVCJiPtWbFWhy8mlLcJK6m8GSD2Zv5xsjV1XRKvaxa4SCLehq1H0Qm8DPtO4F 1I9bzNB6leDBfO8iQzXol9iVysfP3POQIgqqETzbqsphDKK3pXZ0ng1ZN+9dhK0fOsaS bHT+fMsx8XxAp9TW6N/CfTg5L9kinS5cr/D22umJmSkN9+PA/jyxDTXKUVYuJu+Xek09 foOQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=efuhdo0i03t5yOkas8ZyTg+oZMkYR/wT7SM72lv7bDI=; fh=NDCPdPn2hiqHaiIRDYQAzsW9PK20CTia4nECGof6enU=; b=COuv/FuouUGJ11wShES5b52X0NYeizgy6tWLmCMqszTVjL1R9CP44hDT8bcK7Xhtv6 b9gbAeUOqccbmo4XzN6Exph5MXsSB7zHUXd+tZdrzLm4k1K+qYN9r7C4000Ew8QHplI9 Alrv5D/Pc9CCUdiNUehSN0yFfw9jXAhfHHI8I5mFL6BBhtj8qB9NRjdpVJNSvYYMXoYR JCblB8RdGk55DYJ+MZgpeLatpYsHA9jJKkY3CA1qyJzpvFuQkEVg0+SbMYBrwb1GDhiS u10B0iZMQifjOK8491PUysetxGdIqy+UT9gg/yWH+KAvyRiVXvLB8tODUkJbD/dYiDKK Tzmg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=arm.com dmarc=pass fromdomain=arm.com); spf=pass (google.com: domain of linux-kernel+bounces-142295-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-142295-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id 18-20020a631952000000b005f05c95f71dsi2873076pgz.358.2024.04.12.02.02.51 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Apr 2024 02:02:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-142295-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=arm.com dmarc=pass fromdomain=arm.com); spf=pass (google.com: domain of linux-kernel+bounces-142295-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-142295-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id A309A28A3EE for ; Fri, 12 Apr 2024 08:56:05 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C85B48593A; Fri, 12 Apr 2024 08:44:20 +0000 (UTC) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id AA9A185261; Fri, 12 Apr 2024 08:44:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712911460; cv=none; b=Exr6C6zw3EKLIewqEbe/P6l9Ca1XTbNY5uhT221xyJFy3Kza6vhwD9olTay8dxFY51khTt802ecM1pGgOn7dcTnOX+p1RpnDuia0Yw9twZVbDynk5KARgV4q0rYN5uw+4wqQmk6S9phK0PzLvF8iSPMfXbyweulxdiTB2aMRLKU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712911460; c=relaxed/simple; bh=/ylcxNjyNjOH/FxoiCWd7H6320+ueYCpQ0azhp+BuI4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Aet8OkdmPq/nt5QrAQUs0WDD47Jtzp4HleUpVQ17NbBsIvuOne7Gq5tDlEOb3g4IUX1BWtgRS0BbqlTi6h/EmxORYsRzZYgn570KXzJ3kfO6UllageOAR1aKwSxAnr/HfkKfDK04/Dm31ErZvJmOFfZH8m+C/cMGRw1a9bGY97w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 67FE414BF; Fri, 12 Apr 2024 01:44:46 -0700 (PDT) Received: from e112269-lin.cambridge.arm.com (e112269-lin.cambridge.arm.com [10.1.194.51]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0BC5C3F6C4; Fri, 12 Apr 2024 01:44:14 -0700 (PDT) From: Steven Price To: kvm@vger.kernel.org, kvmarm@lists.linux.dev Cc: Steven Price , Catalin Marinas , Marc Zyngier , Will Deacon , James Morse , Oliver Upton , Suzuki K Poulose , Zenghui Yu , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Joey Gouly , Alexandru Elisei , Christoffer Dall , Fuad Tabba , linux-coco@lists.linux.dev, Ganapatrao Kulkarni Subject: [PATCH v2 25/43] KVM: arm64: WARN on injected undef exceptions Date: Fri, 12 Apr 2024 09:42:51 +0100 Message-Id: <20240412084309.1733783-26-steven.price@arm.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240412084309.1733783-1-steven.price@arm.com> References: <20240412084056.1733704-1-steven.price@arm.com> <20240412084309.1733783-1-steven.price@arm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The RMM doesn't allow injection of a undefined exception into a realm guest. Add a WARN to catch if this ever happens. Signed-off-by: Steven Price --- arch/arm64/kvm/inject_fault.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm64/kvm/inject_fault.c b/arch/arm64/kvm/inject_fault.c index a640e839848e..44ce1c9bdc2e 100644 --- a/arch/arm64/kvm/inject_fault.c +++ b/arch/arm64/kvm/inject_fault.c @@ -224,6 +224,8 @@ void kvm_inject_size_fault(struct kvm_vcpu *vcpu) */ void kvm_inject_undefined(struct kvm_vcpu *vcpu) { + if (vcpu_is_rec(vcpu)) + WARN(1, "Cannot inject undefined exception into REC. Continuing with unknown behaviour"); if (vcpu_el1_is_32bit(vcpu)) inject_undef32(vcpu); else -- 2.34.1