Received: by 2002:ab2:7041:0:b0:1f4:bcc8:f211 with SMTP id x1csp22208lql; Fri, 12 Apr 2024 02:17:51 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUk4XWuJ4mNys+NEAUeStXuxdwq/xhQyPPwPLqOw31KY5wCiM50KOTQwfF2AvWMlbtMt/VL/Y/90/sHSXoZl1yRfSZ3IgJ4a6TdPlNSFg== X-Google-Smtp-Source: AGHT+IHorEde4RfQUgISv9cpug196wF8cnYZw2ELpQyNnkhbT/dVqLUGqFzAquayuXz8rPU5V6mP X-Received: by 2002:a05:620a:462a:b0:78d:63de:c05 with SMTP id br42-20020a05620a462a00b0078d63de0c05mr2638756qkb.33.1712913471088; Fri, 12 Apr 2024 02:17:51 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712913471; cv=pass; d=google.com; s=arc-20160816; b=vAhj5Ped6+cYO/LX8YoCIV5g5GuI0VVaLIjGFJXiosyWfSj0kOWbZHy/cdiyFYqlZ2 KzNBNBO0G/hofKgLsd69fbzWX7bhCKMVyNcGfSTWd1YXDCuD4KvRHfJ/rDil57RPFBEl il6zq7ZK9LetnZywtrWZp/1x7N7g8PdVHgYKKMTOoEqkxeDmwvJ/hbIBGO19zoiA3U6S 2RSdDZPqhKT6mtYyq43eMy4nF4oF/0nsOY9bYKN/nx07nw6migb1+GNZ8Amg9nFwmFaH fzG8kvdmrsauzX0yBhyBjDqI1JXk1chuMQIwNLefNil6aNLc7uROsJRskSfZ1W6BQLEa VFfQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=NpTqhd0B9/xzNoER4WA8UDMsth7BUMydRvViv6uQMmo=; fh=ol5tBpkr6M4Eagb+Fj5ovAVE9XfC6R5Fa8txmRnqqoU=; b=Ow49biV4rCy44zxyxPypjYge0dvDX5zODVStnhPcaBhvBOWntb0BF7lY/tJd2N1W8Y yRncMYU3zqPmSbPBtQ8hRLYz3Nr+zFgeYk0N41SVXEyX8gzgZrLB4ufXU++hGyEbQCni +XFfpEULCZ0TgBnaMDNLuzCDj7/K2cuiTZJqEQAUp8wd35aj6X/F5ZUBBwnblUfgsQ6E FNHeG9pNdyy1Rec5+FVMwNxOp4w/RA2HeyPQtrOs5E8hN9S4MBFxLSCojOYi1vvixqAd athTLST6XewHO14nzf+9o9HKR7+34et4aJ7NhY2qLhG58k9+09WPNd7cdSxf2+EYfjWw H2CQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=TKFX4Z1X; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-142369-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-142369-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id ee20-20020a05620a801400b0078ec66f3fcfsi2490595qkb.631.2024.04.12.02.17.50 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Apr 2024 02:17:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-142369-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=TKFX4Z1X; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-142369-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-142369-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id B5CC71C213AC for ; Fri, 12 Apr 2024 09:17:50 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 9D3405026B; Fri, 12 Apr 2024 09:17:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="TKFX4Z1X" Received: from mail-ed1-f49.google.com (mail-ed1-f49.google.com [209.85.208.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3033D3A1DE for ; Fri, 12 Apr 2024 09:17:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712913463; cv=none; b=u9Ufu6SwsmySjtWHnIsdvf5Klw60oNXLNSpItEcbTfJ7g6mAZC56T8M9Szwy4PGZaMlP2f8SHjmZMW9ITAb5JI7ajsT5k0dmjCKQgMZeRVDmBqOLAqDSx9A3mH7JRFyWU0p67K1cRYuDM/kAuu5U0AD5GqmEURKJrAyqH7VKDsY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712913463; c=relaxed/simple; bh=FUKtKtdq36Vt1r49LS8QSvI7oP2R7ODnRMLXyosQE2g=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=euf+t+O5QtfT+s/vVo/7Fej2vgZUyXqKrLClZ2NJkh7ZP/9OOyuuEeKjEAYomFoFGvpIkVi0kiFLJbqKUW4WIQ2fohG99/RPsBssKTzLSU4AQzKt16ZrZTHlGMMwFwmwgjBWr9wLsVbzLr0XtbThtfv9wm/9aEoEmFtojjktvZM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=TKFX4Z1X; arc=none smtp.client-ip=209.85.208.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-ed1-f49.google.com with SMTP id 4fb4d7f45d1cf-56e1bbdb362so700631a12.1 for ; Fri, 12 Apr 2024 02:17:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1712913460; x=1713518260; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=NpTqhd0B9/xzNoER4WA8UDMsth7BUMydRvViv6uQMmo=; b=TKFX4Z1XJWkQ9N4MhCD1f73C1dbDhjWbELbrHG+BfRwZ/jJlCSV4tCzZl3CviydKMf RIBmsiog/28zIBS4juJKek9QmZ8CffYyiputBrLfPNZe7xmvvEyGWoXfwWjRc122MrbO oabKaUJHviRzJnYDbJhbsD3J5pP5aG0CL+iSeCgXvYZP3Fb3cfcUY4WVVryH0A79nmpB Uu4AncipQUvveomsgWxbohkonzuT2aKaT1lSWg6XMKwBg20iM+mTi+b8DTo8bKfzkVI2 OUv1PvPgF/lMnyDrB3me6+YR8y6dEF2M9BVtNTy7Mcubc74f6Eu7p/uczxX08kgDHm00 l0PA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712913460; x=1713518260; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=NpTqhd0B9/xzNoER4WA8UDMsth7BUMydRvViv6uQMmo=; b=CNquo8LVedQoK463hSyvoO/zIrUdF/ImbliQqUE+G4M608x9iIvSXJy77VQMCnYM9T tio2d6ncxMubz/GeCZn3lsJPmaxXYMK3H4KA/wUXSiz4K0AxUrzpP7vyhOKNuL6CCRDM U+1sE4/nL9GwWAkm1Ro468BDzPO3nhmcYYDBqWSatHNWZPehwJuK4Q80qLwFcTXe2oqU XSI6+KmtXgbBcW3BNGSFPF617iFRWXadWf/0sU3kYJ7ccWkSs3QDj+jKb1udvajhEXho adkBuPrt2uFVe/eIoxdiatK2+he4+ssvg5tl/tj8wH9NNVFYmaPuHxyB1Cb+OHQhYgvh 4/+Q== X-Forwarded-Encrypted: i=1; AJvYcCV+/DSU3PzHSe21G87u8MhBBV3ZjI4wQniZAQ1bQHDt/fB21Ag97MnebdFmhVCEQ/GKa4VcI29YsaH3RVthWM7CNnRGP9OL6VxS2Kyj X-Gm-Message-State: AOJu0Yy6FRLy+E+xw+l86sPNwJfrDKYOv8jULJiGRvMZpojENytN0q+H L41/OuQdIp8LXnrAG+2X+aMIykJyofU1+Om+uDrVmsq1NnUilXGQQYAoIAEnhBw= X-Received: by 2002:a50:d542:0:b0:56f:e489:471a with SMTP id f2-20020a50d542000000b0056fe489471amr1659588edj.5.1712913460463; Fri, 12 Apr 2024 02:17:40 -0700 (PDT) Received: from [192.168.1.20] ([178.197.223.16]) by smtp.gmail.com with ESMTPSA id k20-20020aa7c054000000b0056ff82e54a0sm675063edo.31.2024.04.12.02.17.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 12 Apr 2024 02:17:40 -0700 (PDT) Message-ID: <86bf8248-2443-4ced-a67c-7845fef98fd3@linaro.org> Date: Fri, 12 Apr 2024 11:17:38 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/5] drivers/rtc/rtc-xgene: Add "snps,dw-apb-rtc" into the "compatible" To: wefu@redhat.com, jszhang@kernel.org, alexandre.belloni@bootlin.com, robh@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, guoren@kernel.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu Cc: linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org References: <20240412080238.134191-1-wefu@redhat.com> <20240412080238.134191-4-wefu@redhat.com> Content-Language: en-US From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: <20240412080238.134191-4-wefu@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 12/04/2024 10:01, wefu@redhat.com wrote: > From: Wei Fu > > This patch add "snps,dw-apb-rtc" into the "compatible". Please do not use "This commit/patch/change", but imperative mood. See longer explanation here: https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95 This we see from the patch. Say what hardware are you adding? Please run scripts/checkpatch.pl and fix reported warnings. Then please run `scripts/checkpatch.pl --strict` and (probably) fix more warnings. Some warnings can be ignored, especially from --strict run, but the code here looks like it needs a fix. Feel free to get in touch if the warning is not clear. Best regards, Krzysztof