Received-SPF: pass (google.com: domain of linux-kernel+bounces-142406-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Fri, 12 Apr 2024 10:26:46 +0100
From: Sudeep Holla <sudeep.holla@arm.com>
To: Ruidong Tian <tianruidong@linux.alibaba.com>
Cc: robert.moore@intel.com, rafael.j.wysocki@intel.com, lenb@kernel.org,
	linux-acpi@vger.kernel.org, acpica-devel@lists.linux.dev,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/2] ACPICA: AEST: Support AEST V2
Message-ID: <Zhj-VtiWyTd-zq5w@bogus>
References: <20240410063602.41540-1-tianruidong@linux.alibaba.com>
 <ZhZacAOVpAXK8lDE@bogus>
 <e3c91a7b-4bcc-45ce-92e6-c6a50ad80479@linux.alibaba.com>
 <Zhep-UCqqPlg9BIh@bogus>
 <8ff4deab-13ab-4fdf-b418-fbfefe46c087@linux.alibaba.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <8ff4deab-13ab-4fdf-b418-fbfefe46c087@linux.alibaba.com>

On Fri, Apr 12, 2024 at 10:41:31AM +0800, Ruidong Tian wrote:
>
>
> 在 2024/4/11 17:14, Sudeep Holla 写道:
> > On Thu, Apr 11, 2024 at 03:54:48PM +0800, Ruidong Tian wrote:
> > >
> > >
> > > 在 2024/4/10 17:22, Sudeep Holla 写道:
> > > > On Wed, Apr 10, 2024 at 02:36:00PM +0800, Ruidong Tian wrote:
> > > > > AEST V2 was published[1], add V2 support based on AEST V1.
> > > > >
> > > >
> > > > Any changes to ACPICA has to get merged in the external ACPICA project.
> > > > Refer [1] for details from Rafael. You can also refer [2] in the kernel
> > > > docs.
> > > >
> > >
> > > Patch1 is just a fix to follow kernel code style.
> >
> > IIUC such changes are not allowed as ACPICA changes are always imported
> > from the external project. So you have to take same route as patch2
>
> In ACPICA, all struct use typedef which is not allowed in kernel:
>
>     It's a **mistake** to use typedef for structures and pointers[1].
>

Fair enough.

> I see all other structs in actbl2.h follow this rule, so I fix all typedef
> in AEST struct to follow kernel code style. But i can not apple this fix in
> ACPICA. Patch1 is just a kernel patch.
>

No patches from the kernel tree applies to APCICA because of some variations
in the coding style that the import script modifies when applying to the
kernel. So make similar changes in APCICA project and send it there. It will
get imported if it gets merged there.

--
Regards,
Sudeep