Received-SPF: pass (google.com: domain of linux-kernel+bounces-142431-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: John Garry <john.g.garry@oracle.com>
To: jejb@linux.ibm.com, martin.petersen@oracle.com
Cc: bvanassche@acm.org, linux-scsi@vger.kernel.org,
        linux-kernel@vger.kernel.org, John Garry <john.g.garry@oracle.com>
Subject: [PATCH] scsi: sd: Only print updates to permanent stream count
Date: Fri, 12 Apr 2024 09:44:07 +0000
Message-Id: <20240412094407.496251-1-john.g.garry@oracle.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?DAT67qdjZkxHDcD+ULSE5bL5aj5ImugYNzBj7v0ZF8p0cMvVm6/QI3RnWoC9?=
 =?us-ascii?Q?4xEcacN6iEBURyu3XHK5qYscZ04R1nU1c0I4luzKefXmHkSswhnTBHEEJdGq?=
 =?us-ascii?Q?lb8nHWcoiEXUhlWaVU+zaxRCUS08c9nVjQUiIWE228HHEfQSkdAcCYkrraAr?=
 =?us-ascii?Q?2nItrdYHhFp2jqlg0tSbWVrFX/sVObrHkACnqTMbNjlnPbts8Floj7NPBivL?=
 =?us-ascii?Q?QHQkUwwOwI/tNF4ytHuCFhufDV/+NuoDCY21GNkYbQ6iDe+nw+3PwL0nyWfM?=
 =?us-ascii?Q?4GCfSTsV6a1ySxlqbfQPv4iVFvCkbDppFwvMKHcNl6GoZKixrB1FvUorN+By?=
 =?us-ascii?Q?BdRAXVthOpbaS1Q8vgUqRjZEQyfxe/TAWHV3K3pA8VaQye6GbukdbnpiPuUt?=
 =?us-ascii?Q?yIy60jHFzAYbxYyJvQ1DKxvoeEFraOASeEwkXwkwAOVN4C3BAE18oouipF0E?=
 =?us-ascii?Q?k09bnNs46CGOwNHjAorHb8D4IoB8lFma7o7tmKntLQ75QxC+PlzHXzgAX/1P?=
 =?us-ascii?Q?qpHK7jwdAuGLPB+4YODRnwrS4/PNPtMQ9cKH3uGqtHsrV2MCPuw+mvOGwFpD?=
 =?us-ascii?Q?nVMZhOvaeVIfReySm5DumDphV64TlL3iM1Br3w3Iv4XBiL7v9PZ580Dx7v68?=
 =?us-ascii?Q?zLe78lB7sSEHkU5UqO1uL+O/YtfkSNV38uVIi/1cN9XO2LeeVjtutR4c6CDW?=
 =?us-ascii?Q?c55i4oI96YEUx0sSHBxHlkpKOcoqCfuBPjIsn/h/7+2ztvHiO/DQ1dkHt0cL?=
 =?us-ascii?Q?n5/OuWGND3xfri64ivKW/IM6agQ+bsyltn8fAbstAmq9DiJ9JWuJTmlFDLzA?=
 =?us-ascii?Q?vJZt88pVfcQwDPTy8qwPCWi6lL+PY2pug13J7yA3pJYnihMZn4/fdde+EWh3?=
 =?us-ascii?Q?ji9oB2eiNYtH+xzXBumNiYSJaLYyJWJNtE9hhH/SDqJF60Qh9uyqF9NdED3R?=
 =?us-ascii?Q?C2Aa2l1/ejjgMA/zcTXT7uelh5zbM89/qBksegarMhmQrI0RvyXrWPRq11J6?=
 =?us-ascii?Q?UVjVe3wrOXoGh1CS6LYwIp8QPNmjdW/rs/vZUrEYH84xERalOq7I2Mt7bnNV?=
 =?us-ascii?Q?hydgnWMZJg/O1QDiKV5tOr7ELhN7MF6/JjN2PuBn5RvjyEfiHQuaxTvYgr3p?=
 =?us-ascii?Q?mnOK/VL0vXKiWX7IcPFzPexVdXqkePgV7j7iJiCeTL8oT3mzE0AbSJE8yNna?=
 =?us-ascii?Q?saXE4/FtAeNGiccMlmv+v+ra2LW6gvoLjoGtlv6m4GI5aUXSwpoC2Y8hoLZ1?=
 =?us-ascii?Q?z2mk8E36Z/uANxgdrbo/BTJcwIisNRfh2bMocljDjwdujXj8Gyh81+QIBM+K?=
 =?us-ascii?Q?klErKZZdjxMyI4VCg6LmqXRVo2ijLs5uRr6r0t+wGzH2QUOgfzH0/9tIm0xU?=
 =?us-ascii?Q?s9alqlngzfhgDmLnAsZS3VZFIxjcac9IwYaR+Foh7cOKNVSOXPT1yG1giu9H?=
 =?us-ascii?Q?Spe0v0UFKgn5DF4A9lYy0GCXw413lMONUis5cOJJf8POn2IpeklaHlXHathI?=
 =?us-ascii?Q?LnGl+2T1OF8twFDdo/a7q3YSqmOzQbTO4Ju84Sttmrtdc5OY83P6o6OS2qoH?=
 =?us-ascii?Q?4Lfmy8VdZbcmQ7TQLrKuPzUoTXbYeDddMFGGTHh6?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	Ch38+WhtTtcWpfue+l56ihJUo35ASpLgya4vFudG+nYOTv31mD85Sttx6Ocb8ZBNCWIHcTN4pFCU+/jTvRMK/EfCtv+p5W5lb37/wmd+0mkbIfKJmJn2mzeveSwalTXUmMgIlb4RHhX2ICD/hp+dlEPwdXPBhJZ++hKajz3HovZQHfNAqIyuMjWTKNHbRYuuPxRku6AvIGz6Eo/jQs+ss0UqB5xka8Hg6S4rRRdrJjY66FebQmWf/NlrGLU21c0H/7w8Wy5hp1TXBuIPL/ArY2VEBgiZ9eB2+mnS8sZH0dZrsKhVCvLANg77t0NmtuQowyaTnIVy8C4Tygejb1umuLPLT+5ktpWDRMaoyb7nf3Wvh4YuzKeKNrtxGXkGzyyvjl7qyJp2+xu9Tdcn72ScCl5/cPzIhLhW/qV3AHhwa77ktD6xTmukC5DHRozYNiC1cIBbBG+jcLErWbilFXxfQs08J6nRQz9zf523KYemc3WfYeIUTaGx7Zk5k8vlfTv8+4Do1rYEqUTms+DojLCP+QrohSaCZNM+flTWxK8f+YcOoHCwexUGfR0bSFRdjvvwa2OSgzFGlaFZu0SSZdSFyNPPC/ZMjAj1mSPpdVxdYkY=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8d00b949-d5e8-497d-0016-08dc5ad52504
X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Apr 2024 09:44:27.7691
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4pYfuOvqmFZNyn4ycH27xAPPiajYaX/k5aFWqbKEuriM44jgt+kmHB2jsZWVKaKfnL8xZQNWm1qOay6wmV8DTQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR10MB4362
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-04-12_06,2024-04-09_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 phishscore=0
 adultscore=0 malwarescore=0 bulkscore=0 suspectscore=0 mlxscore=0
 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2404010000 definitions=main-2404120070
X-Proofpoint-GUID: l-kcL12-HztZ_gH1lVcmbUs3Oax480Nx
X-Proofpoint-ORIG-GUID: l-kcL12-HztZ_gH1lVcmbUs3Oax480Nx

Just rescanning a partition causes a print similar to the following to
appear:
[    1.484964] sd 0:0:0:0: [sda] permanent stream count = 5

This is bothersome, so only print this message for an update.

Fixes: 4f53138fffc2b ("scsi: sd: Translate data lifetime information")
Signed-off-by: John Garry <john.g.garry@oracle.com>

diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
index 58fdf679341d..65cdc8b77e35 100644
--- a/drivers/scsi/sd.c
+++ b/drivers/scsi/sd.c
@@ -3120,6 +3120,7 @@ static void sd_read_io_hints(struct scsi_disk *sdkp, unsigned char *buffer)
 {
 	struct scsi_device *sdp = sdkp->device;
 	const struct scsi_io_group_descriptor *desc, *start, *end;
+	u16 permanent_stream_count_old;
 	struct scsi_sense_hdr sshdr;
 	struct scsi_mode_data data;
 	int res;
@@ -3140,12 +3141,13 @@ static void sd_read_io_hints(struct scsi_disk *sdkp, unsigned char *buffer)
 	for (desc = start; desc < end; desc++)
 		if (!desc->st_enble || !sd_is_perm_stream(sdkp, desc - start))
 			break;
+	permanent_stream_count_old = sdkp->permanent_stream_count;
 	sdkp->permanent_stream_count = desc - start;
 	if (sdkp->rscs && sdkp->permanent_stream_count < 2)
 		sd_printk(KERN_INFO, sdkp,
 			  "Unexpected: RSCS has been set and the permanent stream count is %u\n",
 			  sdkp->permanent_stream_count);
-	else if (sdkp->permanent_stream_count)
+	else if (sdkp->permanent_stream_count != permanent_stream_count_old)
 		sd_printk(KERN_INFO, sdkp, "permanent stream count = %d\n",
 			  sdkp->permanent_stream_count);
 }
-- 
2.31.1