Received-SPF: pass (google.com: domain of linux-kernel+bounces-142437-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Fri, 12 Apr 2024 10:47:36 +0100
From: Conor Dooley <conor.dooley@microchip.com>
To: <wefu@redhat.com>
CC: <jszhang@kernel.org>, <alexandre.belloni@bootlin.com>, <robh@kernel.org>,
	<krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>,
	<guoren@kernel.org>, <paul.walmsley@sifive.com>, <palmer@dabbelt.com>,
	<aou@eecs.berkeley.edu>, <linux-riscv@lists.infradead.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-rtc@vger.kernel.org>
Subject: Re: [PATCH 4/5] Kconfig: Enable APM X-Gene RTC for XuanTie TH1520
Message-ID: <20240412-ogle-daily-c18bc6e7ddd5@wendy>
References: <20240412080238.134191-1-wefu@redhat.com>
 <20240412080238.134191-5-wefu@redhat.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="rrezwGm8P4r68fCr"
Content-Disposition: inline
In-Reply-To: <20240412080238.134191-5-wefu@redhat.com>

--rrezwGm8P4r68fCr
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Apr 12, 2024 at 04:01:46PM +0800, wefu@redhat.com wrote:
> From: Wei Fu <wefu@redhat.com>
>=20
> This patch enables APM X-Gene RTC for XuanTie TH1520.
>=20
> Signed-off-by: Wei Fu <wefu@redhat.com>
> ---
>  drivers/rtc/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig
> index 3a89f1e6095d..b219aeef4ce9 100644
> --- a/drivers/rtc/Kconfig
> +++ b/drivers/rtc/Kconfig
> @@ -1880,7 +1880,7 @@ config RTC_DRV_MT7622
>  config RTC_DRV_XGENE
>  	tristate "APM X-Gene RTC"
>  	depends on HAS_IOMEM
> -	depends on ARCH_XGENE || COMPILE_TEST
> +	depends on ARCH_XGENE || ARCH_THEAD || COMPILE_TEST
>  	help
>  	  If you say yes here you get support for the APM X-Gene SoC real time
>  	  clock.

If I was configuring my system by reading menuconfig, I would have
absolutely no idea that this driver supports platforms other than the
X-Gene one. I think the Kconfig stuff for this likely needs an update to
convey that it's no longer just one SoC family that's supported here.

--rrezwGm8P4r68fCr
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZhkDOAAKCRB4tDGHoIJi
0mNyAP9KxQ4U9S5RMOVtCU2/kCBefOY/cpPKf8icvcFiSV8+zQEAtUzy/SD4CsMb
eHL+pw8s6mfIChq7hPkxKZlv8QtVrgk=
=nx9k
-----END PGP SIGNATURE-----

--rrezwGm8P4r68fCr--