Received: by 2002:ab2:7041:0:b0:1f4:bcc8:f211 with SMTP id x1csp37986lql; Fri, 12 Apr 2024 03:02:30 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVHp6tqGPuEKdYuePWaGvFDzBAVuEYaCvKq/TnXtvjSWLAPBqUGPH2/BlYnl4AIzHtlWwfTxwuP2lTQRUmhdI8Sp5+1EfFVEAzcvtJuyw== X-Google-Smtp-Source: AGHT+IHAolHbEsTMMZ7PN0LNesbFUgr1ZfMp/vEZeTkGtBcgE2Go53eMenl9apj2tN/3ZWAmVWZK X-Received: by 2002:a17:907:9409:b0:a52:27c6:ee67 with SMTP id dk9-20020a170907940900b00a5227c6ee67mr1844382ejc.43.1712916150155; Fri, 12 Apr 2024 03:02:30 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712916150; cv=pass; d=google.com; s=arc-20160816; b=gcbHKaAfnl2NH7rdWu/ioqWE52l7KBONFhSU5AKPJMmdW+Ymj3FOKbhJvwC2vwGFzE xg83oFhLHixoS4MJRLAZoahJ4pn9kQ0YazVTXC2Ri9zbb5Gy3QXEeVqI+6PlS6BlkYRW Z2R/lrx6xEbk4vfLobsI62pNEGB+lYgmHpkd4wk8Yt3eAuki9ibnCDNSiBAHOaPKOYPn EZ3NtT/Z2WxZCcJcySFGdhX7KEhv6mWRFgGSh/CAcmfx6DAX2Sd7F3McwhJ5l0Ux78z1 qlO1d9qWqLvDuNUTyegH+lAxvP1PIpY/VKPl/OcR0hT0SeXU9A26s7QY/Yp8NgOxS29z tAzQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=EdyAYlhJ7SkUNZwE57IUAikUJFPu9zGrR9aQyQiV0sw=; fh=DTWwm9RX7fuZ+9MrG0jgaAAB0GzU+sjg57DWXP/tul8=; b=bhPtAIqV7lX+JBM6HRRWdaZgyg4f2ymZ3vs1gqCJJjzRPMBsVoj/Sd0KX/YJcybCNE 1nlcoqlSIk/hXQ6GEtA9k0ATcJI6dCbqU/OZvV0PWVczb9Xux5KCKwKNgXgaUYjsJK1X Lm+IzQlj7aj/sjNjeR5Neo6wB8sUWFTV2iWgK4TgFA048CfhcKtIUwbQNFyuWgHjLGac UrzVCwiUDUX12pb5IZBb9t5K/0Irwyk+K/AowOYv96swZ5oWHXeUK+SMe4VuAI6GNM2j AKzuTMeGE2+mgh0gCUd7sUVUQSANqazSTgQCbhrHSE8AymvFcv7t8maiAM6UTo/RuLVy NaIA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=bp.renesas.com dmarc=pass fromdomain=bp.renesas.com); spf=pass (google.com: domain of linux-kernel+bounces-142452-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-142452-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=renesas.com Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id a22-20020a1709064a5600b00a4e15c6dc6esi1570109ejv.394.2024.04.12.03.02.30 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Apr 2024 03:02:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-142452-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=bp.renesas.com dmarc=pass fromdomain=bp.renesas.com); spf=pass (google.com: domain of linux-kernel+bounces-142452-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-142452-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=renesas.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id DDCCA1F23510 for ; Fri, 12 Apr 2024 10:02:29 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 4D94955783; Fri, 12 Apr 2024 10:01:21 +0000 (UTC) Received: from relmlie5.idc.renesas.com (relmlor1.renesas.com [210.160.252.171]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 837C154677; Fri, 12 Apr 2024 10:01:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=210.160.252.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712916080; cv=none; b=YDdGMQE/gyOjs9rXEO7aMb2eK/+mM6qc3kKO7UvlN5P5dvD4eaugu3hOFWQPY75yVBvv4LqsJGBMtCtUzhPg5pNoBQwSHrfqobs6gTHs2WicqvaDM05t7k2B7doi5aqzK9oPim8EFC4092poBsUC7OYMfmNswi9cNDGRq4TTXiE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712916080; c=relaxed/simple; bh=b01fvQMwrTUnnSomPYzsVFXLzVPnHUMI9Mj9CzYrfso=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=iJxF987Cyzk04t7YXax0XqyjAUkNQ620Mrn4tgOIxdXi4PQmxELiyeVkycOztgVcq0E21QMaX+h40O77RYcX36rtp5/4OfzVrCYnCRboQXiekCqtbV/Lsl6Uk/hqVj9yxEyJpAK3zNNLNquQ5exjV/T29iRSge2CEnB07yH6V5c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=bp.renesas.com; spf=pass smtp.mailfrom=bp.renesas.com; arc=none smtp.client-ip=210.160.252.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=bp.renesas.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bp.renesas.com X-IronPort-AV: E=Sophos;i="6.07,195,1708354800"; d="scan'208";a="201242371" Received: from unknown (HELO relmlir6.idc.renesas.com) ([10.200.68.152]) by relmlie5.idc.renesas.com with ESMTP; 12 Apr 2024 19:01:15 +0900 Received: from renesas-deb12.cephei.uk (unknown [10.226.93.65]) by relmlir6.idc.renesas.com (Postfix) with ESMTP id 0AF6941E0D16; Fri, 12 Apr 2024 19:01:10 +0900 (JST) From: Paul Barker To: Sergey Shtylyov , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , =?UTF-8?q?Niklas=20S=C3=B6derlund?= Cc: Paul Barker , Claudiu Beznea , Biju Das , YueHaibing , netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [net PATCH v2 3/4] net: ravb: Fix GbEth jumbo packet RX checksum handling Date: Fri, 12 Apr 2024 11:00:23 +0100 Message-Id: <20240412100024.2296-4-paul.barker.ct@bp.renesas.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240412100024.2296-1-paul.barker.ct@bp.renesas.com> References: <20240412100024.2296-1-paul.barker.ct@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sending a 7kB ping packet to the RZ/G2L in v6.9-rc2 causes the following backtrace: WARNING: CPU: 0 PID: 0 at include/linux/skbuff.h:3127 skb_trim+0x30/0x38 Hardware name: Renesas SMARC EVK based on r9a07g044l2 (DT) pc : skb_trim+0x30/0x38 lr : ravb_rx_csum_gbeth+0x40/0x90 Call trace: skb_trim+0x30/0x38 ravb_rx_gbeth+0x56c/0x5cc ravb_poll+0xa0/0x204 __napi_poll+0x38/0x17c This is caused by ravb_rx_gbeth() calling ravb_rx_csum_gbeth() with the wrong skb for a packet which spans multiple descriptors. To fix this, use the correct skb. Fixes: c2da9408579d ("ravb: Add Rx checksum offload support for GbEth") Signed-off-by: Paul Barker Reviewed-by: Sergey Shtylyov --- drivers/net/ethernet/renesas/ravb_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/drivers/net/ethernet/renesas/ravb_main.c index 028ab5c6aaf7..e1e39f65224c 100644 --- a/drivers/net/ethernet/renesas/ravb_main.c +++ b/drivers/net/ethernet/renesas/ravb_main.c @@ -843,7 +843,7 @@ static bool ravb_rx_gbeth(struct net_device *ndev, int *quota, int q) priv->rx_1st_skb->protocol = eth_type_trans(priv->rx_1st_skb, ndev); if (ndev->features & NETIF_F_RXCSUM) - ravb_rx_csum_gbeth(skb); + ravb_rx_csum_gbeth(priv->rx_1st_skb); napi_gro_receive(&priv->napi[q], priv->rx_1st_skb); rx_packets++; -- 2.39.2