Received-SPF: pass (google.com: domain of linux-kernel+bounces-142526-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Fri, 12 Apr 2024 18:45:06 +0800
From: Chao Gao <chao.gao@intel.com>
To: Alejandro Jimenez <alejandro.j.jimenez@oracle.com>
CC: <kvm@vger.kernel.org>, <seanjc@google.com>, <pbonzini@redhat.com>,
	<linux-kernel@vger.kernel.org>, <joao.m.martins@oracle.com>,
	<boris.ostrovsky@oracle.com>, <mark.kanda@oracle.com>,
	<suravee.suthikulpanit@amd.com>, <mlevitsk@redhat.com>
Subject: Re: [RFC 3/3] x86: KVM: stats: Add a stat counter for GALog events
Message-ID: <ZhkQsqRjy1ba+mRm@chao-email>
References: <20240215160136.1256084-1-alejandro.j.jimenez@oracle.com>
 <20240215160136.1256084-4-alejandro.j.jimenez@oracle.com>
 <ZhTj8kdChoqSLpi8@chao-email>
 <98493056-4a75-46ad-be79-eb6784034394@oracle.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <98493056-4a75-46ad-be79-eb6784034394@oracle.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?P0mjnh8R6HiBGdhdglK8xJ3SM9GlrRAlMfeJR6SfF8Jh63Pa9yrvRo21mNVb?=
 =?us-ascii?Q?10hy2eWsTEhNpx6WmOMU9Q8cHfzPF9DACHZ1Yn3CXyhV+PZV20VLz/viHGSQ?=
 =?us-ascii?Q?XoOs7HGvadSaQm33YIYcP7OsM1QwTPRv1uclVgh9l3iERS38vMs63iFEK8zD?=
 =?us-ascii?Q?qDDVJMGvSCv7xHEzBrDjpW5M79RbhNoDLi82MeU0mJU3/M4OILHhgNQHpzrq?=
 =?us-ascii?Q?2Zxu+zhBgcKW4xTSDfXITZWPL3Wn8t3HZ4TDaidMNf5F2+K4J8IWPHfNJ5U6?=
 =?us-ascii?Q?w99MmkWhDPO1cC5bDrcP2H1CazpmzZvbZxKWqqlc0rNLjmHkiborUpweIJCV?=
 =?us-ascii?Q?UEi2x9yrQ/+kcZ6un2MxKdQKlOnJTXz9LhLbEf2gJJE7yzcUo6n5vFWEdMd1?=
 =?us-ascii?Q?UCz+UoEu+ZiZWDRGo3aebySFM2TfwLvKUQE4JDSyJPHZpEtS3IT1PB4KKIDv?=
 =?us-ascii?Q?zfyLhBcMVQi+UXm/vuUauMUllYRrVpxC5WEtGnea1XNdY0ZIi20gWrKlHRNp?=
 =?us-ascii?Q?Z+kOrM62ZYjwLJWKsRNoP191UcEGOz2GfQZ76Dnvf546qecN0aX2FZRQkE5+?=
 =?us-ascii?Q?LewQdcLJEkofLBGo9EbnrQd5KhobkrQJ1durqyPB2xAfNBY0/EyZC+ev94Wr?=
 =?us-ascii?Q?xqhKNysdfJUNonftO1klblDu2BXK8ge5ezEdUg20hcZhAVEOek633aXCS2Ur?=
 =?us-ascii?Q?lGnXmPw1TadG0MP4Bk9tmjVEPFMUJj0F7G3YFwsC/mIazr711m1GrUTlhBQg?=
 =?us-ascii?Q?e2Nn+b2Gxlgt5dx3RdSlZhxAY4s92EzpZ2NE5Sczwk0KxVprmw8UA51OsC/F?=
 =?us-ascii?Q?t5P6n3uOvBFSVZTRb8SDwWkvEKfnD/aUyKWAqvghoKwICwGl/AbnfOeYYlUA?=
 =?us-ascii?Q?9jrHbJ6buAmxWGoxk+npO75n17NrSCzo640EdfrsTShh/IcuU90RKTiGAgLo?=
 =?us-ascii?Q?v9oJW0dJQmGs6IO8OvY37b2/82AcJ41kPcNE5gUY6tmGxrJlp2gQeiappPD4?=
 =?us-ascii?Q?/DD+qESHzg3jbRqKgI3R+frADNFpx9TLAjLm4/Ap0dZq4VStXLscTJl5qRdI?=
 =?us-ascii?Q?FmKJA2xXwM0hLg6DUtJX8Ge8tS+8xPOGSd00zxQdYTpAqv+tiZJryvI0BcQx?=
 =?us-ascii?Q?TjTnheg2/i1/aIrqOKgyeDFelCmk7AHZwSogmmx6C/XOwKizVKdGbA/wkRQ8?=
 =?us-ascii?Q?MYENt7PjoB5hZ0GSyldBvneKcFvCMHPfdRDOX33MBcc9WVAa/KinlRtyV1I4?=
 =?us-ascii?Q?0EP0r/fF0JChq+XqDg+MUZ5AdVtKsOcwMjkYRrvJt41uxpOLZoFZDN/YUd1U?=
 =?us-ascii?Q?NZs69T2okq486ZRwv5bCjqd585dVfvXY8at4Gi60dobxpCEUDddCHvdjki9V?=
 =?us-ascii?Q?eO53QbQ+CezLLRMJKVgLq0CWZBk+3y6NhlyZqgVpzFyFt1v6JGoJ2Fq+3B3f?=
 =?us-ascii?Q?0vTFn5VfNXKxIEGb4T8bGJHn9WWuVvn6YXTR2pcblU3aih4JQSDKe71NPGcT?=
 =?us-ascii?Q?VCKsEU4LMeG7CUelNKZYiXpDLoPnJirItGMCtPDvuTICdKtbaG2f8DDcZmvd?=
 =?us-ascii?Q?9CefmkWMBupDueVwLGqt2Mey9gBzycsM0Ns92bss?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 7a4197b7-6015-4a99-7c15-08dc5adda314
X-MS-Exchange-CrossTenant-AuthSource: CH3PR11MB8660.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Apr 2024 10:45:15.1248
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ejJmeLP38n809Zx3+vKE1T9NVt3Wu4VL+ucfdkWqVVa/gbwj/pwFt++nuSk36K8TmOKOq2ZmzCsK3eP1HYYGUA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB7043
X-OriginatorOrg: intel.com

On Tue, Apr 09, 2024 at 09:31:45PM -0400, Alejandro Jimenez wrote:
>
>On 4/9/24 02:45, Chao Gao wrote:
>> > diff --git a/arch/x86/kvm/svm/avic.c b/arch/x86/kvm/svm/avic.c
>> > index 4b74ea91f4e6..853cafe4a9af 100644
>> > --- a/arch/x86/kvm/svm/avic.c
>> > +++ b/arch/x86/kvm/svm/avic.c
>> > @@ -165,8 +165,10 @@ int avic_ga_log_notifier(u32 ga_tag)
>> > 	 * bit in the vAPIC backing page. So, we just need to schedule
>> > 	 * in the vcpu.
>> > 	 */
>> > -	if (vcpu)
>> > +	if (vcpu) {
>> > 		kvm_vcpu_wake_up(vcpu);
>> > +		++vcpu->stat.ga_log_event;
>> > +	}
>> > 
>> 
>> I am not sure why this is added for SVM only.
>
>I am mostly familiar with AVIC, and much less so with VMX's PI, so this is
>why I am likely missing potential stats that could be useful to expose from
>the VMX  side. I'll be glad to implement any other suggestions you have.
>
>
>it looks to me GALog events are
>> similar to Intel IOMMU's wakeup events. Can we have a general name? maybe
>> iommu_wakeup_event
>
>I believe that after:
>d588bb9be1da ("KVM: VMX: enable IPI virtualization")
>
>both the VT-d PI and the virtualized IPIs code paths will use POSTED_INTR_WAKEUP_VECTOR
>for interrupts targeting a blocked vCPU. So on Intel hosts enabling IPI virtualization,
>a counter incremented in pi_wakeup_handler() would record interrupts from both virtualized
>IPIs and VT-d sources.
>
>I don't think it is correct to generalize this counter since AMD's implementation is
>different; when a blocked vCPU is targeted:
>
>- by device interrupts, it uses the GA Log mechanism
>- by an IPI, it generates an AVIC_INCOMPLETE_IPI #VMEXIT
>
>If the reasoning above is correct, we can add a VMX specific counter (vmx_pi_wakeup_event?)
>that is increased in pi_wakeup_handler() as you suggest, and document the difference
>in behavior so that is not confused as equivalent with the ga_log_event counter.

Correct. If we cannot generalize the counter, I think it is ok to
add the counter for SVM only. Thank you for the clarification.