Received: by 2002:ab2:7041:0:b0:1f4:bcc8:f211 with SMTP id x1csp65782lql; Fri, 12 Apr 2024 04:05:55 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXIY3ABjgOd7RI5HosZHVdS+hf8d2uHNxkWCGDivnr/kAvxDjeam0OP9RNkZxLxNJkzljV7QWf9M8i+e/bhM8KIUUoMBzxpTTm+0VsWEg== X-Google-Smtp-Source: AGHT+IHdrVzgt0wLPrQBL/r3aRZeq5rSCo/3Qq/KAugNI4qX0u2QfX11n65sNdtDS2JnqBQiy6xY X-Received: by 2002:a17:906:5a83:b0:a4e:768a:144f with SMTP id l3-20020a1709065a8300b00a4e768a144fmr1525209ejq.36.1712919955002; Fri, 12 Apr 2024 04:05:55 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712919954; cv=pass; d=google.com; s=arc-20160816; b=R5n63f9nVLpN9nzRV659Rn9gSV28KyHkWZhuf5Ahs+nigEx16YJ2/VFP13LPbS4nmR j377m9x+o4wgdFCvkiGurhD+8ZfvEEFxkYdYSRBxyibNH9tnnxgrzm0w022d2JCG+9lW vaFUi62XUiAgwoJ2RccHRHSLDt3dEk1gWWi+cQhGNcdrrxb8Tl2mI1p2FaOPXe6Ji9ow +zI+DTaiGoY7uOdT8Msjqnqqcb48kyj+tTjBNmq1KxYUf8SLAdWWPGWN1kruiBzItnZ0 UOtqOaZVvFWXcl4gKzrNsnDIy60QM6hPw28N3u6PqoyTZLs95mBTa014Ybloni3gWbVD 1kEA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:list-unsubscribe:list-subscribe :list-id:precedence:dkim-signature; bh=hzfOcKUbZNTZgqT86TeCwDD13GWyo5joeRsaFKSBZXU=; fh=tLiX2Ss4UjoFTPVi8OYu54bx9jUoSPZ0wBK3eSGDtR0=; b=SIkTznqjcse1UMoapF3NMApjzyE6kpCyOSRb0f/aQa2NECzZf9z32eJlSzV0Mav89E fbMJbGxMSHoL7BRmc0jFqms6Kljq6811A24kNeW3UB9bzhKM0hbBUMFNuUX5XysVZeAh b+bf3CCA1QYTIgYIPNZavgyjeM2aJ/KVwmSQL2k7xDcYN0K2+936eOYXmaChus1yjODO neih/qUwBO3R3J56VeJvF15KxvQLpPOdizauTsCFnFSZcyp1+7s7V/a4ChOKF84JwV7X RhjcRP3f7aaSS8Fd5lNGyodQpesxy4gdfaWBIb1Ui7SoLOJXM19SjSOurn4sE05tVVnV G/4A==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=Wd3IZ2Td; arc=pass (i=1 spf=pass spfdomain=google.com dkim=pass dkdomain=google.com dmarc=pass fromdomain=google.com); spf=pass (google.com: domain of linux-kernel+bounces-142552-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-142552-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id gb38-20020a170907962600b00a522485277asi1416857ejc.296.2024.04.12.04.05.54 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Apr 2024 04:05:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-142552-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=Wd3IZ2Td; arc=pass (i=1 spf=pass spfdomain=google.com dkim=pass dkdomain=google.com dmarc=pass fromdomain=google.com); spf=pass (google.com: domain of linux-kernel+bounces-142552-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-142552-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id B5F891F2274B for ; Fri, 12 Apr 2024 11:05:54 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 1F1AD5336D; Fri, 12 Apr 2024 11:05:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Wd3IZ2Td" Received: from mail-yw1-f181.google.com (mail-yw1-f181.google.com [209.85.128.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F3301548E7 for ; Fri, 12 Apr 2024 11:05:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712919940; cv=none; b=Fh7NMjVicHmQg6VuGiTx70wc0EFG28zdXjugxBe7cWulUs+nz0EcCxNKtwijIAiNUSzV8pxtrX955BWpmMRa6OnrP5eMDUj/9rK/Fmi+vq9mEbYzap0yr+r8gLg7sxfAo4E8ua43TZiXva9Uk+WgF2WsjDn1c26fQvz34OcYP6E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712919940; c=relaxed/simple; bh=0IoG0mCZOW0wJmxr2Xu4LuFbvj+6BIcyh7qESx1wVw8=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=t1/bfF7cJqGRlrgIHrZUVxNY7OPr/GOHu2WQXBENhmxoqR7c0EaOSSeYaWE1d59ysl5X7I/YqWpU1NWa1q6NjTPAbopUdGpWEQdUzeAn8uG+8uPWejEnEJcQv8tjx5rAw2fuVCwnhl/+x6M50pUK27/d4tEBakQX8FBg8aPnYlU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=Wd3IZ2Td; arc=none smtp.client-ip=209.85.128.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Received: by mail-yw1-f181.google.com with SMTP id 00721157ae682-617e6c873f3so8029747b3.2 for ; Fri, 12 Apr 2024 04:05:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1712919938; x=1713524738; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=hzfOcKUbZNTZgqT86TeCwDD13GWyo5joeRsaFKSBZXU=; b=Wd3IZ2TdZoHWnqOmtIbwnLYX4N2UhKNYymjo+ZqN0wiSFdxkSb3X/8uYf+QcwQMZ5t 8a9zxaZC/hnWr3tEuvuRIBleVOsamljoXiCr3pjhOiBRK0ydO/jznekn7UPAeajOfKys bKWYCe29yPj8peAKZg1J3kjh5dbzSUak+3c2li8RIYSX7lvUjbmBCcMN62etyATWWo6S VqyNjZPQ9GT5fdbFkGvGik3EivmCkF2ZBUWQD/Oxn2qpcf+hfWlS5OnE0yLlDTYEFOTk 0Ay9CKyBJcomTkXQua6Dkr+DygF1PBLkhOUa8l45zyTCyWHYaBOStKlNxrb9RnyC/Wkb PUlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712919938; x=1713524738; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hzfOcKUbZNTZgqT86TeCwDD13GWyo5joeRsaFKSBZXU=; b=kHfcmtFl82/Wy4CgTDdcIXw7Ay+EbxeMbGgt4wq0P80PGNtpM3CHXbJdlJQzh4TApW najnYz8pbSP695ESbzXN3baNcZ8SqV8cNZpT+2OwesWd13+g68gPXHyeFNF5Z9S+kUHK vhYczCg340YHeu4hK0EhobpRpF4L6FmpyiTMqOdwFOagqcSChzXjC3lywJOiJxyEvlG2 RgVMHFsdqBNtN7ae6wuvrQzz2yscz5NugDuzHPTvQNDn35K3wYdTLCa0KJYpqLbLrIll 1AjQrAezGKeZtWmPjp8rualQMia7Wy0RR9Yw8IejqT7/xMAqhVT1bczLloyXEukTnCMh wrqw== X-Forwarded-Encrypted: i=1; AJvYcCUfJ6KnE3VErJoAODBR/zkWBAPZAAfjn0uqDTXS5rGYiO50WN3ubaiSc/vX0fGO/df0S4mx7B+BHkMyNQprndYHyOYQgA5o7CmhU/fs X-Gm-Message-State: AOJu0YxG5yuOaFPl4HDNtPK9Jk2aGrIRjrJZlVYGvLbqNu1Ea2P1PEBX IqDj+7L3LwNR9tEqHI7v4GeTPJBon4655ud0QS/jxUMoWru9ZjzD9SD51YCjIBwboBeAOqpGPhC FsahFYlnE8T3pASC1EWVWzwpbv+iwFdv+LN6D X-Received: by 2002:a81:83cb:0:b0:615:7311:8f01 with SMTP id t194-20020a8183cb000000b0061573118f01mr1966333ywf.51.1712919937826; Fri, 12 Apr 2024 04:05:37 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240411205428.537700-1-thorsten.blum@toblux.com> In-Reply-To: <20240411205428.537700-1-thorsten.blum@toblux.com> From: Alice Ryhl Date: Fri, 12 Apr 2024 13:05:27 +0200 Message-ID: Subject: Re: [PATCH] rust: helpers: Fix grammar in comment To: Thorsten Blum Cc: Miguel Ojeda , Alex Gaynor , Wedson Almeida Filho , Boqun Feng , Gary Guo , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Apr 11, 2024 at 10:55=E2=80=AFPM Thorsten Blum wrote: > > s/directly the bindings/the bindings directly/ > > Signed-off-by: Thorsten Blum > --- > rust/helpers.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/rust/helpers.c b/rust/helpers.c > index 70e59efd92bc..4c8b7b92a4f4 100644 > --- a/rust/helpers.c > +++ b/rust/helpers.c > @@ -4,7 +4,7 @@ > * cannot be called either. This file explicitly creates functions ("hel= pers") > * that wrap those so that they can be called from Rust. > * > - * Even though Rust kernel modules should never use directly the binding= s, some > + * Even though Rust kernel modules should never use the bindings directl= y, some > * of these helpers need to be exported because Rust generics and inline= d > * functions may not get their code generated in the crate where they ar= e > * defined. Other helpers, called from non-inline functions, may not be Reviewed-by: Alice Ryhl