Received-SPF: pass (google.com: domain of linux-kernel+bounces-142557-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Fri, 12 Apr 2024 13:12:48 +0200
From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To: Raag Jadav <raag.jadav@intel.com>
Cc: jarkko.nikula@linux.intel.com, mika.westerberg@linux.intel.com, 
	andriy.shevchenko@linux.intel.com, linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] pwm: dwc: allow suspend/resume for 16 channels
Message-ID: <zf74jdjza2kfgmiecmlwlws46fmy3rtxvcocmkwewgx64oewpm@xfyq2zt6ts5u>
References: <20240412060812.20412-1-raag.jadav@intel.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="poakpkong5ugzklq"
Content-Disposition: inline
In-Reply-To: <20240412060812.20412-1-raag.jadav@intel.com>


--poakpkong5ugzklq
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hello,

On Fri, Apr 12, 2024 at 11:38:12AM +0530, Raag Jadav wrote:
> diff --git a/drivers/pwm/pwm-dwc.h b/drivers/pwm/pwm-dwc.h
> index a8b074841ae8..c6e2df5a6122 100644
> --- a/drivers/pwm/pwm-dwc.h
> +++ b/drivers/pwm/pwm-dwc.h
> @@ -38,6 +38,12 @@ struct dwc_pwm_info {
>  	unsigned int size;
>  };
> =20
> +struct dwc_pwm_drvdata {
> +	const struct dwc_pwm_info *info;
> +	void __iomem *io_base;

=2Eio_base is only used during init time and so doesn't need to be tracked
in driver data.

Otherwise I (only slightly) dislike
> +	struct dwc_pwm_drvdata *data;
because "data" is very generic. I'd call it ddata. But I don't feel
strong here. I'm happy if you change to "ddata" in v2, I will silently
apply anyhow if you prefer "data".

> +	struct pwm_chip *chips[];
> +};
> +
>  struct dwc_pwm_ctx {
>  	u32 cnt;
>  	u32 cnt2;

Best regards
Uwe

--=20
Pengutronix e.K.                           | Uwe Kleine-K=F6nig            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--poakpkong5ugzklq
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmYZFy8ACgkQj4D7WH0S
/k7jKQf/bACV0R2IYOq2hc4q93teGFMYg3qIOIF1L0GI3pUYcKBM3NR32NrNCl1t
QSLHTq+WjUIaWu7lgbebUfUL9ryD7adwoOyoS2BpvWxpojJWOp2lT8AVXMLYrLQU
0p0dwZiiRzw3jhz+pQ7unXLIYzJQTXiFlKDqwkkbovxdSwXdDGSnyVcRHOQQIFHZ
yx1lKmMnMSzFBPD2VSJQyw/k2K8O0rLA0KAPkAf0pCi2ctE9iPjaL4uhkxBzjD+U
xJKz+W9GlVmmNsCzXbu+YRUOFckZf4EO35CQXfbiqBhk/+DpqlKSdSL6TbJn69p1
/rr4AUJfpYzyaUKHQlO99AHdfprLiw==
=hzLm
-----END PGP SIGNATURE-----

--poakpkong5ugzklq--