Received: by 2002:ab2:7041:0:b0:1f4:bcc8:f211 with SMTP id x1csp82440lql; Fri, 12 Apr 2024 04:38:38 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVlG90LosZ8iDM0m/O5RDerM9HO/KCwY+bnAWHHaX5vyb8tIpPmBw8JsCD2sIdcY6CXQZixPgFc57bV7l6RrYyb2hDdLbTZ/6G8vfGR4A== X-Google-Smtp-Source: AGHT+IEl9BteD9XnHanWnqdgWx1wV3D6eqdNQ8mvuvGmedRgMLmO0l9F/ZH6ytoJaby5vdZKBeAr X-Received: by 2002:a0c:c30f:0:b0:699:273:c6e1 with SMTP id f15-20020a0cc30f000000b006990273c6e1mr2578281qvi.30.1712921918345; Fri, 12 Apr 2024 04:38:38 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712921918; cv=pass; d=google.com; s=arc-20160816; b=KllaCKLwTYZaw10q/bzZHs8wO69ooZOriTf517dpwRYzuPl+JS92g7VEKs3r2E5o/7 L/Eobl84JrqhdvrBJe8bCUoXEa8x7sIvXvBC5LXjImHS1mpwRGcyCxzwPv5B1kcKuuOJ yHpqL78sxjhXkpsw1/9NrbQYTCYl2aEUupcQbcfAhT8fuVaFFSRnAAx3GILFLjEW+gTW snODCHJOQ1OHL7TjSICBgkEzuyD2W+bCszvq4UoveAhqls7p8irckKf/Epma5Af4U/CH pT5Vvj3susUgCMy3G3v23/+4DT+o8Oqe6avkwFUVuOY+TvAG+c2rJnmnPksCPAx2Xyf2 viIA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :user-agent:references:message-id:in-reply-to:subject:cc:to:from :date:dkim-signature; bh=pcVbiopE5s1jI5i68Q20necYfKojVsyTNqFMM/Vxpp0=; fh=gINGm0LMWilNul6AxlLHm4weqUIVul8e2RoRIH907kc=; b=METmm5RuuodZ8QwFqVF18a9R40jdhKGIgjPPi1c8/rSlpQIy529GgoVy86h+aCpMFO 1i5Wsjrzyl4hQQToCNhcFcKHql6EX9I2YL0MJLUBAziT73poumAynF/pW6RttUUF+v+a JLe52w36ATSKTOxH9FW3bWL1iis/Nm19R+Z2fLIrzFmzK4x1Jh64uqdGNvXMXen8dsiS o7iltdWXIV/PEHasLjwcOHiNDmV5sjs3Vm6IPPe3RloIjOoptswihvFVo8StmD/3905n MUpc7vKVrZ8jfIjYxsta/r2WJ4xGQNBR6ZeII5SW3lSWPeUYlRDDKX+5JA2jqdAo1j9K MwZg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=fwFVNXpi; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-142600-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-142600-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id u4-20020a0cec84000000b0069b535eccbasi1964684qvo.388.2024.04.12.04.38.38 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Apr 2024 04:38:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-142600-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=fwFVNXpi; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-142600-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-142600-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 1930C1C20A9C for ; Fri, 12 Apr 2024 11:38:38 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A21FE54FBE; Fri, 12 Apr 2024 11:38:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="fwFVNXpi" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CB2A354918; Fri, 12 Apr 2024 11:38:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712921896; cv=none; b=j/Yd6rvtHXrUpkVWEao32bNBLDqrTJU3xoebhLH07NtwZVLQcl0E4LsM+zF4frFRJEQflFMuh9Q8/vGH/tK+JC4K5O+RCZuG37Elg3OYmDeI4n7GyBnL6U/xSYaBmpnUh4bNTtpkLZzNbi+V7ssE9dsQvWkWc1GD9VfliGSwLn4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712921896; c=relaxed/simple; bh=pGc+Ksvp/3JDoauuu3KTD0EO0x9YqlaiRkeoKCKbnww=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References: MIME-Version:Content-Type; b=n3xYVGQQi3BVt3xauyodlmmcgc5nCCxDA5Xe8upMAbSs66wsRaqQVQZjcLN2Qkd66qugPoUcn5cVb6R3SYMVfc/aop3VDCG5kiZNfbqxC3ttgkJHJRghhdH1T8hgl5T4g06IKMbJNey9oWVHzhUprrkYIVx4WLeoacQ9ews3nEU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=fwFVNXpi; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 544D4C113CC; Fri, 12 Apr 2024 11:38:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712921896; bh=pGc+Ksvp/3JDoauuu3KTD0EO0x9YqlaiRkeoKCKbnww=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=fwFVNXpiPzNtRMkFN+9o4xt/MGLfatDVeS5YCcWOfh9hKW2ItvnsCV/i1OcT1n4cW gYQoyvFXPzbJX38Lr1+KeV2dt432MIBX3sdDwc0pvP6OORDpyAenICW22+4XPaFsI3 bVLE9xeDvESfOM30eL9OuZDyHJBxkXW5bkc9wD/A808tjQ7ORoH1HqysxOnIL3ZSCX RVlbWRHPN2uqo5LbsRCFIWF/jfvXlDwbbcXJS2aqmtPUWLUztReeJIUT21UfPedfhB 2YDcNpfzBHGk3BYQPo1dQINgcXRiAVaWp6PvQtF8kWqaf5wmCeDftEIBW2xDN7gQPA sumu4iglry+6Q== Date: Fri, 12 Apr 2024 13:38:14 +0200 (CEST) From: Jiri Kosina To: Jiapeng Chong cc: bentiss@kernel.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Abaci Robot , Ivan Gorinov Subject: Re: [PATCH] HID: Remove the unused variable minor In-Reply-To: <20240407022804.27081-1-jiapeng.chong@linux.alibaba.com> Message-ID: References: <20240407022804.27081-1-jiapeng.chong@linux.alibaba.com> User-Agent: Alpine 2.21 (LSU 202 2017-01-01) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Sun, 7 Apr 2024, Jiapeng Chong wrote: > Variable minor is not effectively used, so delete it. > > drivers/hid/hid-winwing.c:123:15: warning: variable 'minor' set but not used. > > Reported-by: Abaci Robot > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=8705 > Signed-off-by: Jiapeng Chong I've added Fixes: 266c990debad2 ("HID: Add WinWing Orion2 throttle support") CCed Ivan here, and applied. Thanks, -- Jiri Kosina SUSE Labs