Received-SPF: pass (google.com: domain of linux-kernel+bounces-142636-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Fri, 12 Apr 2024 14:20:12 +0200
From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To: Bjorn Andersson <andersson@kernel.org>
Cc: linux-kernel@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH] samples: qmi: Convert to platform remove callback
 returning void
Message-ID: <g5iy5jov5uufi4oxdfgagqln6odwgdilrbbhsg3lkdidkvybbg@qbmsipcojt4t>
References: <d30beb557e0e97ea194028f62d3c4c10841d3e7c.1709886922.git.u.kleine-koenig@pengutronix.de>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="kn77ildf4qyftzt2"
Content-Disposition: inline
In-Reply-To: <d30beb557e0e97ea194028f62d3c4c10841d3e7c.1709886922.git.u.kleine-koenig@pengutronix.de>


--kn77ildf4qyftzt2
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hello Bjorn,

On Fri, Mar 08, 2024 at 09:51:21AM +0100, Uwe Kleine-K=F6nig wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart
> from emitting a warning) and this typically results in resource leaks.
>=20
> To improve here there is a quest to make the remove callback return
> void. In the first step of this quest all drivers are converted to
> .remove_new(), which already returns void. Eventually after all drivers
> are converted, .remove_new() will be renamed to .remove().
>=20
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>=20
> Signed-off-by: Uwe Kleine-K=F6nig <u.kleine-koenig@pengutronix.de>

This patch didn't receive any feedback yet, I guess because I used an
old email address for Bjorn. I updated the address for this mail now.

Would you consider applying this patch; please tell me if I should
resend.

Best regards
Uwe

--=20
Pengutronix e.K.                           | Uwe Kleine-K=F6nig            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--kn77ildf4qyftzt2
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmYZJvsACgkQj4D7WH0S
/k6LhwgAiwjSAwMLaCjIFh1ywgHYe6zceIUhabfaZ6i33+Asd4VIptXFvirOAe5W
azO3FHpT2uSnT7p5FtEEZM+mJgxnr/o4zq1SlNGceed2TtPU3DgCANMEzDqnX7wb
DDKSVoy/EZza/aVtvLSxkTi7JszYY7QmVxoI0PHSMfwavX8whI1ANPKArYI1rQzd
fJ0ZMqEjpPmv2kCkiidj8mo44qpnXniJ8rCpub3y9v+DFj2i5ejaMS7zR+L1KXj5
kUpoOBq7Y08Oq10sBZRfyzkxehEeDMsRqWGFRW09hXRKxgW0Ju92X+BG/+zHML35
9ayi/YZ2Rj9mhNTNH7JZcIhvzXuaCQ==
=Obza
-----END PGP SIGNATURE-----

--kn77ildf4qyftzt2--