Received-SPF: pass (google.com: domain of linux-kernel+bounces-142642-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Fri, 12 Apr 2024 14:26:48 +0200
From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To: Rodolfo Giometti <giometti@enneenne.com>
Cc: linux-kernel@vger.kernel.org, kernel@pengutronix.de, 
	linuxpps@ml.enneenne.com
Subject: Re: [PATCH] pps: clients: gpio: Convert to platform remove callback
 returning void
Message-ID: <4iii7uxyfovs6ntm7hs2w546k3upbhkepgzxarjk4wnlqmeern@sh6gkyuiqpjs>
References: <f4b9402af72e5f285c8b0f068076a76418f653f5.1709886922.git.u.kleine-koenig@pengutronix.de>
 <6d73b0a4-34e6-44ce-8757-4f4931c3da85@enneenne.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="6gvlmrxnnidgo4ab"
Content-Disposition: inline
In-Reply-To: <6d73b0a4-34e6-44ce-8757-4f4931c3da85@enneenne.com>


--6gvlmrxnnidgo4ab
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

[Cc: +=3D linuxpps@ml.enneenne.com]

On Fri, Mar 08, 2024 at 09:57:29AM +0100, Rodolfo Giometti wrote:
> On 08/03/24 09:51, Uwe Kleine-K=F6nig wrote:
> > The .remove() callback for a platform driver returns an int which makes
> > many driver authors wrongly assume it's possible to do error handling by
> > returning an error code. However the value returned is ignored (apart
> > from emitting a warning) and this typically results in resource leaks.
> >=20
> > To improve here there is a quest to make the remove callback return
> > void. In the first step of this quest all drivers are converted to
> > .remove_new(), which already returns void. Eventually after all drivers
> > are converted, .remove_new() will be renamed to .remove().
> >=20
> > Trivially convert this driver from always returning zero in the remove
> > callback to the void returning variant.
> >=20
> > Signed-off-by: Uwe Kleine-K=F6nig <u.kleine-koenig@pengutronix.de>
>=20
> Acked-by: Rodolfo Giometti <giometti@enneenne.com>

The MAINTAINERS entry for drivers/pps lists you as single maintainer.
Who is expected to pick up this patch given that you "only" send an ack
but didn't pick up the patch? (Or only picked it up in a tree not
included in next.)

Best regards
Uwe

--=20
Pengutronix e.K.                           | Uwe Kleine-K=F6nig            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--6gvlmrxnnidgo4ab
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmYZKIgACgkQj4D7WH0S
/k5IEwf/Q840SKxdW46c7jlpWLRe6JFxdoOz1zEv78UGoww+c6dPbdy4atrzx7gJ
J+7Tvevw52MlzKw9D9sW49RXn5nKHtXOStgJejdomTkLhVWX7O6ci3vq6JwuSStv
qsFe7/X325gDtP6yxPQGBO3UvjfEIHSPSWgHJPzAbVxjb+V2v6Ddb9Q2iBlpo1PZ
x7J2p+F8zLHYLw+KP3j99IdVABZS+9DOftASjIVZfg58YzEb3sgImZA0Ukgm+Hgo
ehExojDWdglDdmH7uIlaMzqK66ePa6XyYMjA+qm2+c2+IXF2C6/Z8pTzx0fosOyk
VU2UVP8EJ/VhfezTto04mqcgrtS5XA==
=VMef
-----END PGP SIGNATURE-----

--6gvlmrxnnidgo4ab--