Received: by 2002:ab2:7041:0:b0:1f4:bcc8:f211 with SMTP id x1csp109397lql; Fri, 12 Apr 2024 05:30:26 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXCAOHSB4vYYFzGDwby8q+tEXzu3S1dEHdxFBEBX3f+cp/PedXYA/Rn/H+adfJJsXpPjtmOSox4lsLxzSsIoQi4HK0BH1uEV7LxFiAcsA== X-Google-Smtp-Source: AGHT+IHDuov+zcAQvUDPjox6EIk25p5no2HQtqCbqy4jQHAB5RhsUBvaIcBb5XqqUkK+kp+jKb1O X-Received: by 2002:a05:6871:646:b0:22e:8b02:fb6e with SMTP id x6-20020a056871064600b0022e8b02fb6emr2346515oan.10.1712925026255; Fri, 12 Apr 2024 05:30:26 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712925026; cv=pass; d=google.com; s=arc-20160816; b=j7TG6P0SMW2GowpYYjvrTrGupIoR/kW5u2BG151CJ8mAzULEVUkvvdVdVKJ+JujcI6 a15GU6KnElDdyBZC633Kq5elpAF/q1LBTVu93Pv5jRaE1Ep36X2jjQEa5uezIAaiq0oC z/LVufDZ3X1R6Y61L9rqtT+uB/xSPf3Ocy7ZiOggCFmLvb2VmnfVR2A4vSPiPx0/ItXe GNcyKVbh/Dmo1o2V4wL7brfVfTyA7l94VOubOcDQYLk/+XBQ2M92Nc+XVbyaAax1Ivcr dPhuJYC8I8N12FVazbWY0ZPBF40hXWMXXgJBclzMmzZKJtyYGDlqY5TKKlwS8y+aHAKy 5bVA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=cUZ/b+jotRKZZifu9V/x0tLXI1mNeegODUtR5Oq6zCs=; fh=ubgSGivyX1a6nEb6mxS2lPUzB/FQ53Lzp2BE7D6lOQ4=; b=f+rn8UhyMShmq6klDnT/jeFUqVu8AJM9jl1hl61ipY/u+CNLspL8BGV8qsrKgRuOtR wmMY2UCfpLqILJ0OIE/axzf40DHg1cI40Qjg4HXMmnwafdbKqHrfFWtSfzYWS/xo4GV2 /SZqZwP0Pa99LTdLIfZYvUw1MXrc8iUdO7k1hR7tl7cJa30/v0s1hN0/wldNnwiztyfP vmS922IXELAZlIxfHOziMhu18DJuAMpGbIpCWc3EAcmf8323EqkTwAGafzb7Z1NhFLz+ X8lOwgQQhcGeVN8VvHebyrfux3DE6dXEqy5zqrVUWmo76MqtAQ4jS1yNEO5u6+mao0MX +wVw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=lEu0zybJ; arc=pass (i=1 spf=pass spfdomain=ideasonboard.com dkim=pass dkdomain=ideasonboard.com); spf=pass (google.com: domain of linux-kernel+bounces-142649-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-142649-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id vv16-20020a05620a563000b0078d674cddcasi3578398qkn.693.2024.04.12.05.30.26 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Apr 2024 05:30:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-142649-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=lEu0zybJ; arc=pass (i=1 spf=pass spfdomain=ideasonboard.com dkim=pass dkdomain=ideasonboard.com); spf=pass (google.com: domain of linux-kernel+bounces-142649-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-142649-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id EDEBC1C227CA for ; Fri, 12 Apr 2024 12:30:25 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A2C3856B87; Fri, 12 Apr 2024 12:29:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="lEu0zybJ" Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 605C658ABD; Fri, 12 Apr 2024 12:29:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712924941; cv=none; b=qcLhv8UtvRQdyf/+BzcYiOazfa76Xv27YKbdY9ZLCc6kYn+8GJd16ZR2KEvA4YSBWfmfWRZoDI7fPDGNeJIJu0271mzVIcl96IujVk8vqfHZ0ECGy0zZj2sCdGsyFTcSAPcTRIKXVk4NLLqNKbPEojbG+B2Zc5Bw/+EbkFQUKGg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712924941; c=relaxed/simple; bh=4GYbdZYD2RT28RNXdLXtShNBw5It82jmKrPm+866PjM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=k/eMGWzcI1cjJK0Fi/p6i10uTHjx3arfe8eDgPOeFiZV9R0TFuE9WP2rqQKpn9l0YPcpYsKfgRxskuPbmlwuTjd/ojdkPW+hwXBbTTGCLnN1hirp6b4pnyqmt20dEV+KMhaC24xELWl3ch5pkGPVK/bu9xLfHxN34rRCEMq4z4U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=lEu0zybJ; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Received: from umang.jain (unknown [103.251.226.65]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 00BFCA12; Fri, 12 Apr 2024 14:28:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1712924895; bh=4GYbdZYD2RT28RNXdLXtShNBw5It82jmKrPm+866PjM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lEu0zybJIqhCPC4QkiugKsvdmtqwKLoiwo7Ly0f69sx/FRUQs2K7caDDLeJdverAt MoSz+d6hDXtDBpbIWgofUzUeKrCzSTg3k0HK7SHHLMshUeGOxNVE+rrTm0ukoGMfrJ /JQgjWrL/Wt2NYx9V1Z5YcotyYZk4ClifPK5G2PU= From: Umang Jain To: linux-media@vger.kernel.org Cc: Alexander Shiyan , Kieran Bingham , Sakari Ailus , open list , Umang Jain Subject: [PATCH v5 5/6] media: imx335: Fix active area height discrepency Date: Fri, 12 Apr 2024 17:58:41 +0530 Message-ID: <20240412122842.193713-6-umang.jain@ideasonboard.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240412122842.193713-1-umang.jain@ideasonboard.com> References: <20240412122842.193713-1-umang.jain@ideasonboard.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The imx335 reports a recommended pixel area of - 2592x1944. The driver supported mode however limits it to height=1940. Fix the height discrepency by correctly the value of height (with updates to vblank and mode registers). The IMX335_REG_HTRIMMING should also be corrected to the start offset(i.e. 48) instead of chosing a abritrary crop start of 384. Signed-off-by: Umang Jain Reviewed-by: Kieran Bingham --- drivers/media/i2c/imx335.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/media/i2c/imx335.c b/drivers/media/i2c/imx335.c index 28ee7154d1f9..75f4b4e0a5da 100644 --- a/drivers/media/i2c/imx335.c +++ b/drivers/media/i2c/imx335.c @@ -251,9 +251,9 @@ static const struct cci_reg_sequence mode_2592x1940_regs[] = { { IMX335_REG_MODE_SELECT, 0x01 }, { IMX335_REG_MASTER_MODE, 0x00 }, { IMX335_REG_WINMODE, 0x04 }, - { IMX335_REG_HTRIMMING_START, 384 }, + { IMX335_REG_HTRIMMING_START, 48 }, { IMX335_REG_HNUM, 2592 }, - { IMX335_REG_Y_OUT_SIZE, 1940 }, + { IMX335_REG_Y_OUT_SIZE, 1944 }, { IMX335_REG_AREA3_ST_ADR_1, 176 }, { IMX335_REG_AREA3_WIDTH_1, 3928 }, { IMX335_REG_OPB_SIZE_V, 0 }, @@ -404,10 +404,10 @@ static const u32 imx335_mbus_codes[] = { /* Supported sensor mode configurations */ static const struct imx335_mode supported_mode = { .width = 2592, - .height = 1940, + .height = 1944, .hblank = 342, - .vblank = 2560, - .vblank_min = 2560, + .vblank = 2556, + .vblank_min = 2556, .vblank_max = 133060, .pclk = 396000000, .reg_list = { -- 2.43.0