Received: by 2002:ab2:7041:0:b0:1f4:bcc8:f211 with SMTP id x1csp111158lql; Fri, 12 Apr 2024 05:33:21 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCX/ncmlWEPzx/gBosaGU2g9VQFpS1uoBX8UDemlqiR0GvPiC90TxVxW0TvJ9v2p/skd2fIecXv3Ie7VsPUcIc5JuocneCqL1bplFPar4w== X-Google-Smtp-Source: AGHT+IHZrpd6OOx5sgY85UDWZi9nqg1GTEs6o8TMEX/t7+8lbVamlQOCpW0SCPRdpRrjx8hgYJY4 X-Received: by 2002:a17:902:6b42:b0:1e3:d8ae:df39 with SMTP id g2-20020a1709026b4200b001e3d8aedf39mr1845910plt.50.1712925200697; Fri, 12 Apr 2024 05:33:20 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712925200; cv=pass; d=google.com; s=arc-20160816; b=J+H51zSB5jSOViMt2ESmqWBQ0yjpsL5xOGOTYmZi/ctQTY30tnpcap742HFAis8pWH N3mKGbgad4H5JROhbJHam41tdz+w8iEtkAW0zYVSf9Owe3HgbgXbhoAofxeOR7/4S11n XxhvxunZPmVyb4LrCzt9UoM3CDxCKdkVm1Bj7HyFWweTBE0llXgxIwxWLhQrtiIDuyB7 khg8FyRx6NITcp/KarlfUwnTwxlpcEaDo6dCNRQaZy1m5l69rl9Ez25tOB6DO7LXh1TK jGmcU1IlmZcb871dIw8Fv4Sixt4kv1gXfNMo/k6JsVch4EvrDlG1um9X0ynkhpszKfPS qBZg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=RcQvf4R0v9SYfF6nYcN0lPr84GrzpzgD38/PdRunJ/I=; fh=PwuX4C2HmGU5MrGYDEjuOgzg+b3lY8lqiW7EvmPok7I=; b=J9c5a/e6pv56TC3v/Q2V7InosBSHvOGr940ejuSLRL3Aj2ScteWEFODT7qTxaJrimS L32uYJbBzfvzl084mCJ3lUydAv57JJ9OKImYFAmHK2hihsr1hYDe5/XDFE8pdtNaO7OM gu1p2MYlgY6fpjfNTo9p2iy9cGneeUSlHYRYd3rUwyoa7+2fXdajmGq1oM0xngOO0URy +bFwOO2VA7XA1lya+ztpmeogQwf7mgOGXNy2vBh5fayEDeeKJMA+SeWpxmoRkZYRAdxw L5+bPHcEpEFlUM9+l88DcqPiJeWx4YlAsGsjNmnbFl6r8Waalwqs4t0x5j4VMKxRTnrg FoQg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=klBY45QZ; arc=pass (i=1 spf=pass spfdomain=ideasonboard.com dkim=pass dkdomain=ideasonboard.com); spf=pass (google.com: domain of linux-kernel+bounces-142650-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-142650-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id c7-20020a170902d48700b001dca6272e21si3178183plg.36.2024.04.12.05.33.20 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Apr 2024 05:33:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-142650-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=klBY45QZ; arc=pass (i=1 spf=pass spfdomain=ideasonboard.com dkim=pass dkdomain=ideasonboard.com); spf=pass (google.com: domain of linux-kernel+bounces-142650-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-142650-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 523E5B23D7B for ; Fri, 12 Apr 2024 12:30:42 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 76CD05A104; Fri, 12 Apr 2024 12:29:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="klBY45QZ" Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 412975914E; Fri, 12 Apr 2024 12:29:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712924943; cv=none; b=KaY6KRYfZyEhnEYWgWAn5Jdspv4uZG4leDHLs0bMTUAFyRBe1PrZ7G5CSXopvtufWEuZAxT6fAib654QQ/v+vCWCgyWueuIh67ttFT3rNvFbRxCBzxD8cvvDVt5DRNv3OyZTmBCjHNNWn7cT3fn5S53PIJg6gfEWQ4e921nCc/4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712924943; c=relaxed/simple; bh=8t/bWqXW0zV16/ONeS9vNG6hR8OuIaVv26rvg7gqMdc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=W2o1K7OCtLjJqfIKMDw8S8XICu2mfTace6Z1JIDhCNtvx0uJhimeYHRTlvOVIxTxTuvDBvQQ01gJFYOs9nFV/fnnrkB4ImQx/HBjqDJJXmHG2ubderxxjW2WzD3vRYi0a9XCk0JLRwiHE94el/O8tv5pg54dcP0cwkbYtNb+WXg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=klBY45QZ; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Received: from umang.jain (unknown [103.251.226.65]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id E8E2BB0E; Fri, 12 Apr 2024 14:28:15 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1712924897; bh=8t/bWqXW0zV16/ONeS9vNG6hR8OuIaVv26rvg7gqMdc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=klBY45QZDNosDttEr9xoPXwtnkltKCeMoqewLw4zTNJXcswqSgoatq9t7eMmmVAvT RBVBK/EL0XE2VUATrW5k81t+4DTIzR3G5j1dLgrZkChLoHda6H3uSjrnM2gdiyxLw0 5UOSM6aArMb6LvVWUjqLiFiD9IqeysacxaEETpfo= From: Umang Jain To: linux-media@vger.kernel.org Cc: Alexander Shiyan , Kieran Bingham , Sakari Ailus , open list , Umang Jain , Tommaso Merciai Subject: [PATCH v5 6/6] media: imx335: Limit analogue gain value Date: Fri, 12 Apr 2024 17:58:42 +0530 Message-ID: <20240412122842.193713-7-umang.jain@ideasonboard.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240412122842.193713-1-umang.jain@ideasonboard.com> References: <20240412122842.193713-1-umang.jain@ideasonboard.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The sensor gain (both analog and digital) are controlled by a single gain value where: - 0dB to 30dB correspond to analog gain - 30.3dB to 72dB correspond to digital gain (with 0.3dB step) Hence, limit the analogue gain value to 100. For digital gain, support can be added later if needed. Signed-off-by: Umang Jain Reviewed-by: Kieran Bingham Reviewed-by: Tommaso Merciai --- drivers/media/i2c/imx335.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/media/i2c/imx335.c b/drivers/media/i2c/imx335.c index 75f4b4e0a5da..4bd547ca71c8 100644 --- a/drivers/media/i2c/imx335.c +++ b/drivers/media/i2c/imx335.c @@ -52,7 +52,7 @@ /* Analog gain control */ #define IMX335_REG_AGAIN CCI_REG8(0x30e8) #define IMX335_AGAIN_MIN 0 -#define IMX335_AGAIN_MAX 240 +#define IMX335_AGAIN_MAX 100 #define IMX335_AGAIN_STEP 1 #define IMX335_AGAIN_DEFAULT 0 @@ -1175,6 +1175,14 @@ static int imx335_init_controls(struct imx335 *imx335) IMX335_EXPOSURE_STEP, IMX335_EXPOSURE_DEFAULT); + /* + * The sensor has an analog gain and a digital gain, both controlled + * through a single gain value, expressed in 0.3dB increments. Values + * from 0.0dB (0) to 30.0dB (100) apply analog gain only, higher values + * up to 72.0dB (240) add further digital gain. Limit the range to + * analog gain only, support for digital gain can be added separately + * if needed. + */ imx335->again_ctrl = v4l2_ctrl_new_std(ctrl_hdlr, &imx335_ctrl_ops, V4L2_CID_ANALOGUE_GAIN, -- 2.43.0