Received: by 2002:ab2:7041:0:b0:1f4:bcc8:f211 with SMTP id x1csp113936lql; Fri, 12 Apr 2024 05:38:27 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVku210UUQBI6zU8LYtKXBUpKyaVp9slFNwBa49TS0ZouOeyWJvw+BwybVnJa4jgJZn/GJ8JO9gMyEuJ/oGyIfkeTPveG4FvyQybt781w== X-Google-Smtp-Source: AGHT+IELQQA15scC7Htyi7RsZTq96T+aCJ8y1etZ0BcT26Idt4GRFC5wznbV7Gux7GwUFb1VSP5b X-Received: by 2002:a05:620a:2198:b0:78d:6fe3:cadb with SMTP id g24-20020a05620a219800b0078d6fe3cadbmr2892314qka.8.1712925506798; Fri, 12 Apr 2024 05:38:26 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712925506; cv=pass; d=google.com; s=arc-20160816; b=GWT4ZaReD+4ZEHwy1e4oo9Fs97qvWCVgswaa2Emlk6Sl/jlyoEyYsdA1CqZtgNYAgO fahFPgYQGqQhTTnhh4fC+ydlHG/+AXOT21uSU1L9/SDmiZg7cwql/FfKr5BGzAQsm4rA ta44FLB0hvWaR4FBQ0d9TWhG+AAtP+jkNezxxaeMABVJxJAld/Y3GNeLXlJHoF29T2Na RY0mjlC98aFyIJbK1gma3SsjmV5uavbkK0K51KYRWb/QrjaV1jKTLFNcXX2I9pf++Jst KZBZo3Q88x/qbx3CkjA2uRAeRwD/Wx/wV8rkwdIVVJSH+tU0FNV8aToHUdGR1hQtkjP3 H4Tg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature; bh=Js1mD56OQap7DaxM6Pc149AZOlFUIpSabFo9pCQxKuU=; fh=KRC5WaXNgGjYhheWrWzv2HlfxGLVVq3YIZvJ74YYDiQ=; b=ijfFwVFtbeocVpjeeNHITup/32cgihJVP2QzVthYFk4ZCtX8eRLUK6dtxsH5jc9VQc BOFznPdM4v1u0cOQLxGtrabmVwdLiizhhu7HyTcLM7Jfpsx1GtP+nRFH4wGlGqk5r4kP cB6l4J1Ij32+Rxeid9Mefek074JVAKYA9VmfLHxUOHDYbLMO26cD98ev7xzySrkVttTO xo3C1+kSt1yCOL9CEC4O1SJpu59WH/Inxi6cHL+9mnWBqzO8WlCae7SQmt7GgB4abHdU mdmDMZFseKZ063c9U2H2X1wqBzAssnY9g5sIAUd/80Trf3vdurPQkKd9TYbZGCJ4N9jo imiw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=YZzCjT2a; arc=pass (i=1 spf=pass spfdomain=quicinc.com dkim=pass dkdomain=quicinc.com dmarc=pass fromdomain=quicinc.com); spf=pass (google.com: domain of linux-kernel+bounces-142661-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-142661-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id v21-20020a05620a091500b0078d66631907si3527733qkv.625.2024.04.12.05.38.26 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Apr 2024 05:38:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-142661-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=YZzCjT2a; arc=pass (i=1 spf=pass spfdomain=quicinc.com dkim=pass dkdomain=quicinc.com dmarc=pass fromdomain=quicinc.com); spf=pass (google.com: domain of linux-kernel+bounces-142661-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-142661-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 782601C22547 for ; Fri, 12 Apr 2024 12:38:26 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E4A0059173; Fri, 12 Apr 2024 12:37:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="YZzCjT2a" Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D59B0205E2B; Fri, 12 Apr 2024 12:37:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712925427; cv=none; b=kgyQcSDBehPYJqHz5tns07rV7Z5w546y1oZsKdWr1xEQP0bOFP7G4m6hdbyNp0YJI4OyW8rid0xuRfWseohvGBqj86tkrysacI5hRKA6EKGq1t5baCV1uhAekXqyhVm5cf6NNTk2DRMW26qpN7TGYLmgcOcrU4hHysqP513vbrE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712925427; c=relaxed/simple; bh=Ogk/ereJRgK1lr8L7mUa2B3KTnAf+gAK1NiWz/vE2Ek=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=rSDwhTKvIFBoCHF14rQtEt3KsR9F9pK/Vv8PMt/o1zDC7HKx/tuBtNGkCT+ODSbdwaAu7DTYbwdbMTEoPv74J/3SkIw/kNj544o9gbq0nIwo6fEG/kTCMQnn/TP2RJ2mhiTxywr9hqG7m8WBUr+VgNaYt3grvK1a4z7l8YODVHI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=YZzCjT2a; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 43CBt30Z006781; Fri, 12 Apr 2024 12:37:01 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= message-id:date:mime-version:subject:to:cc:references:from :in-reply-to:content-type:content-transfer-encoding; s= qcppdkim1; bh=Js1mD56OQap7DaxM6Pc149AZOlFUIpSabFo9pCQxKuU=; b=YZ zCjT2a/mt0JxhrYP9DSOJ0XCsJm+r71qhbePKSRpHto4zX/8pLegFa+RQO3gqYvl +YyotNkq5mgXilUMXK8jyN10KhkMvDZG13hXCLGSCPes02hZtAxVM6rqyzam0pS6 IETFfF6JkX2mplmnWLWorWv5PzDb+/j4oVStifhoH4TantOZhjyT5uGwsA+NYsAi bh1jNXtc5ORDGoz4kTB15L+AQLM+IUUscNn/j7ZvtMrZFz1wGZG2BEURzkTzfCXb joYTYYuZXU6H9zuZOdG4rjY5KrCkVbioRvkf/FPwG9yTN5UhEmCJI1chYtZbB0z5 Q7pjiePKgWTJfPysAM8Q== Received: from nalasppmta02.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3xey6vrrf7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 12 Apr 2024 12:37:00 +0000 (GMT) Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA02.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 43CCax3V013347 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 12 Apr 2024 12:36:59 GMT Received: from [10.216.31.21] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Fri, 12 Apr 2024 05:36:56 -0700 Message-ID: <6a0cc163-0d9d-4481-8a1d-84f27d28941b@quicinc.com> Date: Fri, 12 Apr 2024 18:06:53 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RESEND] arm64: dts: qcom: qcm6490-idp: Name the regulators To: Bjorn Andersson CC: Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , , , References: <20240403132945.2117890-1-quic_uchheda@quicinc.com> Content-Language: en-US From: Umang Chheda In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: clDkKdkjKsRJwwvXYIA0XNWhnqmVIJSC X-Proofpoint-GUID: clDkKdkjKsRJwwvXYIA0XNWhnqmVIJSC X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-04-12_08,2024-04-09_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 bulkscore=0 adultscore=0 malwarescore=0 phishscore=0 spamscore=0 priorityscore=1501 clxscore=1015 impostorscore=0 lowpriorityscore=0 mlxlogscore=999 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2404010003 definitions=main-2404120089 Hi Bjorn, On 4/9/2024 8:46 PM, Bjorn Andersson wrote: > On Wed, Apr 03, 2024 at 06:59:45PM +0530, Umang Chheda wrote: >> Without explicitly specifying names for the regulators they are named >> based on the DeviceTree node name. This results in multiple regulators >> with the same name, making it impossible to reason debug prints and >> regulator_summary. >> > > Why is this marked "RESEND"? I can only find [1]. I misunderstood Elliot's comment that this patch deserves a Resend instead of a new version (v2) as it was just commit subject change. > > But you received review feedback on that one, which you have addressed, > which means that this is a new version of the patch - as such this > should be "[PATCH v2] ...". > > [1] https://lore.kernel.org/all/20240329122940.3649730-1-quic_uchheda@quicinc.com/ > >> Signed-off-by: Umang Chheda >> --- > > And here you can write things that won't be picked up in the git > history, such as the reason for sending the patch, or what changed since > v1. > > > Please look at go/upstream, adopt b4 for preparing your patches, use > --force-revision to send me v3 - where you clarify the changes between > v1 and v2 (this resend). > Thanks for the inputs! > You can specify "Resubmit as v3 to clarify history of patch" or > something like that for the v3 changes. > Ack, I have sent v3 version addressing the above comment. Regards, Umang > > Change itself looks good, thank you. > > Regards, > Bjorn > >> arch/arm64/boot/dts/qcom/qcm6490-idp.dts | 41 ++++++++++++++++++++++++ >> 1 file changed, 41 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts >> index f8f8a43f638d..ac6d741868ca 100644 >> --- a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts >> +++ b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts >> @@ -195,129 +195,151 @@ regulators-0 { >> vdd-l14-l16-supply = <&vreg_s8b_1p272>; >> >> vreg_s1b_1p872: smps1 { >> + regulator-name = "vreg_s1b_1p872"; >> regulator-min-microvolt = <1840000>; >> regulator-max-microvolt = <2040000>; >> }; >> >> vreg_s2b_0p876: smps2 { >> + regulator-name = "vreg_s2b_0p876"; >> regulator-min-microvolt = <570070>; >> regulator-max-microvolt = <1050000>; >> }; >> >> vreg_s7b_0p972: smps7 { >> + regulator-name = "vreg_s7b_0p972"; >> regulator-min-microvolt = <535000>; >> regulator-max-microvolt = <1120000>; >> }; >> >> vreg_s8b_1p272: smps8 { >> + regulator-name = "vreg_s8b_1p272"; >> regulator-min-microvolt = <1200000>; >> regulator-max-microvolt = <1500000>; >> regulator-initial-mode = ; >> }; >> >> vreg_l1b_0p912: ldo1 { >> + regulator-name = "vreg_l1b_0p912"; >> regulator-min-microvolt = <825000>; >> regulator-max-microvolt = <925000>; >> regulator-initial-mode = ; >> }; >> >> vreg_l2b_3p072: ldo2 { >> + regulator-name = "vreg_l2b_3p072"; >> regulator-min-microvolt = <2700000>; >> regulator-max-microvolt = <3544000>; >> regulator-initial-mode = ; >> }; >> >> vreg_l3b_0p504: ldo3 { >> + regulator-name = "vreg_l3b_0p504"; >> regulator-min-microvolt = <312000>; >> regulator-max-microvolt = <910000>; >> regulator-initial-mode = ; >> }; >> >> vreg_l4b_0p752: ldo4 { >> + regulator-name = "vreg_l4b_0p752"; >> regulator-min-microvolt = <752000>; >> regulator-max-microvolt = <820000>; >> regulator-initial-mode = ; >> }; >> >> reg_l5b_0p752: ldo5 { >> + regulator-name = "reg_l5b_0p752"; >> regulator-min-microvolt = <552000>; >> regulator-max-microvolt = <832000>; >> regulator-initial-mode = ; >> }; >> >> vreg_l6b_1p2: ldo6 { >> + regulator-name = "vreg_l6b_1p2"; >> regulator-min-microvolt = <1140000>; >> regulator-max-microvolt = <1260000>; >> regulator-initial-mode = ; >> }; >> >> vreg_l7b_2p952: ldo7 { >> + regulator-name = "vreg_l7b_2p952"; >> regulator-min-microvolt = <2400000>; >> regulator-max-microvolt = <3544000>; >> regulator-initial-mode = ; >> }; >> >> vreg_l8b_0p904: ldo8 { >> + regulator-name = "vreg_l8b_0p904"; >> regulator-min-microvolt = <870000>; >> regulator-max-microvolt = <970000>; >> regulator-initial-mode = ; >> }; >> >> vreg_l9b_1p2: ldo9 { >> + regulator-name = "vreg_l9b_1p2"; >> regulator-min-microvolt = <1200000>; >> regulator-max-microvolt = <1304000>; >> regulator-initial-mode = ; >> }; >> >> vreg_l11b_1p504: ldo11 { >> + regulator-name = "vreg_l11b_1p504"; >> regulator-min-microvolt = <1504000>; >> regulator-max-microvolt = <2000000>; >> regulator-initial-mode = ; >> }; >> >> vreg_l12b_0p751: ldo12 { >> + regulator-name = "vreg_l12b_0p751"; >> regulator-min-microvolt = <751000>; >> regulator-max-microvolt = <824000>; >> regulator-initial-mode = ; >> }; >> >> vreg_l13b_0p53: ldo13 { >> + regulator-name = "vreg_l13b_0p53"; >> regulator-min-microvolt = <530000>; >> regulator-max-microvolt = <824000>; >> regulator-initial-mode = ; >> }; >> >> vreg_l14b_1p08: ldo14 { >> + regulator-name = "vreg_l14b_1p08"; >> regulator-min-microvolt = <1080000>; >> regulator-max-microvolt = <1304000>; >> regulator-initial-mode = ; >> }; >> >> vreg_l15b_0p765: ldo15 { >> + regulator-name = "vreg_l15b_0p765"; >> regulator-min-microvolt = <765000>; >> regulator-max-microvolt = <1020000>; >> regulator-initial-mode = ; >> }; >> >> vreg_l16b_1p1: ldo16 { >> + regulator-name = "vreg_l16b_1p1"; >> regulator-min-microvolt = <1100000>; >> regulator-max-microvolt = <1300000>; >> regulator-initial-mode = ; >> }; >> >> vreg_l17b_1p7: ldo17 { >> + regulator-name = "vreg_l17b_1p7"; >> regulator-min-microvolt = <1700000>; >> regulator-max-microvolt = <1900000>; >> regulator-initial-mode = ; >> }; >> >> vreg_l18b_1p8: ldo18 { >> + regulator-name = "vreg_l18b_1p8"; >> regulator-min-microvolt = <1800000>; >> regulator-max-microvolt = <2000000>; >> regulator-initial-mode = ; >> }; >> >> vreg_l19b_1p8: ldo19 { >> + regulator-name = "vreg_l19b_1p8"; >> regulator-min-microvolt = <1800000>; >> regulator-max-microvolt = <2000000>; >> regulator-initial-mode = ; >> @@ -349,109 +371,128 @@ regulators-1 { >> vdd-bob-supply = <&vph_pwr>; >> >> vreg_s1c_2p19: smps1 { >> + regulator-name = "vreg_s1c_2p19"; >> regulator-min-microvolt = <2190000>; >> regulator-max-microvolt = <2210000>; >> }; >> >> vreg_s2c_0p752: smps2 { >> + regulator-name = "vreg_s2c_0p752"; >> regulator-min-microvolt = <750000>; >> regulator-max-microvolt = <800000>; >> }; >> >> vreg_s5c_0p752: smps5 { >> + regulator-name = "vreg_s5c_0p752"; >> regulator-min-microvolt = <465000>; >> regulator-max-microvolt = <1050000>; >> }; >> >> vreg_s7c_0p752: smps7 { >> + regulator-name = "vreg_s7c_0p752"; >> regulator-min-microvolt = <465000>; >> regulator-max-microvolt = <800000>; >> }; >> >> vreg_s9c_1p084: smps9 { >> + regulator-name = "vreg_s9c_1p084"; >> regulator-min-microvolt = <1010000>; >> regulator-max-microvolt = <1170000>; >> }; >> >> vreg_l1c_1p8: ldo1 { >> + regulator-name = "vreg_l1c_1p8"; >> regulator-min-microvolt = <1800000>; >> regulator-max-microvolt = <1980000>; >> regulator-initial-mode = ; >> }; >> >> vreg_l2c_1p62: ldo2 { >> + regulator-name = "vreg_l2c_1p62"; >> regulator-min-microvolt = <1620000>; >> regulator-max-microvolt = <1980000>; >> regulator-initial-mode = ; >> }; >> >> vreg_l3c_2p8: ldo3 { >> + regulator-name = "vreg_l3c_2p8"; >> regulator-min-microvolt = <2800000>; >> regulator-max-microvolt = <3540000>; >> regulator-initial-mode = ; >> }; >> >> vreg_l4c_1p62: ldo4 { >> + regulator-name = "vreg_l4c_1p62"; >> regulator-min-microvolt = <1620000>; >> regulator-max-microvolt = <3300000>; >> regulator-initial-mode = ; >> }; >> >> vreg_l5c_1p62: ldo5 { >> + regulator-name = "vreg_l5c_1p62"; >> regulator-min-microvolt = <1620000>; >> regulator-max-microvolt = <3300000>; >> regulator-initial-mode = ; >> }; >> >> vreg_l6c_2p96: ldo6 { >> + regulator-name = "vreg_l6c_2p96"; >> regulator-min-microvolt = <1650000>; >> regulator-max-microvolt = <3544000>; >> regulator-initial-mode = ; >> }; >> >> vreg_l7c_3p0: ldo7 { >> + regulator-name = "vreg_l7c_3p0"; >> regulator-min-microvolt = <3000000>; >> regulator-max-microvolt = <3544000>; >> regulator-initial-mode = ; >> }; >> >> vreg_l8c_1p62: ldo8 { >> + regulator-name = "vreg_l8c_1p62"; >> regulator-min-microvolt = <1620000>; >> regulator-max-microvolt = <2000000>; >> regulator-initial-mode = ; >> }; >> >> vreg_l9c_2p96: ldo9 { >> + regulator-name = "vreg_l9c_2p96"; >> regulator-min-microvolt = <2700000>; >> regulator-max-microvolt = <35440000>; >> regulator-initial-mode = ; >> }; >> >> vreg_l10c_0p88: ldo10 { >> + regulator-name = "vreg_l10c_0p88"; >> regulator-min-microvolt = <720000>; >> regulator-max-microvolt = <1050000>; >> regulator-initial-mode = ; >> }; >> >> vreg_l11c_2p8: ldo11 { >> + regulator-name = "vreg_l11c_2p8"; >> regulator-min-microvolt = <2800000>; >> regulator-max-microvolt = <3544000>; >> regulator-initial-mode = ; >> }; >> >> vreg_l12c_1p65: ldo12 { >> + regulator-name = "vreg_l12c_1p65"; >> regulator-min-microvolt = <1650000>; >> regulator-max-microvolt = <2000000>; >> regulator-initial-mode = ; >> }; >> >> vreg_l13c_2p7: ldo13 { >> + regulator-name = "vreg_l13c_2p7"; >> regulator-min-microvolt = <2700000>; >> regulator-max-microvolt = <3544000>; >> regulator-initial-mode = ; >> }; >> >> vreg_bob_3p296: bob { >> + regulator-name = "vreg_bob_3p296"; >> regulator-min-microvolt = <3008000>; >> regulator-max-microvolt = <3960000>; >> }; >> -- >> 2.25.1 >>