Received-SPF: pass (google.com: domain of linux-kernel+bounces-142663-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Precedence: bulk
MIME-Version: 1.0
References: <20240412112931.285507-1-apatel@ventanamicro.com>
In-Reply-To: <20240412112931.285507-1-apatel@ventanamicro.com>
From: Rob Herring <robh@kernel.org>
Date: Fri, 12 Apr 2024 07:37:40 -0500
Message-ID: <CAL_JsqJBpN2qNgiKs_nL+JxM7qaaQkd4Gk06UNefp3gB1HQ7_w@mail.gmail.com>
Subject: Re: [PATCH] of: property: Add fw_devlink support for interrupt-map property
To: Anup Patel <apatel@ventanamicro.com>
Cc: Saravana Kannan <saravanak@google.com>, Palmer Dabbelt <palmer@dabbelt.com>, 
	Paul Walmsley <paul.walmsley@sifive.com>, Atish Patra <atishp@atishpatra.org>, 
	Andrew Jones <ajones@ventanamicro.com>, Sunil V L <sunilvl@ventanamicro.com>, 
	Anup Patel <anup@brainfault.org>, linux-riscv@lists.infradead.org, 
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, Apr 12, 2024 at 6:29=E2=80=AFAM Anup Patel <apatel@ventanamicro.com=
> wrote:
>
> Some of the PCI controllers (such as generic PCI host controller)
> use "interrupt-map" DT property to describe the mapping between
> PCI endpoints and PCI interrupt pins.

I would go as far as saying that's the only case as that's the only
case where the interrupts are not described in DT.

> Currently, there is no fw_devlink created based on "interrupt-map"
> DT property so interrupt controller is not guaranteed to be probed
> before PCI host controller. This mainly affects RISC-V platforms
> where both PCI host controller and interrupt controllers are probed
> as regular platform devices.

That's *every* system with PCI really.

> This creates fw_devlink between consumers (PCI host controller) and
> supplier (interrupt controller) based on "interrupt-map" DT property.
>
> Signed-off-by: Anup Patel <apatel@ventanamicro.com>
> ---
>  drivers/of/property.c | 53 +++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 53 insertions(+)
>
> diff --git a/drivers/of/property.c b/drivers/of/property.c
> index a6358ee99b74..ccbbb651a89a 100644
> --- a/drivers/of/property.c
> +++ b/drivers/of/property.c
> @@ -1311,6 +1311,58 @@ static struct device_node *parse_interrupts(struct=
 device_node *np,
>         return of_irq_parse_one(np, index, &sup_args) ? NULL : sup_args.n=
p;
>  }
>
> +static struct device_node *parse_interrupt_map(struct device_node *np,
> +                                              const char *prop_name, int=
 index)
> +{
> +       struct device_node *tn, *ipar, *supnp =3D NULL;
> +       u32 addrcells, intcells, cells;
> +       const __be32 *imap, *imap_end;
> +       int i, imaplen;
> +
> +       if (!IS_ENABLED(CONFIG_OF_IRQ))
> +               return NULL;
> +
> +       if (strcmp(prop_name, "interrupt-map"))
> +               return NULL;
> +
> +       ipar =3D of_node_get(np);
> +       do {
> +               if (!of_property_read_u32(ipar, "#interrupt-cells", &intc=
ells))
> +                       break;
> +               tn =3D ipar;
> +               ipar =3D of_irq_find_parent(ipar);
> +               of_node_put(tn);
> +       } while (ipar);
> +       if (!ipar)
> +               return NULL;
> +       addrcells =3D of_bus_n_addr_cells(ipar);
> +       of_node_put(ipar);
> +
> +       imap =3D of_get_property(np, "interrupt-map", &imaplen);
> +       if (!imap || imaplen <=3D (addrcells + intcells))
> +               return NULL;
> +       imap_end =3D imap + imaplen;
> +
> +       for (i =3D 0; i <=3D index && imap < imap_end; i++) {
> +               if (supnp)
> +                       of_node_put(supnp);
> +
> +               imap +=3D addrcells;
> +               imap +=3D intcells;
> +
> +               supnp =3D of_find_node_by_phandle(be32_to_cpu(imap[0]));
> +               if (!supnp)
> +                       return NULL;
> +               imap +=3D 1;
> +
> +               if (of_property_read_u32(supnp, "#interrupt-cells", &cell=
s))
> +                       return NULL;
> +               imap +=3D cells;

This is wrong. Technically, you can have #address-cells too.

The bigger problem I have is this creates 2 sets of 'interrupt-map'
parsing code. Your version skips a lot of things like whether the
interrupt controller is available and there's the list of
'interrupt-map' abusers to think about.

Rob