Received-SPF: pass (google.com: domain of linux-kernel+bounces-142668-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Fri, 12 Apr 2024 13:51:45 +0100
From: Conor Dooley <conor.dooley@microchip.com>
To: Samuel Holland <samuel.holland@sifive.com>
CC: Conor Dooley <conor@kernel.org>, <linux-riscv@lists.infradead.org>, Paul
 Walmsley <paul.walmsley@sifive.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/4] cache: sifive_ccache: Auxiliary device support
Message-ID: <20240412-antacid-pretzel-c25d707f02cf@wendy>
References: <20240410232211.438277-1-samuel.holland@sifive.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="KR2qWsXqqA2l3aGz"
Content-Disposition: inline
In-Reply-To: <20240410232211.438277-1-samuel.holland@sifive.com>

--KR2qWsXqqA2l3aGz
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Apr 10, 2024 at 04:22:02PM -0700, Samuel Holland wrote:
> As of commit c90847bcbfb6 ("cache: sifive_ccache: Partially convert to a
> platform driver"), the cache subsystem binds a platform driver to the
> Composable Cache's DT node. This prevents the perf subsystem from doing
> the same for the new PMU driver[1]. To allow using both drivers at the
> same time without conflicts or module linkage dependencies, attach the
> PMU driver to the auxiliary device bus. While at it, prepare to use the
> auxiliary device bus for the EDAC driver as well, which significantly
> simplifies that driver. The actual EDAC driver conversion has to wait
> another development cycle to avoid dependencies between git trees.


I'm not really keen on the partial conversion, I'd like to see a
complete conversion where the ccache driver calls
"sifive_register_ccache_pmu()" and "sifive_register_ccache_edac()"
and has no part in creating the aux device itself, like Philipp and
Stephen asked me to do here for the clock/reset drivers on PolarFire SoC:
https://lore.kernel.org/all/20240409-shallow-voice-c84ed791bc7d@spud/

Thanks,
Conor.

--KR2qWsXqqA2l3aGz
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZhkuYQAKCRB4tDGHoIJi
0kVAAP9mbHOk0zEUzhsEt4WvIpaZeCF/FXZSFyZyWTiFCHFLzwD9GBDJql4D9mri
vjwiORtlGvkcH2+Idjuh0kEeqcGP3ws=
=KzTj
-----END PGP SIGNATURE-----

--KR2qWsXqqA2l3aGz--