Received-SPF: pass (google.com: domain of linux-kernel+bounces-142683-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Fri, 12 Apr 2024 09:05:42 -0400
From: Parker Newman <parker@finest.io>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jiri Slaby <jirislaby@kernel.org>, linux-kernel@vger.kernel.org,
 linux-serial@vger.kernel.org, Parker Newman <pnewman@connecttech.com>
Subject: Re: [PATCH v2 3/7] serial: exar: add support for config/set single
 MPIO
Message-ID: <20240412090542.3d86d9a9@SWDEV2.connecttech.local>
In-Reply-To: <2024041213-uncouple-justness-35fa@gregkh>
References: <cover.1712863999.git.pnewman@connecttech.com>
	<3e671b6c0d11a2d0c292947675ed087eaaa5445e.1712863999.git.pnewman@connecttech.com>
	<2024041213-uncouple-justness-35fa@gregkh>
Organization: Connect Tech Inc.
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:SPAAKHEVAv4=;uEzgGm3I/JbeLDXKSjUOXpxc1mm
 AvKl335kOAlJq5QFYh0tGjUOgX9gbHWWPdq4rJJQHoJFOrTgk4359Y3PaLL1bTXwPiRoJLEPm
 PaOb8kWCpzsyFrminAWmT1ivh0Rr+/XB7IO9vgk0Rtn/qorGuTAK3m47KA+8DDKdjpzniC97T
 QM6ejIsqdvc8JvPXnvoem/OFp+vgK/lGy2E5ruNVDn6ms+ci2x1TE9kFWZACz8iwQ1YwrzAml
 lXv7gkWxW6AO9lepGgA+ynKPnsIrgJzvSRxne7BLywUt4+4HSoYreEICJyZGAg36JVcTWz9NV
 eh4i3TWVXNzKXXhH61VNsVorLm6gy9RICq+rapvW9aznOnugUE/jgk5XFy+tFi+FuDzZoC+sk
 Wdwi6OZ3aF76z3gRPAP6L+LDJ2GHPgOvHXRbNx2m5X9YiAc5EKdqY7jUr1W+42XA9UkK5wmjG
 RkafAAWaeZFGqIezn2zJKJlA6qUYQGB0GiU5NUMH0Ut3vquLfnJzdH0L+/wxAHogss4SIBtGn
 jqwETgK2CdFLAx0EpZdicQr5+JdVkF4/HolsSymYNI6zp5Om4KGvEdwE2lI5gzaY9LcItZHO1
 L0yhk9lxxkxhFsnwqzYbNc4HlNd6stu1LiO7ryEqXamA2MI/CXPaqWYccbt2lEGiuAjmAuZc5
 UCy8VeYdNr0x/NCg/DPCfYINb4le8eefdRpC4D/1Zfxef4OOz/5CrRkwgE4hALvlaV8xN71rG
 ONTa85Zg6ALZjxTbQivw7eB6kDK4Eirw2pNRzruSfOZ+GW1drMjAqE=

On Fri, 12 Apr 2024 07:29:16 +0200
Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:

> On Thu, Apr 11, 2024 at 04:25:41PM -0400, parker@finest.io wrote:
> > +/**
> > + * exar_mpio_config() - Configure an EXar MPIO as input or output
> > + * @priv: Device's private structure
> > + * @mpio_num: MPIO number/offset to configure
> > + * @output: Configure as output if true, inout if false
> > + *
> > + * Configure a single MPIO as an input or output and disable trisate.
> > + * If configuring as output it is reccomended to set value with
> > + * exar_mpio_set prior to calling this function to ensure default sta=
te.
> > + *
> > + * Return: 0 on success, negative error code on failure
> > + */
> > +static int exar_mpio_config(struct exar8250 *priv,
> > +			unsigned int mpio_num, bool output)
>
> When you have a bool in a function, every time you read the code you
> have to go and figure out what that boolean means.
>
> Have 2 functions:
> 	exar_mpio_config_input()
> 	exar_mpio_config_output()
>
> and then have THEM call this function with the bool set or not.  That
> way when reading the code you know exactly what is happening.
>
> Same with other functions in this patch.  Naming is hard, make it easy
> please.

Good feedback thanks.

> thanks,
>
> greg k-h