Received-SPF: pass (google.com: domain of linux-kernel+bounces-142765-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Fri, 12 Apr 2024 09:50:54 -0400
From: Parker Newman <parker@finest.io>
To: Ilpo =?UTF-8?B?SsOkcnZpbmVu?= <ilpo.jarvinen@linux.intel.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Jiri Slaby
 <jirislaby@kernel.org>, LKML <linux-kernel@vger.kernel.org>, linux-serial
 <linux-serial@vger.kernel.org>, Parker Newman <pnewman@connecttech.com>
Subject: Re: [PATCH v2 4/7] serial: exar: add optional board_setup function
Message-ID: <20240412095054.3c80a8fe@SWDEV2.connecttech.local>
In-Reply-To: <385ccf17-199e-13cb-e003-8b583252cab8@linux.intel.com>
References: <cover.1712863999.git.pnewman@connecttech.com>
	<69677365f4c753cbe6b5c028f530db49e6712ab3.1712863999.git.pnewman@connecttech.com>
	<385ccf17-199e-13cb-e003-8b583252cab8@linux.intel.com>
Organization: Connect Tech Inc.
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:qSkTTMbABBw=;0QdzWu9DDxXkQicqxxJe2IN1CNc
 i3L1GkvLRAB5R+jMmPkJgchcSK4DQEoGOUOY77EqtS4mJjHpxrJh11ObeavVugW+b6nwCMGLn
 ckAfyylvlWwYLjN06B8pC5WNLG2S1WAr7+xDalgMP3DYt7T4arBikHxtsuk69Vx3f7xaJ2E/a
 7nun8nehcQz8HryC+IYJ9nP6DaIYOce2l0aLtGBc0kl+KRLGS4k6q815Q046n+8A8L8RUNEgp
 1gM/Wo08NttKto5IW0MuwmsJjyZSFuNPo8F8WniEo7xXzolydF4r4COvACp1a10puIGTqtWWf
 dWCVSbSA+rjKje/o0Qmirm3vKy1m2kNLUhR58ZJnh6SclSqJM7D0W67XZcSOcas/xFDXuwvYc
 U8GP6jRl3ebHJsJ0NwHiESWVEvz5qAPqpTnk/j7+LguhJFq1HixrykOWq62qycf//9cv/ujA3
 bGqsWUHwATik/dju0kYW65s+cjROXDRvrLBGSiSwcIWtzd6+TsqneUX4a5x4ttv4Y+KK3N7Tp
 vAEWax6msgfir+ZZ8HIwe/bumElHgCx/wFBea3+XS5n+yBQYcGJVNjlJS4G1n9xcAvE1VTgPz
 0IOVj9PDDAM1OH0OwTM7kX/39ouAUo4AHlBpuVylHfp+lWbOp41nxoPUpb4DQ9dOGqm4AOkCc
 17QAt+N9INEF46JmbNe12CuyemnH4xnwIK8rk7bIET3Moy+i0BYKCe2/6zBeJQT06iI1DetwV
 AkaLOPvo8yHc1wu8nbeHFT2WqHfj6QbrbcaaORaIfTNaFZzDJmz55w=

On Fri, 12 Apr 2024 13:08:58 +0300 (EEST)
Ilpo J=C3=A4rvinen <ilpo.jarvinen@linux.intel.com> wrote:

> On Thu, 11 Apr 2024, parker@finest.io wrote:
>=20
> > From: Parker Newman <pnewman@connecttech.com>
> >=20
> > Adds an optional "board_setup" function pointer to struct
> > exar8250_board. This gets called once during probe prior to setting up
> > the ports.
> >=20
> > Signed-off-by: Parker Newman <pnewman@connecttech.com>
> > ---
> >  drivers/tty/serial/8250/8250_exar.c | 23 +++++++++++++++++------
> >  1 file changed, 17 insertions(+), 6 deletions(-)
> >=20
> > diff --git a/drivers/tty/serial/8250/8250_exar.c b/drivers/tty/serial/8=
250/8250_exar.c
> > index 9915a99cb7c6..b30f3855652a 100644
> > --- a/drivers/tty/serial/8250/8250_exar.c
> > +++ b/drivers/tty/serial/8250/8250_exar.c
> > @@ -143,7 +143,7 @@
> >   *
> >   * MPIO		Port	Function
> >   * ----		----	--------
> > - * 0		2 	Mode bit 0
> > + * 0		2	Mode bit 0 =20
>=20
> Unrelated change.
>

Sorry, should have added a note about fixing this and the missing argument =
names
below due to checkpatch.pl. I will add a note in v3.=20
=20
> >   * 1		2	Mode bit 1
> >   * 2		2	Terminate bus
> >   * 3		-	<reserved>
> > @@ -179,22 +179,24 @@ struct exar8250_platform {
> >  	int (*rs485_config)(struct uart_port *port, struct ktermios *termios,
> >  			    struct serial_rs485 *rs485);
> >  	const struct serial_rs485 *rs485_supported;
> > -	int (*register_gpio)(struct pci_dev *, struct uart_8250_port *);
> > -	void (*unregister_gpio)(struct uart_8250_port *);
> > +	int (*register_gpio)(struct pci_dev *pcidev, struct uart_8250_port *p=
ort);
> > +	void (*unregister_gpio)(struct uart_8250_port *port);
> >  };
> >=20
> >  /**
> >   * struct exar8250_board - board information
> >   * @num_ports: number of serial ports
> >   * @reg_shift: describes UART register mapping in PCI memory
> > - * @setup: quirk run at ->probe() stage
> > + * @board_setup: quirk run once at ->probe() stage before setting up p=
orts
> > + * @setup: quirk run at ->probe() stage for each port
> >   * @exit: quirk run at ->remove() stage
> >   */
> >  struct exar8250_board {
> >  	unsigned int num_ports;
> >  	unsigned int reg_shift;
> > -	int	(*setup)(struct exar8250 *, struct pci_dev *,
> > -			 struct uart_8250_port *, int);
> > +	int     (*board_setup)(struct exar8250 *priv);
> > +	int	(*setup)(struct exar8250 *priv, struct pci_dev *pcidev,
> > +			 struct uart_8250_port *port, int idx);
> >  	void	(*exit)(struct pci_dev *pcidev);
> >  };
> >=20
> > @@ -966,6 +968,15 @@ exar_pci_probe(struct pci_dev *pcidev, const struc=
t pci_device_id *ent)
> >  	if (rc)
> >  		return rc;
> >=20
> > +	if (board->board_setup) {
> > +		rc =3D board->board_setup(priv); =20
>=20
> Could this be called board_init() as having both ->board_setup() and=20
> ->setup() is bit confusing. =20

sure, good idea.

> > +		if (rc) {
> > +			pci_err(pcidev,
> > +				"failed to setup serial board: %d\n", rc); =20
>=20
> pci_err() belongs to pci subsystem. Please use dev_err() or return=20
> dev_err_probe().

Did not know it was not allowed outside the PCI subsystem. I will switch=20
to dev_err() etc.=20

> > +			return rc;
> > +		}
> > +	}
> > +
> >  	for (i =3D 0; i < nr_ports && i < maxnr; i++) {
> >  		rc =3D board->setup(priv, pcidev, &uart, i);
> >  		if (rc) { =20
>=20
>=20

Thanks,
-Parker