Received-SPF: pass (google.com: domain of linux-kernel+bounces-142793-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
From: Zi Yan <ziy@nvidia.com>
To: Baolin Wang <baolin.wang@linux.alibaba.com>
Cc: akpm@linux-foundation.org, hannes@cmpxchg.org,
 mgorman@techsingularity.net, vbabka@suse.cz, 21cnbao@gmail.com,
 ryan.roberts@arm.com, david@redhat.com, ying.huang@intel.com,
 linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: page_alloc: allowing mTHP compaction to capture the
 freed page directly
Date: Fri, 12 Apr 2024 10:06:39 -0400
Message-ID: <A8A8D662-478C-4A42-AB5F-C840A2DF6B55@nvidia.com>
In-Reply-To: <8118a5d66a034736a48433beddaca60ed78577c4.1712892329.git.baolin.wang@linux.alibaba.com>
References: <8118a5d66a034736a48433beddaca60ed78577c4.1712892329.git.baolin.wang@linux.alibaba.com>
Content-Type: multipart/signed;
 boundary="=_MailMate_726461F8-174E-4D4B-ABC6-4D4C2DC4F38C_=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?NWus0DRVVZEGg/1SB732Iwh+IWbpLM3aGV3gicGeBIcJzs/oDHdoHXcx1xp3?=
 =?us-ascii?Q?wdTWs0+waYDzE/xy9LvoDZCrZlbUyukHOjY1rxivQkXMyyamKbqtjRWRFTI8?=
 =?us-ascii?Q?LhML6quGcrNk4c68yccPGt6p7ixOIdgRjFZVL4pkNnEYeTtBK6ye7azjuMwi?=
 =?us-ascii?Q?fL+iUakNZoeTinmClWaqvxCByNGx0iMa8Kegf+fiwhFQc0OKNkRapcrfLSr3?=
 =?us-ascii?Q?23mdXUmfieC9i4yLRf4XXZyXJUxb/t7w2YE4WjqekmWup+BNTiWeU0n1qp1B?=
 =?us-ascii?Q?UZ/p8b8azEZwP7XracXL/dze4nP1Q92s9GvG12E/rlf8DXXqg5r3CcvCH+g8?=
 =?us-ascii?Q?JvZ7AQvDa4IETh8jBKPK9+wt7LwZ+4vlxGoPoIejEjd6RxYJSRC3HzdXpZD8?=
 =?us-ascii?Q?bjDghyzC8pUXzIvtbsxpb6ub5UgTUtiwxSxf6xpgKZPjy0Wesf8+vMoV2qFF?=
 =?us-ascii?Q?FGTUQdccwE+uZo0ib6mIM4yAjS+ouyhHVFLaADuQgNcGAe+83Nj3JQQKaVyK?=
 =?us-ascii?Q?lWePXKBoVuVPfdGJeVeT9+mXHm6FAyIX7+8LByo1SRs/zHhLFtsTBac14oT1?=
 =?us-ascii?Q?+r6UMF/wQBdEUm5teevRSRZtyYg/VU2dCIQGnBDnRqRlBpZNStJ3CGiCF/x3?=
 =?us-ascii?Q?F41tLSKv6Iuu9nMUN+VwX0IIT1oLSvasbQV7aHh1pFZFXIMZ8UFzYiK7IFi7?=
 =?us-ascii?Q?56Ire2V2fu2szyMyQ1hYcRK8d059nkNK21BzmduGnJH9rPJI7wFZ7gOY85+r?=
 =?us-ascii?Q?/HOXd5DhxqTt/ezAWPPWOpAVG0wx1Pyw2YVPz85i2GF7h8k2gEG4mR9WH8kV?=
 =?us-ascii?Q?23Nnr0+/s7CbpekT5W5wr5AtwlVDPg0QuSgBn3FaIbmKjgaxUVJDeDI5MEyv?=
 =?us-ascii?Q?TJqkjJSYv7L+Lj67J1fzH+Xf3y34vSm5VG1shoU/Vjby1JfYGq8Guv7Eaj4/?=
 =?us-ascii?Q?qbZsObcsA4P9aoUxRjXvH4dJzPNQ4MrjH38Z6xScJAYY6Yy+eBR/I5N0i0hV?=
 =?us-ascii?Q?RNz0jLbBSi6aZZdZxVaBZZdyJnsT9SZD7wl49WhFD+6AAO5HDp0804YJwPg+?=
 =?us-ascii?Q?Ycf+rXqkD4WPrMa3ljzR8J1m8fLdivbM6S7ZKlTRyYcpn2rMhOnnkGKzl9+H?=
 =?us-ascii?Q?g5X8Kuo5u7TMA9sQb10sQq49C66nwt2kMxBtns5ZbNZ5NWLf0bGOYNRLJFNf?=
 =?us-ascii?Q?+3MOsx+brq8d9qsxNWbZBbzWpfBoqLO8JSjW94aK2ufvTFPhTTw9WZwlI62X?=
 =?us-ascii?Q?k07mLs3D0FqiuNdlvhFFS09SF42O75aDl5YUooJGMK0ODAkXMG43JyBTC1R5?=
 =?us-ascii?Q?n7RnZVTagT2yZ+WZXDrElsVUX2pVFRbVrQw1M8BkMQlwafsgI2++rLudJPce?=
 =?us-ascii?Q?UW/ynUeioFO7Tbnq+F8Lv4uYttBTFncqrgpCAHQB/in/T41gYnwtjZcwiUkv?=
 =?us-ascii?Q?ZkaydaxdXsqpaMTEfi14oBr/Gj6ha5dxoy7mk7Hk078tw4i+Y8Gpw6NTyNLd?=
 =?us-ascii?Q?BKUMxcO6uokD3VhcAy8QIB0HtVmrJrBAbwf4y/8QfuCg7fJ5RyeiJ+R0Shza?=
 =?us-ascii?Q?u04Aeb7YR2NIwO1auk4=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 822e9934-7b3c-4fd6-b7e0-08dc5af9c72e
X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB5744.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Apr 2024 14:06:41.6083
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +V9d6BjCUD4CNlRSDJ5N16KWsv8xo04MKiSSInfQNJs2TsMI6/XkOi7KgNUC6sKO
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6255

--=_MailMate_726461F8-174E-4D4B-ABC6-4D4C2DC4F38C_=
Content-Type: text/plain

On 11 Apr 2024, at 23:27, Baolin Wang wrote:

> Currently, compaction_capture() does not allow lower-order allocations to
> directly capture the movable free pages, even though lower-order allocations
> might also be requesting movable pages, that can lead to more compaction
> scanning. And, with the enablement of mTHP, such situations will become more
> common.
>
> Thus allowing lower-order (mTHP) allocations of movable page types directly
> capture the movable free pages can avoid unnecessary compaction scanning,
> meanwhile that won't pollute the movable pageblock. With testing 1M mTHP
> compaction, it can be seen that compaction scanning is significantly reduced.
>
>                                    mm-unstable       patched
> Ops Compaction pages isolated      116598741.00   120946702.00
> Ops Compaction migrate scanned    1764870054.00  1488621550.00
> Ops Compaction free scanned       7707879039.00  4986299318.00
> Ops Compact scan efficiency               22.90          29.85
> Ops Compaction cost                    73797.69       72933.48
>
> Signed-off-by: Baolin Wang <baolin.wang@linux.alibaba.com>
> ---
>  mm/page_alloc.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
LGTM. Thanks. Reviewed-by: Zi Yan <ziy@nvidia.com>

--
Best Regards,
Yan, Zi

--=_MailMate_726461F8-174E-4D4B-ABC6-4D4C2DC4F38C_=
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename=signature.asc
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQJDBAEBCgAtFiEE6rR4j8RuQ2XmaZol4n+egRQHKFQFAmYZP+8PHHppeUBudmlk
aWEuY29tAAoJEOJ/noEUByhUxQ8P/1GGS3zQeahbMOY8SPgF+oKzXED8R8CQxIx8
irb6pBv4rbj1gNkrLLYB7ucdxO42hbjX6ZI393dg/zib+N0cnov0GonwT3G3yRgz
knG3XDDL8e1d0D8eJbKQMvuNZQ5GpHz3O+dNhPLmG+Hf6AqUvwtW04vBzoq4/lYS
Qf0SUXzKeNLaTjYEcn2zw9FC7WDPuwz56K/ZM7W/i9ofj3ig2ehEe2RI8n9Ntos9
F+Zx3wC7Pb1n+fFCBlHALtr1ZtIcMOx65riohaRgHp5+8Ryke/lm7dcRxJMS9f52
icKpuKmemHPfYL7AfAsifR8fkjgUUSmHpZXu82b7LQKxN2KHA7Y3Q0fiQ+xWaGcA
aiEwZvwsa/sseoG0st7eIdVv0eiSJoK5HrXDgmKVM/IoIF1DAAqwiNYPMewsLFyD
8/ySoijSp9WINDk1AbgltDhQeherdESFj93J9j/y3sZpx79XjOz0c9okacw8vzpr
vuejmVhg8+85BpHQipW7L05xO+/pwDddaSfSIEqo1gXtwYr09t1q2uGUzhUaiB1T
nHFeNMuHheC8mrKTAXJYUHtxUjDsF8v2Gg7gGRWlD/xweO4LWECkdHheh190/00X
7DOtb8c11ONqJ+taLsi6g3FDvaDppZcitTUDiPN168YN4RkEbRgAz6Lkk1m5SZ1t
4XXu/rRl
=lZiT
-----END PGP SIGNATURE-----

--=_MailMate_726461F8-174E-4D4B-ABC6-4D4C2DC4F38C_=--