Received-SPF: pass (google.com: domain of linux-kernel+bounces-142804-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Fri, 12 Apr 2024 15:18:10 +0100
From: Matthew Wilcox <willy@infradead.org>
To: Haifeng Xu <haifeng.xu@shopee.com>
Cc: Vlastimil Babka <vbabka@suse.cz>,
	"Christoph Lameter (Ampere)" <cl@linux.com>, penberg@kernel.org,
	rientjes@google.com, iamjoonsoo.kim@lge.com,
	akpm@linux-foundation.org, roman.gushchin@linux.dev,
	42.hyeyoo@gmail.com, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] slub: Clear __GFP_COMP flag when allocating 0 order page
Message-ID: <ZhlCogEsWEjTbl8_@casper.infradead.org>
References: <20240411091832.608280-1-haifeng.xu@shopee.com>
 <5482360c-0a0b-e5f5-b88e-4a6ec4d43f7d@linux.com>
 <5d3c4a5e-0c27-4058-adf1-91e9602e5ccb@suse.cz>
 <ZhkmcNwOKktO3pxT@casper.infradead.org>
 <2031ea8c-29a0-4514-b042-7c0eabb4f443@shopee.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <2031ea8c-29a0-4514-b042-7c0eabb4f443@shopee.com>

On Fri, Apr 12, 2024 at 10:14:39PM +0800, Haifeng Xu wrote:
> diff --git a/mm/slub.c b/mm/slub.c
> index e7bf1a1a31a8..49a3ebefab86 100644
> --- a/mm/slub.c
> +++ b/mm/slub.c
> @@ -4461,9 +4461,7 @@ static int calculate_sizes(struct kmem_cache *s)
>         if ((int)order < 0)
>                 return 0;
> 
> -       s->allocflags = 0;
> -       if (order)
> -               s->allocflags |= __GFP_COMP;
> +       s->allocflags = __GFP_COMP;
> 
>         if (s->flags & SLAB_CACHE_DMA)
>                 s->allocflags |= GFP_DMA;

Resend this with a proper changelog and you can add:

Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org>