Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753767AbYAWVQv (ORCPT ); Wed, 23 Jan 2008 16:16:51 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752128AbYAWVQo (ORCPT ); Wed, 23 Jan 2008 16:16:44 -0500 Received: from fxip-0047f.externet.hu ([88.209.222.127]:42860 "EHLO pomaz-ex.szeredi.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751511AbYAWVQn (ORCPT ); Wed, 23 Jan 2008 16:16:43 -0500 To: torvalds@linux-foundation.org CC: miklos@szeredi.hu, a.p.zijlstra@chello.nl, salikhmetov@gmail.com, linux-mm@kvack.org, jakob@unthought.net, linux-kernel@vger.kernel.org, valdis.kletnieks@vt.edu, riel@redhat.com, ksm@42.dk, staubach@redhat.com, jesper.juhl@gmail.com, akpm@linux-foundation.org, protasnb@gmail.com, r.e.wolff@bitwizard.nl, hidave.darkstar@gmail.com, hch@infradead.org In-reply-to: (message from Linus Torvalds on Wed, 23 Jan 2008 13:00:57 -0800 (PST)) Subject: Re: [PATCH -v8 3/4] Enable the MS_ASYNC functionality in sys_msync() References: <12010440803930-git-send-email-salikhmetov@gmail.com> <1201044083504-git-send-email-salikhmetov@gmail.com> <1201110066.6341.65.camel@lappy> Message-Id: From: Miklos Szeredi Date: Wed, 23 Jan 2008 22:16:38 +0100 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 985 Lines: 24 > So it's not horribly hard, but it's kind of a separate issue right now. > And while the *generic* page-writeback is easy enough to fix, I worry > about low-level filesystems that have their own "writepages()" > implementation. They could easily get that wrong. Yeah, nasty. How about doing it in a separate pass, similarly to wait_on_page_writeback()? Just instead of waiting, clean the page tables for writeback pages. > So right now it seems that waiting for writeback to finish is the right > and safe thing to do (and even so, I'm not actually willing to commit my > suggested patch in 2.6.24, I think this needs more thinking about) Sure, I would have though all of this stuff is 2.6.25, but it's your kernel... :) Miklos -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/