Received-SPF: pass (google.com: domain of linux-kernel+bounces-142882-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Fri, 12 Apr 2024 17:25:26 +0300
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Kyle Meyer <kyle.meyer@hpe.com>
Cc: linux-kernel@vger.kernel.org, yury.norov@gmail.com,
	linux@rasmusvillemoes.dk, mingo@redhat.com, peterz@infradead.org,
	juri.lelli@redhat.com, vincent.guittot@linaro.org,
	dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com,
	mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com,
	russ.anderson@hpe.com, dimitri.sivanich@hpe.com, steve.wahl@hpe.com
Subject: Re: [PATCH v2 2/2] sched/topology: Optimize topology_span_sane()
Message-ID: <ZhlEVoW6FJC6uBVE@smile.fi.intel.com>
References: <20240410213311.511470-1-kyle.meyer@hpe.com>
 <20240410213311.511470-3-kyle.meyer@hpe.com>
 <Zhe9ttm9Ppv2wT3S@smile.fi.intel.com>
 <ZhhcPwFCgxDUhndo@DESKTOP-IR8JFSN.>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZhhcPwFCgxDUhndo@DESKTOP-IR8JFSN.>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo

On Thu, Apr 11, 2024 at 04:55:11PM -0500, Kyle Meyer wrote:
> On Thu, Apr 11, 2024 at 01:38:46PM +0300, Andy Shevchenko wrote:
> > On Wed, Apr 10, 2024 at 04:33:11PM -0500, Kyle Meyer wrote:

..

> > > Since topology_span_sane() is called inside of for_each_cpu(), each
> > > pervious CPU has already been compared against every other CPU. The
> > 
> > previous
> 
> Thank you for pointing that out. Should I send an updated version or can
> a maintainer correct my mistake?

Depends on the maintainer. I'm not the one here, don't expect answer from me.

> > > current CPU only needs to be compared against higher-numbered CPUs.

-- 
With Best Regards,
Andy Shevchenko