Received: by 2002:ab2:7041:0:b0:1f4:bcc8:f211 with SMTP id x1csp200275lql; Fri, 12 Apr 2024 07:57:42 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUTfp9O5CfJ76qLk5waMZ1X65SVDoOppCO+Pos6nMokRDLTr1ufWzfXL4dbLzG1tt3q/2YwBo59ku6ytoNCNCC5LvgHddCKiXroa3qWoQ== X-Google-Smtp-Source: AGHT+IEeVjh+bzssLWeV5084DEolTbmjEaumK7dVNViB/nKSeOilBTjAuwLCqHdGq9T8E90QGb1P X-Received: by 2002:a17:906:dfc9:b0:a52:30e1:289c with SMTP id jt9-20020a170906dfc900b00a5230e1289cmr1621733ejc.54.1712933862290; Fri, 12 Apr 2024 07:57:42 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712933862; cv=pass; d=google.com; s=arc-20160816; b=y2WRBpgfO7RXVn7pOS4nRWk6cv482MI5q8nUuKbDKoGGNoLv3sq/YpnqyQQUhu/KRU wLKEblgbu8hfT+Ckc59so68wCMVCvupVw17Q3z0dxasTJwJpdag8Hr1i9K6J5eL0jKJG eNo1XbgyJUFvBfJZi9Db+2Cj1W1IXHpiIw6pM4st74MyJIe1Pr/gEbJ6BlTyQI2LyLOp mtNE5IOY2x2eI+vMJfGoJWVSljWfniFCq07xdygCQiHtA4btnKQTKINuI1bYNsb4Algh SsUhNT9B7Z4xzZKyOagYa11vCnDMa/J5vKpdaqzzB6SgSnCZCApGpgA3JFI52ZyecTD7 m5aw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id; bh=lR9DulsgtLe40kTPL5gAeX9CB9uRNanwYbD9LoUF/uA=; fh=uGhgtCxujLeLq/y95rr8/2hiZ87GNGHuS+p0NMJVOlM=; b=qdD1XcRbAhg0OIsyhuxkOHtbxMZzP4B6TUwjbLEtmz+PCBMSRJ6u1ygLCMknlRiFB5 crL4D5Z8OhuS0/sfh1YLpWNSLAKoKFuSFgDnrp+n6pPkZnDsIQ7AUsHbkyY5x+bi2BJg WJOoAW0XQd7UeZkhgIZ5agKm6H5DLcavJ0opWcq9De9UTf+hXuV7EAY8j1vNTC2MaL9v IVCc325WdGz2ZnbkadjoiU/iKuJIi7BRYhTdptDzVv6wnQcKHHnaiXWdi9DiGc0UG7bw tuFHlTOHSDcFuL6g94ec4PBkG2j8F/Uu+MdsMu5eMfJi/xGg2lxnWEL0rYKpr38PaI9l NBHA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=enpas.org); spf=pass (google.com: domain of linux-kernel+bounces-142887-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-142887-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id l5-20020a170906414500b00a51c4b75c5csi1834209ejk.24.2024.04.12.07.57.42 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Apr 2024 07:57:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-142887-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=enpas.org); spf=pass (google.com: domain of linux-kernel+bounces-142887-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-142887-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 034271F21D42 for ; Fri, 12 Apr 2024 14:57:42 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E80FF1474C8; Fri, 12 Apr 2024 14:57:34 +0000 (UTC) Received: from mail.enpas.org (zhong.enpas.org [46.38.239.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5DE0D13DDAC; Fri, 12 Apr 2024 14:57:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=46.38.239.100 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712933854; cv=none; b=iYxGjAN+RWUMND/tvV98MbziMWCyFJ0pbWoKxAH+46kQiRzb3BJOB3gJITLLF6HWpU88zbCO5+Siv0p17CDt44Qwiz9W/tfveYbuOKWSb7j2PHW7ymLPQQV2xvbZtqJXlSIuk9xJXbKBrpMFStkQyvmdOo8BVhMRNzFHCTTdQpo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712933854; c=relaxed/simple; bh=UPCVu988L4eoHjepWEh/X8oPhqda5hmF+SLEW/y0I/s=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=mveUF7ATgT/x8itHBVkHETd73/OxdWu5qeVRPLz5noLZywnabLlZ8r/+CfR/+8pHwYSCEG51uU68SVUYIb2j9t9k0m81lD3NrXDsI57aWLvMNI+ItA14be7Y/VzuN8l1mNR12cR9wsxz3RM3d1K07KM1l81n5C57tfQ6h0DhGwY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=enpas.org; spf=pass smtp.mailfrom=enpas.org; arc=none smtp.client-ip=46.38.239.100 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=enpas.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=enpas.org Received: from [127.0.0.1] (localhost [127.0.0.1]) by mail.enpas.org (Postfix) with ESMTPSA id 7ABA2FFE4E; Fri, 12 Apr 2024 14:57:21 +0000 (UTC) Message-ID: <4e486902-9238-48db-b0b2-2abce4f3b812@enpas.org> Date: Fri, 12 Apr 2024 23:57:11 +0900 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [bug report] HID: playstation: DS4: Don't fail on calibration data request From: Max Staudt To: Dan Carpenter , Jiri Kosina Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Roderick Colenbrander References: <07848795-14e3-4020-9e60-e3221ff6ef80@enpas.org> Content-Language: en-US In-Reply-To: <07848795-14e3-4020-9e60-e3221ff6ef80@enpas.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 4/8/24 23:44, Max Staudt wrote: > On 4/8/24 09:41, Dan Carpenter wrote: >> Hello Max Staudt, >> >> Commit a48a7cd85f55 ("HID: playstation: DS4: Don't fail on >> calibration data request") from Feb 8, 2024 (linux-next), leads to >> the following Smatch static checker warning: >> >> [...] > > > Hi Dan, Jiri, > > Thanks for the report! > > > Jiri, if you prefer to do so, please feel free to stop/revert this patch for now, and I'll send a better one soon. > > [...] Jiri, Would you like me to send a patch on top of the existing one, or a completely fresh one? Max