Received-SPF: pass (google.com: domain of linux-kernel+bounces-142896-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
IronPort-PHdr: A9a23:Hf5XLxVeHwLfFvjeMYq0NU9aYHLV8K02AWYlg6HPw5pHdqClupP6M
 1OauLNmjUTCWsPQ7PcXw+bVsqW1QWUb+t7Bq3ENdpVQSgUIwdsbhQ0uAcOJSAX7IffmYjZ8H
 ZFqX15+9Hb9Ok9QS47lf1OHmnSp9nYJHwnncw98J+D7AInX2si+0eG//4LaSw5JnzG6J7h1K
 Ub+oQDYrMJDmYJ5Me5x0k7Tr3lFcPgeyWJzcFSUmRu9rsvl9594+CMWsPUkn/M=
IronPort-Data: A9a23:YV/QlKknxofThFelVJHLEjjo5gxHJkRdPkR7XQ2eYbSJt1+Wr1Gzt
 xIfXTiFM/vfamHwKd9+Ydzg908Cv5GHmoMySgRupSo9F1tH+JHPbTi7wugcHM8zwunrFh8PA
 xA2M4GYRCwMZiaB4E/rav649SUUOZigHtLUEPTDNj16WThqQSIgjQMLs+Mii+aEu/Dha++2k
 Y20+5K31GONgWYubjpIsvjb8nuDgdyr0N8mlg1mDRx0lAe2e0k9VPo3Oay3Jn3kdYhYdsbSq
 zHrlezREsvxpn/BO/v9+lrJWhRiro36YWBivkFrt52K2XCukMCdPpETb5LwYW8P49mAcksYJ
 N9l7fRcQi9xVkHAdXh0vxRwS0lD0aN6FLDvZkOdlcDK81X8a2bMwMt8MkYYLNIq07MiaY1O3
 aRwxDElZxSHgae9x6i2D7A0wM8iN8LseogYvxmMzxmAUq1gGs6FGv6MvIQCtNszrpgm8fL2a
 8MfaDdrcx3oaBxUMVBRA5U79AutriOiKmQB8gnO/MLb5UDL1j5r3YDUAOOKZ97afcp3mQHFn
 zPJqjGR7hYyb4HHlmHfrRpAnNTnmSL9RZJXF7Ci8PNuqEOcy3ZVCxAMU1a/5/6jhSaWX9NZN
 lxR9i0lhbY9+VbtTdTnWRC85nmesXY0X9tWDv1/6wuQy67YyxiWC3JCTTNbbtEi8sgsSlQXO
 kShltftA3lkt6eYDCvFsLyVtji1fyMSKAfueBPoUyNC2PvHrNgPlijXU/ZgLryLifPkRgPZl
 mXiQDcFu50fissC1qOe9F/Bgi6xqpWhcuLTzluPNo5Cxl0gDLNJd7CVBU7nAeGsxbt1o3GIu
 HwC3sOZ9u1LVMnLny2WS+JLF7asjxpkDNE+qQAyd3XC323xk5JGQWy2yGoiTKuOGp1bEQIFm
 GeJ5WtsCGZ7ZRNGl5NfbYOrENgNxqP9D9njXf28RoMRO8IhKlfdo3EyNRb4M4XRfK4EzPFX1
 XCzLJfEMJrmIfUPIMeeHr5CgeFxmkjSO0uJHcilp/hY7VZuTCXIEeheagTmghER56KfqwKd6
 MdEK8aP0F1eVua4ChQ7AqZNRW3m2UMTXMisw+QOL7brClM/RAkJVaSLqZt/INMNokigvrqSl
 p1LchUGmAOXaLyuAVjiV02Pn5uzAcYv8itjZXFE0JTB8yFLXLtDJZw3LvMfVbIm7+dki/VzS
 pE4lw+oWJyjlhyvF+whUKTA
IronPort-HdrOrdr: A9a23:o3PtoqmPevuMNAcPj7mtI2tOYvzpDfNeiWdD5ihNYBxZY6Wkfp
 +V7ZcmPE7P6Ar5BktApTnZAtjwfZq9z/JICYl4B8baYOF/0FHYbb2KnrGSswEIfBeOttK1tJ
 0QPZSWbeeAb2SS4vyKnTVQf+xQp+VvtZrY+9s2rE0dDj2CCZsQkzuRYzzzeiYZNWw2YabRVq
 DsmfavzADQAUj/G/7LfEXtKNKz3OEj+qiWByLuLiRXmjWmvHeD0pK/OR6e2RsVTjNIxpkf0U
 WtqWbEz5TmmcuWjjvH2UHuz7k+orbcI914a/Cku4wwEHHBmwyobINuV/mppzYuutyi714sjZ
 3lvwogF94b0QKVQkiF5T/WnyXw2jcn7HHvjXWCh2H4nMD/TDUmT+JcmINidAfD4UZIhqA57E
 sL5RPfi3NkN2KYoM3P3amRa/isrDvunZMWq59Us5WYa/pFVFYel/1DwKofKuZyIMuz0vFTLA
 ApNrCf2B6TGmnqMEwweQJUsYCRd2V2ERGcTkcYvMuJlzBQgXBi1kMdgNcSh3Ea6fsGOtR5Ds
 n/Q+9VfYt1P4UrRLM4AP1ETdq8C2TLTx6JOGWOIU7/HKVCP37WsZb47Lg8+envIfUzvdQPsY
 WEVEkduX85ekroB8HL1JpX8grVSGH4WTj20MlR65Vwp7W5Trv2Ni+ITkwojqKb0rkiK9yeX+
 z2NINdAvflI2erEYFV3xfmU50XMnUaWN19gKdyZ7tPmLODFmTHjJ2sTB+IHsuYLd8NYBKJPk
 c+
From: "Daniel Walker (danielwa)" <danielwa@cisco.com>
To: Nicolas Schier <nicolas@fjasle.eu>
CC: "Valerii Chernous -X (vchernou - GLOBALLOGIC INC at Cisco)"
	<vchernou@cisco.com>,
        Masahiro Yamada <masahiroy@kernel.org>,
        Nathan
 Chancellor <nathan@kernel.org>,
        "xe-linux-external(mailer list)"
	<xe-linux-external@cisco.com>,
        Jonathan Corbet <corbet@lwn.net>,
        "linux-kbuild@vger.kernel.org" <linux-kbuild@vger.kernel.org>,
        "linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] Add MO(mod objs) variable to process ext modules with
 subdirs
Thread-Topic: [PATCH v3] Add MO(mod objs) variable to process ext modules with
 subdirs
Thread-Index: AQHajDWPNw0w9AAG+kK+xjeBwf3pzA==
Date: Fri, 12 Apr 2024 15:01:25 +0000
Message-ID: <ZhlMwQhlxm7QVlPx@goliath>
References: <20240405165610.1537698-1-vchernou@cisco.com>
 <ZhfLrGrED-ls6i5V@buildd.core.avm.de> <ZhgdjpE+yl3IYSzl@goliath>
 <Zhg5L2xO_lT4lLwp@fjasle.eu> <ZhhNAQtV3StbaA4z@goliath>
 <ZhjV90qSCPSyWiBh@buildd.core.avm.de>
In-Reply-To: <ZhjV90qSCPSyWiBh@buildd.core.avm.de>
Accept-Language: en-GB, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?8ZMiDLqbyEiL1eeEkUYaOyF6zZBg4VTQAdmNsw70GAirvTkEGuxNVmWY0P9P?=
 =?us-ascii?Q?axpy5VpsGUoET3WYx2gnXL3MBpNzzZ7c7vRGQ0pZpF/D5va14Pl1XKgJP84y?=
 =?us-ascii?Q?D5894wlPeFRRAbDuIuSZOivN8azhW9KJ8zIkGxwWZjM22RkzqQInBMt9YQ7Z?=
 =?us-ascii?Q?uukJwmilFL6IprSlX0bX/9MUS5F2kyx8eCNgDHGj+5GMijMmvG6VRVYGBfYl?=
 =?us-ascii?Q?OCgKgx5ZRPJP6H7nv8hHvdEVLs3ABhwV3ZcysQFUgFzjVmEziDzD3wqWIUbt?=
 =?us-ascii?Q?31AD3ltuQwffCrdHCI6shJSm3NtNgzSo3EI6f3utPcMylItKzwWyNp0jwil1?=
 =?us-ascii?Q?tS5EjhOvdwtvm6UkzlkN06WLCcnmRyQujkhoO9mxW5LybmM6GFpHyOH+QG6l?=
 =?us-ascii?Q?Bg5sWabUZltSyHtpcYDs9Ggd47I/9xMDcVUFb9j2U4aMgm5WdHR6AQ/NoFWW?=
 =?us-ascii?Q?HnOK4PkaTiLyqnj5IwpLqIgXnCMWUQGa7WAAUahFcZI90R/S4EBCFCytDTs2?=
 =?us-ascii?Q?EaYKu/LJeRzFVOg/Ai7PoLwCkdeDNjxFD/l01/G5Fy3J1MIN5CO9a4jT/FD5?=
 =?us-ascii?Q?bXZJfaCnsoTohz9jW4/s5ptAtyYSq0kVvDy9T7k4NouRveoI1Cl7pVvjP44Z?=
 =?us-ascii?Q?BnSwk1iwP7bHzeIjwWCkTWqF77cEWTWssiEtLW/iWKa5GiqDKHut50oAPVgd?=
 =?us-ascii?Q?90cbxeduKrfzeqiThV+eWFkEre/8SqcDXsA6WO7m4+mwbJ/mMAd554njmkkF?=
 =?us-ascii?Q?Sp/MrFCOiFvgFqgwnxXzmU4gHU2Ih6/W8xTLWdcBWJxKhTxNsohOtHM7a4Ai?=
 =?us-ascii?Q?IsiyX2mhci9VGyO+Mn7kxpTvJ91fXJBu7AXH8WKlIoR4DOgji6YOLR9ksXKt?=
 =?us-ascii?Q?hIdHY3EtMKhw9tvDTZiyYyxFG3m+/6vgZVbB+0+W+tTAD3zWYUzDoRHIzn9N?=
 =?us-ascii?Q?T010cbIBDEKDBX832WDEuZHj1Qq69Ehm6cOOmv4vWAjduFhQRf/MCeZyv4sA?=
 =?us-ascii?Q?Ykg7jpOJZPjq3uk8ttqlACcWC/pXPFt9YxE5PpIm0VnDht9k74cI8nUJ/vv7?=
 =?us-ascii?Q?v4eKLvNRRy/IvHf6AW/hHCT3lz9A+0jPDd9lDkEHJ9sqg/mhY3Gn/TDn8tua?=
 =?us-ascii?Q?6x8f0PCJYM73uXcRpPygtTxGTLWUumzN1UTdaMfJIPbcZPdGSPU1F+mliXsp?=
 =?us-ascii?Q?t/ojPZZb+ydiBRjFXNmsgQSzZmvFFHU13wA9x2uDhWQKHGY7ugpgxOYoYanZ?=
 =?us-ascii?Q?YzT5pkzODIHfMMcj/QXPldkuI5oJurn3cDHVPVRNxopXfGYcpxhjPOSQoDOC?=
 =?us-ascii?Q?rMUnUMcuQv8IAcoAeUmKnLlMcp6oXgn5Em9bnCYkeYJhuq7eSDt2r79OOkxG?=
 =?us-ascii?Q?mmnuFcFm10/wnWR7QEYNwIMqrIIzyuWumjrsym9BrSrGg87yg0+njv3L5XDx?=
 =?us-ascii?Q?Gsxo4ZaYYmKMnkHBzHr7aZBxHsKAf7DVlHW0qPgUpY+EGQK7pON8H0qb0n2/?=
 =?us-ascii?Q?t8lHACO/6gmPo01aQQ0PIDUpLfSxJ7NFQxv+fZqWVKhwns7sS+Qu2SLLuB2J?=
 =?us-ascii?Q?HKadIJ6+Ia78FRjS8saaFEYZ47xjglIkFbAtCB2h?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <0802039DF443144FA304F1ACFDA4C645@namprd11.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: cisco.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR11MB5790.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 583d829c-3808-49e0-fdbb-08dc5b016c73
X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Apr 2024 15:01:25.1831
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 5ae1af62-9505-4097-a69a-c1553ef7840e
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: OSi3aK6wjRD5oEPP1/SOaU+hxOrRyFn3T8JlZVxk7V0p5FCriNdHZ6EO0f+ot/xDyTuE/kmR17VHudmNlhN1VA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR11MB5987
X-Outbound-SMTP-Client: 173.37.147.253, alln-opgw-5.cisco.com
X-Outbound-Node: alln-core-10.cisco.com

On Fri, Apr 12, 2024 at 08:34:31AM +0200, Nicolas Schier wrote:
> On Thu, Apr 11, 2024 at 08:50:10PM +0000, Daniel Walker (danielwa) wrote:
> > On Thu, Apr 11, 2024 at 09:25:35PM +0200, Nicolas Schier wrote:
> > > On Thu, Apr 11, 2024 at 05:27:42PM +0000 Daniel Walker (danielwa) wro=
te:
> [...]
> > > > If that were true we would not have driver/uio/ for example. It see=
ms like
> > > > Cisco and NVM should work together produce a solution.
> > > >=20
> > > > You could run into this issue even with entirely in tree modules. F=
or example,
> > > > we may have a v6.6 kernel but we need some modules from v5.15 for s=
ome incompatibility
> > > > reason in v6.6. Then we may build the v5.15 modules as out of tree =
modules
> > > > against the v6.6 kernel.
> > =20
> > All problems should be fixed or worked around. One bit of code maybe is=
n't
> > the best choice or maybe another is, but not fixing or working around t=
he
> > problem is not really an option.
>=20
> Let me sum up: It is possible to build out-of-tree kmods with subdirs
> in their source tree.
> The patch attempts to put support for _out-of-source builds_ of
> out-of-tree kmods with subdirs into kbuild itself.
>=20
> If you really out-of-source builds for your complex out-of-tree kmods,
> than, as a "work-around", you can simply put those 'src' override lines
> into your oot-Kbuild files.  But you probably know that already, right?

I tried "make src=3D..." and Valerii also tried it.  I think that's what yo=
ur referring
to. There must have been a defect added which prevents that from working. I=
t
has some sort of recursion issue. It seems this method was not "official" a=
nd
only work by accident.=20


> > > If your in-tree module in question does compile and run properly in v=
5.15 and
> > > in v6.6: why don't you just compile it in-tree in v6.6?  Which driver=
/module do
> > > you refer to?
> >=20
> > I believe it was this driver drivers/crypto/marvell/octeontx2 . I don't=
 recall
> > every aspect of the issues but it has to do with what Marvell supported=
 in their
> > SDK and the exact hardware we were using and the bootloader we had on t=
he
> > product.
> >=20
> > > > You also have just normal developers making kernel modules which al=
ways start as
> > > > out of tree modules before they are upstreamed. Those modules could=
 be any level
> > > > of complexity.
> > >=20
> > > I do not agree, but there is no need to convince me as I am not in th=
e position
> > > to decide between acceptance or denial.  I just thought it might be f=
air to
> > > warn that I do not expect acceptance.
> >=20
> > I think it's incorrect, unhealthy even, to look at it that way. If your=
 using
> > Linux to make a product and you have an issue, it should be consider as=
 a real
> > issue. Not something maintainer can just discard. Unless the maintainer=
 has
> > a suggestion to do what is needed or different code to do it.
> >=20
> > Daniel
>=20
> Daniel,
>=20
> I am confused about the outcome from your argumentation that you might
> expect.  And I think, I as a spare-time reviewer (not maintainer), am
> not the one you want to argue with.

I don't care if your a maintainer or not.

> If you have a concrete technical issue or bug, please explain it
> concretely to linux-kbuild and we will probably find someone trying to
> help you.  If you want me to hide critical thoughts when reviewing
> patches under your pillow, then please tell me so.

I don't think it's critical thinking to effectively tell someone to stop
submitting code.

Daniel=