Received-SPF: pass (google.com: domain of linux-kernel+bounces-142944-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
CC: Stephan Gerhold <stephan@gerhold.net>,
        "stable@vger.kernel.org"
	<stable@vger.kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Konrad
 Dybcio <konrad.dybcio@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley
	<conor+dt@kernel.org>,
        Bhupesh Sharma <bhupesh.sharma@linaro.org>,
        "linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] arm64: dts: qcom: sa8155p-adp: fix SDHC2 configuration
Thread-Topic: [PATCH v2] arm64: dts: qcom: sa8155p-adp: fix SDHC2
 configuration
Thread-Index: AQHajAc1RfBxI3QF4U667KfqA0a9CLFi93IAgAHIhYA=
Date: Fri, 12 Apr 2024 15:24:06 +0000
Message-ID: <87v84m4nah.fsf@epam.com>
References: <20240410134022.732767-1-volodymyr_babchuk@epam.com>
 <20240411115506.1170360-1-volodymyr_babchuk@epam.com>
 <769a6a2a-2f38-42de-b3ce-8585b8b0a758@linaro.org>
In-Reply-To: <769a6a2a-2f38-42de-b3ce-8585b8b0a758@linaro.org>
Accept-Language: en-US
Content-Language: en-US
user-agent: mu4e 1.10.7; emacs 29.3
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?iso-8859-1?Q?52j2z567CxGb22u3dTlaQcA3WfB1OIor8pEw1NN6Z1rdu8GTy88kYAWydE?=
 =?iso-8859-1?Q?9ZeMRVcwwpgezXvR+2Ew5Itf12PwNGivrXKF1rjW+q74WtE/6DdYtUxAZy?=
 =?iso-8859-1?Q?GfmqtGoOvcN+cAu816csu8zFTtoBdK8SRdNc5QdGm7xXwWvfKj5EX3WU1o?=
 =?iso-8859-1?Q?g8BragwY9tAJx4agNDW0As8vS+Ijclq5Pqt61RzSykEUoshwRpgv1uQ0WA?=
 =?iso-8859-1?Q?2isyizPnUNINu+FkjOzG1DqyuvY8IzDl+WGur0vZdnZbM8YZExrruG5y0B?=
 =?iso-8859-1?Q?EimqZcVnYtJyP+5DShOETvkWiWs4U0k8U6i78u888hKt8CDupEBjxXcsJr?=
 =?iso-8859-1?Q?UhtNtFSvAKIdv9992iL59r1HrzrnDGMDYyyrIDv/xVdDhdyA6dE6TtMN4q?=
 =?iso-8859-1?Q?gDBnkbCs+3L4u7I1+J7KvMQsnMNB7lOnzAEa3NHeFRDNArCxdv+SYYEeSx?=
 =?iso-8859-1?Q?zEBA22MBqfJuQhjvvrn3j8Pl0wDwJLqugIohX1xdV+AclM/xlPwIaHul0Z?=
 =?iso-8859-1?Q?mWcGAt5YH5CML5sJjcpcc4DdRxdl95uLzZHflbCP+YhLgkPA8kqEGz+EQC?=
 =?iso-8859-1?Q?s5eHXnXrpF5EwfVi8Xy5maLVvP67nmiB3Xi5MV+ggb2yVw8GbTaBge9i9F?=
 =?iso-8859-1?Q?72YX0LtBEfxAgF7izgrRCZC3P9mm3XiJvlKstpUaOuEUbc9eicUqlO/oXJ?=
 =?iso-8859-1?Q?b5qcK8t83AvGpLsSffdKmxmae9OKu3/qgRp//nknjXhyh7YIO4iR3K8RT9?=
 =?iso-8859-1?Q?XlQ5F/NADxR0xNb17eKrkYk5howpTAkN58LRDWtYmmSLYvcUiBP1RhHeLS?=
 =?iso-8859-1?Q?4VemYdDlI/NeFWgQdGIcFyzb4Qm0rIHTCVqyO/rewirxSm+WoiOHv1Q2QZ?=
 =?iso-8859-1?Q?nPz9UQ8QyUv/hcrKtnBoEamEdjAowXJlnOVjURlVWxRm3wqRqvOz5PbzIW?=
 =?iso-8859-1?Q?vJ33vDe+PUNcZivWbWmTxba9QpK7eVUoQhN1Iafp7ndkHKP22Fo2PyEwVK?=
 =?iso-8859-1?Q?nIHyEr0J1rFG/NIehfB9Ju+RZ3moEM6aU/2linJ4MZE6yBT9xk0rESfOqT?=
 =?iso-8859-1?Q?apwyYTUxcif1C0QZkTgNMP6YwKGeQOcITEoYVOC/paBKZiH2Lymmn8bgAX?=
 =?iso-8859-1?Q?ocx0MGxc4aTUARKPeiPnaDywzAj+ajT1zh7Ep2z8BKpmhPVFqh9Lrka4h4?=
 =?iso-8859-1?Q?dB7oggvuKtD/MXxdW/OLkQlN+AUNTUau9PVMhloEZ9TXZTKA5+zXVdDUPT?=
 =?iso-8859-1?Q?UYMfB84irGFzEMnqCxJRJIQINwNQ7hpcxSibpWvCLCjb98Pga28Nj1aO0V?=
 =?iso-8859-1?Q?GA8mm1ywyi6WZwW7dnRC9Vy8P1bCg4QaGE2K07Kx8niKfcCjNkv8oGMuAO?=
 =?iso-8859-1?Q?A8LXxxzUkEbFYpE/O0HGHfzORdoIReEfwRoj7QVUvwSREu+LM36t7USgTA?=
 =?iso-8859-1?Q?u2BYUIOemiN2UYeZ06QqneKtNZ+XI1z+qWUePUbibhmn+kmxnm0CitfvME?=
 =?iso-8859-1?Q?25oXQmvQDEgsKkDtqotNly60nePgmFFL4rJWGgzDPsTs0E+YEujx8hE/HM?=
 =?iso-8859-1?Q?QDYEWL6z7cdU01n7lY5/I66S2WLjXSJrO1qc0ssdiQon6QUjBj2Hr1N48T?=
 =?iso-8859-1?Q?RJTzNRqQHzy9KXk7VI12vl5FGii/RN+XAHdZMM+Nlj8sKogam7EzIUrQ?=
 =?iso-8859-1?Q?=3D=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: epam.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: GV1PR03MB10456.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1a5d358d-e6c4-4572-669a-08dc5b049813
X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Apr 2024 15:24:06.9059
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: gM1xO7N/i8ShhWLrCTaZoRrNcfMW7tezolzy90dLHVtjlSZDFh9FAMllIAeTwb0DS+A9//Z6146dns39tze9DY3g0DCpXunTSP1wsRNS4yA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR03MB8392
X-Proofpoint-ORIG-GUID: R3vKfpgVjFqxYQpYclXxFUhEaR_SEmb_
X-Proofpoint-GUID: R3vKfpgVjFqxYQpYclXxFUhEaR_SEmb_
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-04-12_11,2024-04-09_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0
 impostorscore=0 mlxscore=0 lowpriorityscore=0 clxscore=1011 bulkscore=0
 suspectscore=0 spamscore=0 phishscore=0 mlxlogscore=999 priorityscore=1501
 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.19.0-2404010003 definitions=main-2404120110


Hi Krzysztof,

Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> writes:

> On 11/04/2024 13:55, Volodymyr Babchuk wrote:
>> There are multiple issues with SDHC2 configuration for SA8155P-ADP,
>> which prevent use of SDHC2 and causes issues with ethernet:
>>=20
>> - Card Detect pin for SHDC2 on SA8155P-ADP is connected to gpio4 of
>>   PMM8155AU_1, not to SoC itself. SoC's gpio4 is used for DWMAC
>>   TX. If sdhc driver probes after dwmac driver, it reconfigures
>>   gpio4 and this breaks Ethernet MAC.
>>=20
>> - pinctrl configuration mentions gpio96 as CD pin. It seems it was
>>   copied from some SM8150 example, because as mentioned above,
>>   correct CD pin is gpio4 on PMM8155AU_1.
>>=20
>> - L13C voltage regulator limits minimal voltage to 2.504V, which
>>   prevents use 1.8V to power SD card, which in turns does not allow
>>   card to work in UHS mode.
>
> That's not really related. One issue, one commit.
>
>>=20
>> This patch fixes all the mentioned issues.
>>=20
>> Fixes: 0deb2624e2d0 ("arm64: dts: qcom: sa8155p-adp: Add support for uSD=
 card")
>> Cc: stable@vger.kernel.org
>> Signed-off-by: Volodymyr Babchuk <volodymyr_babchuk@epam.com>
>>=20
>> ---
>>=20
>> In v2:
>>  - Added "Fixes:" tag
>>  - CCed stable ML
>>  - Fixed pinctrl configuration
>>  - Extended voltage range for L13C voltage regulator
>> ---
>>  arch/arm64/boot/dts/qcom/sa8155p-adp.dts | 32 +++++++++++-------------
>>  1 file changed, 14 insertions(+), 18 deletions(-)
>>=20
>> diff --git a/arch/arm64/boot/dts/qcom/sa8155p-adp.dts b/arch/arm64/boot/=
dts/qcom/sa8155p-adp.dts
>> index 5e4287f8c8cd1..b9d56bda96759 100644
>> --- a/arch/arm64/boot/dts/qcom/sa8155p-adp.dts
>> +++ b/arch/arm64/boot/dts/qcom/sa8155p-adp.dts
>> @@ -283,7 +283,7 @@ vreg_l12c_1p808: ldo12 {
>> =20
>>  		vreg_l13c_2p96: ldo13 {
>>  			regulator-name =3D "vreg_l13c_2p96";
>> -			regulator-min-microvolt =3D <2504000>;
>> +			regulator-min-microvolt =3D <1800000>;
>>  			regulator-max-microvolt =3D <2960000>;
>>  			regulator-initial-mode =3D <RPMH_REGULATOR_MODE_HPM>;
>>  		};
>> @@ -384,10 +384,10 @@ &remoteproc_cdsp {
>>  &sdhc_2 {
>>  	status =3D "okay";
>> =20
>> -	cd-gpios =3D <&tlmm 4 GPIO_ACTIVE_LOW>;
>> +	cd-gpios =3D <&pmm8155au_1_gpios 4 GPIO_ACTIVE_LOW>;
>>  	pinctrl-names =3D "default", "sleep";
>> -	pinctrl-0 =3D <&sdc2_on>;
>> -	pinctrl-1 =3D <&sdc2_off>;
>> +	pinctrl-0 =3D <&sdc2_on &pmm8155au_1_sdc2_cd>;
>> +	pinctrl-1 =3D <&sdc2_off &pmm8155au_1_sdc2_cd>;
>>  	vqmmc-supply =3D <&vreg_l13c_2p96>; /* IO line power */
>>  	vmmc-supply =3D <&vreg_l17a_2p96>;  /* Card power line */
>>  	bus-width =3D <4>;
>> @@ -505,13 +505,6 @@ data-pins {
>>  			bias-pull-up;		/* pull up */
>>  			drive-strength =3D <16>;	/* 16 MA */
>>  		};
>> -
>> -		sd-cd-pins {
>> -			pins =3D "gpio96";
>> -			function =3D "gpio";
>> -			bias-pull-up;		/* pull up */
>> -			drive-strength =3D <2>;	/* 2 MA */
>> -		};
>>  	};
>> =20
>>  	sdc2_off: sdc2-off-state {
>> @@ -532,13 +525,6 @@ data-pins {
>>  			bias-pull-up;		/* pull up */
>>  			drive-strength =3D <2>;	/* 2 MA */
>>  		};
>> -
>> -		sd-cd-pins {
>> -			pins =3D "gpio96";
>> -			function =3D "gpio";
>> -			bias-pull-up;		/* pull up */
>> -			drive-strength =3D <2>;	/* 2 MA */
>> -		};
>>  	};
>> =20
>>  	usb2phy_ac_en1_default: usb2phy-ac-en1-default-state {
>> @@ -604,3 +590,13 @@ phy-reset-pins {
>>  		};
>>  	};
>>  };
>> +
>> +&pmm8155au_1_gpios {
>> +	pmm8155au_1_sdc2_cd: pmm8155au_1-sdc2-cd {
>
> No underscores in node names.

Fill fix.

> Please also follow tlmm style of naming nodes.

Just to be on the same page, will "pmm8155au_1_sdc2_cd: sdc2-cd-pins" be fi=
ne?

> Also does not look like node is placed in alphabetical place. Where did
> you put it?

I can't say that the file is sorted in the first place:

# grep "^&" arch/arm64/boot/dts/qcom/sa8155p-adp.dts
&apps_rsc {
&ethernet {
&qupv3_id_1 {
&remoteproc_adsp {
&remoteproc_cdsp {
&sdhc_2 {
&uart2 {
&uart9 {
&ufs_mem_hc {
&ufs_mem_phy {
&usb_1 {
&usb_1_dwc3 {
&usb_1_hsphy {
&usb_1_qmpphy {
&usb_2 {
&usb_2_dwc3 {
&usb_2_hsphy {
&usb_2_qmpphy {
&pcie0 {
&pcie0_phy {
&pcie1_phy {
&tlmm {
&pmm8155au_1_gpios {


So, I can put after &pci1 to have it grouped with other entries that
start with p*, or I can put right after &ethernet to make it appear in
alphabetical order. It is your call.

--=20
WBR, Volodymyr=