Received: by 2002:ab2:7041:0:b0:1f4:bcc8:f211 with SMTP id x1csp229384lql; Fri, 12 Apr 2024 08:41:38 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCXMU7XeGM3F4egnMdlETd/rFUr+5Y7PHM6NS4+jy3kSewlCF0Gyf/k1k3PctSanJX/wsnJ9L5UXMhbvvdjXMAU/HMco6Uj/7ELgB9UT5Q== X-Google-Smtp-Source: AGHT+IFbwHMyEchi/nAe2iv+MzaPDdRKCV26PjyL0vzKpYvdDc3Kk0LGwu4rqP3/ufXURhhRxROJ X-Received: by 2002:a50:8e52:0:b0:56e:2d8f:ff80 with SMTP id 18-20020a508e52000000b0056e2d8fff80mr2510018edx.5.1712936498041; Fri, 12 Apr 2024 08:41:38 -0700 (PDT) Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id u6-20020a509506000000b0056c3ecbf603si1777112eda.136.2024.04.12.08.41.37 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Apr 2024 08:41:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-142957-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@intel.com header.s=Intel header.b=RQTzucsK; arc=fail (body hash mismatch); spf=pass (google.com: domain of linux-kernel+bounces-142957-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-142957-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id EAB1B1F245A2 for ; Fri, 12 Apr 2024 15:32:48 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 52782148305; Fri, 12 Apr 2024 15:32:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=intel.com header.i=@intel.com header.b="RQTzucsK" Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5393F5914E; Fri, 12 Apr 2024 15:32:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.9 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712935963; cv=none; b=VOS5mlO32hobdswFKlWcNIMOPtyJmq513/DAHCKiRW3kdUu7hXt2M8gTLBGjuTVDz3WM2WH4bMRUyJoEIvZUa6Ort1neO4UAwWrrXDfB9WSd0k0ghn7SO2hVNtJQQOJee/GfmMmPp7XaBucfIGdTrrfXwXl39nHs/KcxvGLnRtk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712935963; c=relaxed/simple; bh=YcGVppXDTZpBYsq3LZQl0x3tHjY0EsDlBXQF4JKc2kc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=kuyLgd2RWS26quuH+GgWqzl7+s/kcJVY14K9zolc6r3i9aAFuwVPH5mYUS9zN8H/M72M4Z91Neyeug1XGD8mCRogCXECEDW2+oAH0C5oA1znuQ6n+D9MAhtzaMnZVMwYvzZm9lxtMUnomgSENBuw3hH8+0z3J5cQW5eMM3m8Slw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=RQTzucsK; arc=none smtp.client-ip=198.175.65.9 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1712935963; x=1744471963; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=YcGVppXDTZpBYsq3LZQl0x3tHjY0EsDlBXQF4JKc2kc=; b=RQTzucsKX3lYIBDM375wr2Up04GfAjKxuUExlcVegO/xo3viWpc+XmIG glqfjZu6vCVFYF+ijwFkbyldTdcrnYQ5D8X65Ue7CZAYX1wWCkeelER3c waiVYOJ1MTwRiW8xBwb6AmDgfqxIN95eSFnUF/D5Ckg+kDIQucI80m1PJ pG+h4rIP2Ls/kQ7AoUk6xPrDm5g3bygfJbGTx9w6bEbANDACtm00kuNZZ u7lxIl/Uc/oMlfUt8Gy6XA5sQQeFPee3C6iC1RYuKRF1XU3dpFqDzPj/x 94a8oyL8W3j1ofHAaAnvXrajwJtPfSro8WIKc6UjtltkhwrzJAif9hJVs w==; X-CSE-ConnectionGUID: FTjBeGz5QhWWrYm9wimVcg== X-CSE-MsgGUID: czIS+8+qTlu2MzrZDz23/w== X-IronPort-AV: E=McAfee;i="6600,9927,11042"; a="30875189" X-IronPort-AV: E=Sophos;i="6.07,196,1708416000"; d="scan'208";a="30875189" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Apr 2024 08:32:42 -0700 X-CSE-ConnectionGUID: 0zUC7aeoQt+hygbpFCOnvQ== X-CSE-MsgGUID: akgacc3/RCez8p0U9pOJZw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,196,1708416000"; d="scan'208";a="21838477" Received: from smile.fi.intel.com ([10.237.72.54]) by orviesa008.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Apr 2024 08:32:40 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1rvItJ-00000003goC-3FW9; Fri, 12 Apr 2024 18:32:37 +0300 Date: Fri, 12 Apr 2024 18:32:37 +0300 From: Andy Shevchenko To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: Raag Jadav , jarkko.nikula@linux.intel.com, mika.westerberg@linux.intel.com, linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1] pwm: dwc: allow suspend/resume for 16 channels Message-ID: References: <20240412060812.20412-1-raag.jadav@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Fri, Apr 12, 2024 at 01:12:48PM +0200, Uwe Kleine-K?nig wrote: > On Fri, Apr 12, 2024 at 11:38:12AM +0530, Raag Jadav wrote: .. > > +struct dwc_pwm_drvdata { > > + const struct dwc_pwm_info *info; > > + void __iomem *io_base; > > .io_base is only used during init time and so doesn't need to be tracked > in driver data. It's me who asked for this specific change and I think it's still beneficial as it allows to simplify the code. -- With Best Regards, Andy Shevchenko