Received-SPF: pass (google.com: domain of linux-kernel+bounces-142969-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Fri, 12 Apr 2024 11:39:43 -0400
From: Parker Newman <parker@finest.io>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Ilpo =?UTF-8?B?SsOkcnZpbmVu?= <ilpo.jarvinen@linux.intel.com>, Jiri
 Slaby <jirislaby@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
 linux-serial <linux-serial@vger.kernel.org>, Parker Newman
 <pnewman@connecttech.com>
Subject: Re: [PATCH v2 6/7] serial: exar: add CTI board and port setup
 functions
Message-ID: <20240412113943.7a2bf0c6@SWDEV2.connecttech.local>
In-Reply-To: <2024041248-enjoyable-barterer-4f01@gregkh>
References: <cover.1712863999.git.pnewman@connecttech.com>
	<ca94454e54504c1621f17f5e3933cad299f61344.1712863999.git.pnewman@connecttech.com>
	<c73b4fc3-be87-6a6d-408e-634ba915f28e@linux.intel.com>
	<20240412111926.5b4c9953@SWDEV2.connecttech.local>
	<2024041248-enjoyable-barterer-4f01@gregkh>
Organization: Connect Tech Inc.
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:+5fXMDEAca8=;0mzk6sFLx1VxltU3hfs50br1UTq
 bQzPeW2Lwsk+HGSQPDlrDmkVaZD0eB6cm9Io1OsNOUdcnuwvAbN2fvs1vh1gwtjRMr09wDhRb
 WbyuBzxXK5IgrUm/iHEBZLU3/x8j4muv1cHIa00Fks7gnN0d8tv2D5bGR3woyO+135u3hYYkA
 H+p6/poG/HpdKEBUZAD/cwAIgcMuFNGQ5XalEJL7lijZQErdWxOcSHSPofhVg0FS6a+Bm+Kop
 gJnCm5OQVFgoxjDQkj5f4jHX2t8DyqV5EIM/AOLoovMLecQcltvovMS/wfMgAr9W/AMIeI/sT
 H7Q91dAejh5fsE+CRNL6llQyxsbxVmYkj74ro5GQfi3jNGFn3dyeF5uwVESR3s45hHpVgMTOS
 +aBQIVIwFxeJI0INkFgDf1FDHlp4Wz7OCK+yuL6yyNmokWAfVSDvt7DpRkVvR5/PJrUtlGcRc
 AhtTUc6/rQXivucQpRFsZzAdl0VCDPk/Kh3QzGVCNc4w3CgWFgqomsHSBQc7AA1bOf1/4lQDA
 yX5xYbSNvotuhKAgIzkqrV+N1A8Yg42UM0TCJZF621fBBtngCm2ErkydITdlaVqZZJ7CEB8AB
 /Z99ctrZ4uN4eAmGaCHr/Nug0R3ELhR7mRnM26dvcNbLTzkGCrQShBMcwcB42joVixd+QIFQd
 qmT1nMIkd3yiqYyaHwqVXlxOIszX8nGgq5GCFGUI1+4fzclEXixwFFYaEcO6EJnh6J1jRsLME
 c3OiKnG4NQv1pwGKLWsgCaypHO1BjXKbTt42KOfuXuNcRWfW/k/kWo=

On Fri, 12 Apr 2024 17:28:20 +0200
Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:

> On Fri, Apr 12, 2024 at 11:19:26AM -0400, Parker Newman wrote:
> > On Fri, 12 Apr 2024 13:57:01 +0300 (EEST)
> > Ilpo J=C3=A4rvinen <ilpo.jarvinen@linux.intel.com> wrote:
> >  =20
> > > On Thu, 11 Apr 2024, parker@finest.io wrote:
> > >  =20
> > > > From: Parker Newman <pnewman@connecttech.com>
> > > >=20
> > > > - Removed old port setup function and replaced with UART specific o=
nes
> > > > - Added board setup functions for CTI boards
> > > > - Replaced CONNECT_DEVICE macro with CTI_EXAR_DEVICE and CTI_PCI_DE=
VICE   =20
> > >=20
> > > In general, you should try to do refactoring in a preparatory patch (=
one=20
> > > refactoring thing at a time) and add new stuff in another patch in=20
> > > the series. I didn't go to figure out how much it applies to those th=
ree=20
> > > items because you likely know the answer immediately.
> > >  =20
> > > > - Moved "generic rs485" support up in the file   =20
> > >=20
> > > Please do this in a separate patch.
> > >  =20
> >=20
> > Will do.
> >  =20
> > >=20
> > > Another general level problem with your series is that it adds functi=
ons=20
> > > x, y, etc. without users, whereas the expected way of doing things wo=
uld=20
> > > be to add the functions in the change they are getting used so it's e=
asier=20
> > > to follow what's going on.
> > >=20
> > > I believe if you separate the refactoring & moving code around into o=
wn=20
> > > changes (no functional change type patches), the new stuff is much=20
> > > smaller so there is no need to split that illogically into incomplete=
=20
> > > fragments in some patches.
> > >=20
> > > --
> > >  i.
> > >  =20
> >=20
> > Thanks for the feedback, I am new to the mailing lists and am trying to=
 balance
> > what you mention above with not having giant patches.  =20
>=20
> It's a fine line, and takes a while to learn, but as a first cut, this
> was pretty good, I didn't have any major problems with the structure of
> it, so nice work.
>=20
> thanks,
>=20
> greg k-h

Thanks, I appreciate both your feedback I think I have a better handle on i=
t.
-Parker