Received-SPF: pass (google.com: domain of linux-kernel+bounces-142980-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Fri, 12 Apr 2024 10:52:20 -0500
From: Rob Herring <robh@kernel.org>
To: Seven Lee <wtli@nuvoton.com>
Cc: broonie@kernel.org, lgirdwood@gmail.com, alsa-devel@alsa-project.org,
	devicetree@vger.kernel.org, linux-sound@vger.kernel.org,
	krzysztof.kozlowski+dt@linaro.org, linux-kernel@vger.kernel.org,
	conor+dt@kernel.org, perex@perex.cz, tiwai@suse.com,
	YHCHuang@nuvoton.com, KCHSU0@nuvoton.com, CTLIN0@nuvoton.com,
	SJLIN0@nuvoton.com, scott6986@gmail.com, supercraig0719@gmail.com,
	dardar923@gmail.com, edson.drosdeck@gmail.com,
	u.kleine-koenig@pengutronix.de
Subject: Re: [PATCH 1/3] ASoC: dt-bindings: nau8821: Add delay control for ADC
Message-ID: <20240412155220.GA2918590-robh@kernel.org>
References: <20240412103554.3487290-1-wtli@nuvoton.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240412103554.3487290-1-wtli@nuvoton.com>

On Fri, Apr 12, 2024 at 06:35:52PM +0800, Seven Lee wrote:
> Change the original fixed delay to the assignment from the property. It
> will make it more flexible to different platforms to avoid pop noise at
> the beginning of recording.
> 
> Signed-off-by: Seven Lee <wtli@nuvoton.com>
> ---
>  .../devicetree/bindings/sound/nuvoton,nau8821.yaml        | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/sound/nuvoton,nau8821.yaml b/Documentation/devicetree/bindings/sound/nuvoton,nau8821.yaml
> index 054b53954ac3..a726c5a9b067 100644
> --- a/Documentation/devicetree/bindings/sound/nuvoton,nau8821.yaml
> +++ b/Documentation/devicetree/bindings/sound/nuvoton,nau8821.yaml
> @@ -103,6 +103,13 @@ properties:
>          just limited to the left adc for design demand.
>      type: boolean
>  
> +  nuvoton,adc-delay-ms:
> +    description: Delay (in ms) to make input path stable and avoid pop noise.
> +        The default value is 125 and range between 125 to 500 ms.

No need to state constraints in prose.

> +    minimum: 125
> +    maximum: 500
> +    default: 125
> +
>    '#sound-dai-cells':
>      const: 0
>  
> @@ -136,6 +143,7 @@ examples:
>              nuvoton,jack-eject-debounce = <0>;
>              nuvoton,dmic-clk-threshold = <3072000>;
>              nuvoton,dmic-slew-rate = <0>;
> +            nuvoton,nuvoton,adc-delay-ms = <125>;
>              #sound-dai-cells = <0>;
>          };
>      };
> -- 
> 2.25.1
>