Received: by 2002:a05:7208:3228:b0:82:47:81bb with SMTP id cb40csp543643rbb; Fri, 12 Apr 2024 08:57:18 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUqSdlmRybjQM2LncNWd4/pV4y8r4hepsLWUC7JbkizM9Cd6FcP+TR5nCnieTiOKFVkjn7xYoNYo0+sPrG3yKxsrVmQ/F93TZGlb6VTyw== X-Google-Smtp-Source: AGHT+IHjwY1mpgj8c2qAYO+/IRzDSDosD9yAoQQhU05z5FHe8xReLo8GRND13/IyM8wxYd21UpVC X-Received: by 2002:a05:620a:2047:b0:78e:c0de:3ef4 with SMTP id d7-20020a05620a204700b0078ec0de3ef4mr3004349qka.34.1712937438521; Fri, 12 Apr 2024 08:57:18 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712937438; cv=pass; d=google.com; s=arc-20160816; b=mclwOWg5kgDOjtyecpE3Nv/aT400EIzNu7cO1q2OqCd6EInEP41CuK4DtFr6gQHpbX mL4bCSO4SUQU18RhTAsJRJJeWERC7o4+/UUnAEOgodwRltsXzMqNmPUTpUCYS4mwTg7k CJJUlLdDzxdDHs+ZLhAylKpvtDuzWg9KWPOHQN+cTNJWDnN1heg59EbIXmEPKnCpbf+W 1vtf2cm58e4IGM5BygW+utMDHbS/zSk4H/GZxSDZau8silKPXZJ1STLlOJe8P5kslELH Cnnx99dgszeg2ZLkVHrVs6JFVPzuMpFKNC113dpen84lJmbK4husP9a6+TzoCY/yEAUw d+Aw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :user-agent:references:message-id:in-reply-to:subject:cc:to:from :date:dkim-signature; bh=RKCjcKq2P64OkJGR1sAJLdGo5Rkd21piAbN+OYXT/NU=; fh=HqxZNnzCyDTwgIeV3+NLGNqFPRPwMSuxAqxvVQN6mok=; b=XZ3fsIuMEH0gcC4W9nmsarY/vyTI5ewHljCuybJ1AYBQ2sOB03gsx0OHHirL6QgB0o lbMtipP6QN2ybk2aWkgNai4Nj4LGb08nYUlIDPyRk3QMjsdFggBI7giXV3KuQNQ/cT8l OE5tRMaKO4bf9l688jp8D0wIne3lPFe0OfAZL2suNAPa7TKNIrDXv1fcs51z+dW1iP8p VPh3PyL0nyCMCVr0FKF5djUd4F1dENo+NKCIUofHEia3HfLS6+9IBuPnpb35m5mior0w g+UZ29/SF5w6GhIsu1QHgHD/7NHQlAjzZQ3RCGKOm6M5NDgBYVgRFtxAUcHEwGAbEyDy CrwQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=lfMiWMYK; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-142986-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-142986-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id c6-20020a05620a200600b0078da0a01a91si3800269qka.610.2024.04.12.08.57.18 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Apr 2024 08:57:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-142986-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=lfMiWMYK; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-142986-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-142986-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id E0C561C21BBC for ; Fri, 12 Apr 2024 15:57:08 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 67B29148FE4; Fri, 12 Apr 2024 15:56:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="lfMiWMYK" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8202E14884C; Fri, 12 Apr 2024 15:56:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712937393; cv=none; b=jVyrZEn7apMGo//5hJeDQ92QUnzTfY1Am3exlpFB17yNGP8qar7T40FGPxzgCh8dctpxnckIj7yPgoMvvBN48YBwaxM0x80mPxASioDYeM/hjYB2sWzlBpEMRTod1par/qPoU5nwoNB25zybkThy7ZZ2vp1wFwe7eDEn76pZGXA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712937393; c=relaxed/simple; bh=EH2WjFmIHkNUY/vFnUTVm2nyvZug9GDXvhQF7t60oDQ=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References: MIME-Version:Content-Type; b=BaTPFLbaKW9KM0lFFsoaX4sPunO6CKPDUcZuprdwMD2skZxPOtp3/9m9wbuf9BqU7LFB/NSdAwi+ykjFkIBXWSnQoXg2YuUiQQyFwtANxzZdFM0sYkJlQRQcCdI2ucV0CbweO+vCNtCIFDir7G/zvBDtmUpSTeHqgZI7f3yASXg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=lfMiWMYK; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 02907C2BBFC; Fri, 12 Apr 2024 15:56:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712937393; bh=EH2WjFmIHkNUY/vFnUTVm2nyvZug9GDXvhQF7t60oDQ=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=lfMiWMYKSk0qOL004piEiMPPR8E9SZFLnp1H2MXblnITXGvs9Y0nRkQif86Zw7vbk /rUw10BpQljJb5U++nUl6ZQzx35pdXDjO5CISxvb+pN1wpdbwjq2fN6TBXriHEh9o7 iRYKt/OzL3PRRjBIOYTgV9zNtO4WGvszyWszg/VvokNmrq27o/fXlkfBHXI/t4/0Zv QM0vpklANtsOT7DeB84RkV26n/aXzIcVDwur5pLJBjnMmhCOCuh7RpoOoHJaqmVKm6 rN/m1SB+UWn7eo0gXSyMDGsCTyTzoMRXaRyIp+aSyMjHrvhmY7EFIwK9AyvhPU/1F/ pS3IBbaqS3MKg== Date: Fri, 12 Apr 2024 17:56:31 +0200 (CEST) From: Jiri Kosina To: Colin Ian King cc: Benjamin Tissoires , linux-input@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][next] HID: sony: remove redundant assignment to variable ret In-Reply-To: <20240328122213.762889-1-colin.i.king@gmail.com> Message-ID: References: <20240328122213.762889-1-colin.i.king@gmail.com> User-Agent: Alpine 2.21 (LSU 202 2017-01-01) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Thu, 28 Mar 2024, Colin Ian King wrote: > The variable ret is being assigned a value that is never read > afterwards. The assignment is redundant and can be removed. > > Cleans up clang scan build warning: > drivers/hid/hid-sony.c:2020:3: warning: Value stored to 'ret' > is never read [deadcode.DeadStores] That assignment is indeed bogus. Applied, thanks. -- Jiri Kosina SUSE Labs