Received-SPF: pass (google.com: domain of linux-kernel+bounces-143026-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Fri, 12 Apr 2024 19:12:39 +0300
From: Raag Jadav <raag.jadav@intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= <u.kleine-koenig@pengutronix.de>,
	jarkko.nikula@linux.intel.com, mika.westerberg@linux.intel.com,
	linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] pwm: dwc: allow suspend/resume for 16 channels
Message-ID: <Zhldd6D7ts_QJ7rt@black.fi.intel.com>
References: <20240412060812.20412-1-raag.jadav@intel.com>
 <zf74jdjza2kfgmiecmlwlws46fmy3rtxvcocmkwewgx64oewpm@xfyq2zt6ts5u>
 <Zhk-7Tp4HzF41Is5@black.fi.intel.com>
 <ZhlXLNlsHEWrxEjF@smile.fi.intel.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <ZhlXLNlsHEWrxEjF@smile.fi.intel.com>

On Fri, Apr 12, 2024 at 06:45:48PM +0300, Andy Shevchenko wrote:
> On Fri, Apr 12, 2024 at 06:38:24PM +0300, Raag Jadav wrote:
> > On Fri, Apr 12, 2024 at 01:12:48PM +0200, Uwe Kleine-K?nig wrote:
> > > On Fri, Apr 12, 2024 at 11:38:12AM +0530, Raag Jadav wrote:
> 
> ...
> 
> > > Otherwise I (only slightly) dislike
> > > > +	struct dwc_pwm_drvdata *data;
> > > because "data" is very generic. I'd call it ddata. But I don't feel
> > > strong here. I'm happy if you change to "ddata" in v2, I will silently
> > > apply anyhow if you prefer "data".
> > 
> > I think "data" is more readable, something like "ddata" would make me
> > re-adjust my glasses ;)
> 
> ddata is _kinda_ idiomatic, there at least several drivers use this name
> (as of my knowledge). I am bending towards Uwe's suggestion here.

Will update in v2.

Raag
> 
> -- 
> With Best Regards,
> Andy Shevchenko
> 
>