Received-SPF: pass (google.com: domain of linux-kernel+bounces-143033-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Fri, 12 Apr 2024 19:15:11 +0300
From: Raag Jadav <raag.jadav@intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: u.kleine-koenig@pengutronix.de, jarkko.nikula@linux.intel.com,
	mika.westerberg@linux.intel.com, linux-pwm@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] pwm: dwc: allow suspend/resume for 16 channels
Message-ID: <ZhleDwUJLDEG5QwH@black.fi.intel.com>
References: <20240412060812.20412-1-raag.jadav@intel.com>
 <ZhlU176sS36_JvQU@smile.fi.intel.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZhlU176sS36_JvQU@smile.fi.intel.com>

On Fri, Apr 12, 2024 at 06:35:51PM +0300, Andy Shevchenko wrote:
> On Fri, Apr 12, 2024 at 11:38:12AM +0530, Raag Jadav wrote:
> > With 16 channel pwm support, we're registering two instances of pwm_chip
> > with 8 channels each. We need to update PM functions to use both instances
> > of pwm_chip during power state transitions.
> > 
> > Introduce struct dwc_pwm_drvdata and use it as driver_data, which will
> > maintain both instances of pwm_chip along with dwc_pwm_info and allow us
> > to use them inside suspend/resume handles.
> 
> ...
> 
> > +	data = devm_kzalloc(dev, struct_size(data, chips, info->nr), GFP_KERNEL);
> > +	if (!data)
> > +		return dev_err_probe(dev, -ENOMEM, "Failed to allocate drvdata\n");
> 
> Haven't noticed before, but we do not print messages for -ENOMEM. Just return
> the code.

Any special case for -ENOMEM?
I found a few drivers which still do.

Raag