Received-SPF: pass (google.com: domain of linux-kernel+bounces-143092-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Fri, 12 Apr 2024 19:45:48 +0300
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Raag Jadav <raag.jadav@intel.com>
Cc: u.kleine-koenig@pengutronix.de, jarkko.nikula@linux.intel.com,
	mika.westerberg@linux.intel.com, linux-pwm@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] pwm: dwc: allow suspend/resume for 16 channels
Message-ID: <ZhllPOXt41Ndlhc_@smile.fi.intel.com>
References: <20240412060812.20412-1-raag.jadav@intel.com>
 <ZhlU176sS36_JvQU@smile.fi.intel.com>
 <ZhleDwUJLDEG5QwH@black.fi.intel.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZhleDwUJLDEG5QwH@black.fi.intel.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo

On Fri, Apr 12, 2024 at 07:15:11PM +0300, Raag Jadav wrote:
> On Fri, Apr 12, 2024 at 06:35:51PM +0300, Andy Shevchenko wrote:
> > On Fri, Apr 12, 2024 at 11:38:12AM +0530, Raag Jadav wrote:

..

> > > +	data = devm_kzalloc(dev, struct_size(data, chips, info->nr), GFP_KERNEL);
> > > +	if (!data)
> > > +		return dev_err_probe(dev, -ENOMEM, "Failed to allocate drvdata\n");
> > 
> > Haven't noticed before, but we do not print messages for -ENOMEM. Just return
> > the code.
> 
> Any special case for -ENOMEM?

Yes. But I have no link to the discussion at hand. Just believe me, or look into
Git history for changes that drop that messaging. Perhaps one or two will give a
hint where it starts from...

> I found a few drivers which still do.

They should be fixed.

-- 
With Best Regards,
Andy Shevchenko