Received-SPF: pass (google.com: domain of linux-kernel+bounces-143105-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Fri, 12 Apr 2024 19:03:01 +0200
From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, 
	Raag Jadav <raag.jadav@intel.com>, linux-kernel@vger.kernel.org, kernel@pengutronix.de, 
	"Rafael J. Wysocki" <rafael@kernel.org>
Subject: Re: [PATCH] driver core: Make dev_err_probe() silent for -ENOMEM
Message-ID: <cl5fmton3n5ayzr7ondnw7lzjaxoppyqhnoervj2fn4et75ish@cyko4abxbslg>
References: <20240412164405.335657-2-u.kleine-koenig@pengutronix.de>
 <ZhlmpPNbEMRye2wZ@smile.fi.intel.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="sbcagtoynlrbogwn"
Content-Disposition: inline
In-Reply-To: <ZhlmpPNbEMRye2wZ@smile.fi.intel.com>


--sbcagtoynlrbogwn
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hello Andy,

On Fri, Apr 12, 2024 at 07:51:48PM +0300, Andy Shevchenko wrote:
> On Fri, Apr 12, 2024 at 06:44:05PM +0200, Uwe Kleine-K=F6nig wrote:
> > For an out-of-memory error there should be no additional output. Adapt
> > dev_err_probe() to not emit the error message when err is -ENOMEM.
> > This simplifies handling errors that might among others be -ENOMEM.
>=20
> ...
>=20
> 	BUILD_BUG_ON(err =3D=3D -ENOMEM);
>=20
> Done!

Well no, that doesn't do the trick. Consider for example device_add().
That function can return (at least) -EINVAL and -ENOMEM. To properly
ensure that the error handling is silent with the current
dev_err_probe(), we'd need to do:

	ret =3D device_add(...);
	if (ret) {
		if (ret !=3D -ENOMEM)
			return dev_err_probe(...);
		else
			return ret;
	}

With my suggested patch this can be reduced to:

	ret =3D device_add(...);
	if (ret)
		return dev_err_probe(...);

Best regards
Uwe

--=20
Pengutronix e.K.                           | Uwe Kleine-K=F6nig            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--sbcagtoynlrbogwn
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmYZaUQACgkQj4D7WH0S
/k7xKgf/bGWGnsRqI5M+8/OsjvL4w+mkTlZASk12eq2pnL/pK4gZsvRC3W5CtxJ9
9b60Jdc0dSiWQ9lUUe7Eb7olo/IEfMu6AQIDUoZo0w7prNBAVHcNF8LdJe6Utaw/
gJR9Pot2y4i7Syon4CngwgJOPGLXThFDjdhpmXS2nwYnwI4ANUJSVqCLdFhe5dmp
qJYFhGmbjhtPspH13xpXNnT5dH18gjiBo0dnZ72WrcJZxpASgp1vFqvsjtAHKeGk
rd51u+3UR3le0z/YA251Ttk9igIFbMEtdP6/EQyJ40PhQx1ByFFaDQNCbIe+FN5E
ly1RhW18ChECmGRG4ZLE2hIpHHOqZw==
=1TOJ
-----END PGP SIGNATURE-----

--sbcagtoynlrbogwn--