Received-SPF: pass (google.com: domain of linux-kernel+bounces-143114-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Fri, 12 Apr 2024 20:07:29 +0300
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= <u.kleine-koenig@pengutronix.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Raag Jadav <raag.jadav@intel.com>, linux-kernel@vger.kernel.org,
	kernel@pengutronix.de, "Rafael J. Wysocki" <rafael@kernel.org>
Subject: Re: [PATCH] driver core: Make dev_err_probe() silent for -ENOMEM
Message-ID: <ZhlqUdywIur4dzgE@smile.fi.intel.com>
References: <20240412164405.335657-2-u.kleine-koenig@pengutronix.de>
 <ZhlmpPNbEMRye2wZ@smile.fi.intel.com>
 <cl5fmton3n5ayzr7ondnw7lzjaxoppyqhnoervj2fn4et75ish@cyko4abxbslg>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <cl5fmton3n5ayzr7ondnw7lzjaxoppyqhnoervj2fn4et75ish@cyko4abxbslg>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo

On Fri, Apr 12, 2024 at 07:03:01PM +0200, Uwe Kleine-K?nig wrote:
> On Fri, Apr 12, 2024 at 07:51:48PM +0300, Andy Shevchenko wrote:
> > On Fri, Apr 12, 2024 at 06:44:05PM +0200, Uwe Kleine-K?nig wrote:
> > > For an out-of-memory error there should be no additional output. Adapt
> > > dev_err_probe() to not emit the error message when err is -ENOMEM.
> > > This simplifies handling errors that might among others be -ENOMEM.

> > ...
> > 
> > 	BUILD_BUG_ON(err == -ENOMEM);
> > 
> > Done!
> 
> Well no, that doesn't do the trick. Consider for example device_add().
> That function can return (at least) -EINVAL and -ENOMEM. To properly
> ensure that the error handling is silent with the current
> dev_err_probe(), we'd need to do:
> 
> 	ret = device_add(...);
> 	if (ret) {
> 		if (ret != -ENOMEM)
> 			return dev_err_probe(...);
> 		else
> 			return ret;
> 	}
> 
> With my suggested patch this can be reduced to:
> 
> 	ret = device_add(...);
> 	if (ret)
> 		return dev_err_probe(...);

Fair enough, but these two should be combined.
Mine is for the rejecting a dead code on the phase of the submission.

-- 
With Best Regards,
Andy Shevchenko