Message-ID: <4797BE43.9090600@zytor.com>
Date: Wed, 23 Jan 2008 14:22:59 -0800
From: "H. Peter Anvin" <hpa@zytor.com>
User-Agent: Thunderbird 2.0.0.9 (X11/20071115)
MIME-Version: 1.0
To: Willy Tarreau <w@1wt.eu>
CC: Ingo Molnar <mingo@elte.hu>,
       Arnd Hannemann <hannemann@i4.informatik.rwth-aachen.de>,
       Jordan Crouse <jordan.crouse@amd.com>, Lars Heete <hel@admin.de>,
       Andres Salomon <dilinger@queued.net>,
       Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
       Thomas Gleixner <tglx@linutronix.de>,
       Andrew Morton <akpm@linux-foundation.org>,
       Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH 1/2] x86: GEODE fix MFGPT input clock value
References: <478FCDB6.4010708@i4.informatik.rwth-aachen.de> <4795B14C.7040502@i4.informatik.rwth-aachen.de> <200801221111.21240.hel@admin.de> <4795D120.7070806@i4.informatik.rwth-aachen.de> <20080122192757.GC5241@cosmic.amd.com> <47965806.6080903@i4.informatik.rwth-aachen.de> <20080122211014.GA27870@elte.hu> <20080123211746.GA2969@1wt.eu> <20080123211859.GA3081@1wt.eu> <4797B8C4.9060102@zytor.com> <20080123221129.GA27022@1wt.eu>
In-Reply-To: <20080123221129.GA27022@1wt.eu>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1008
Lines: 26

Willy Tarreau wrote:
> Hi Peter,
> 
> On Wed, Jan 23, 2008 at 01:59:32PM -0800, H. Peter Anvin wrote:
>> Willy Tarreau wrote:
>>> The GEODE MFGPT code assumed that 32kHz was 32000 Hz while the boards
>>> run on a 32.768 kHz digital watch crystal. In practise, it will not
>>> change the timer's frequency as the skew was only 2.4%, but it
>>> should provide more accurate intervals.
>>> - *  Divisor   Hz      Min Delta (S) Max Delta (S)
>> Seconds are "s", not "S" (S = siemens.)
> 
> You're quite right. Same as we should write kHz and not Khz. But I'm
> used to change other people's work and particularly comments the least
> possible. Do you want an update ?
> 

I much prefer to see this done right.  I have a pretty case-sensitive 
brain, it seems.

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/