Received-SPF: pass (google.com: domain of linux-kernel+bounces-143206-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
From: Namhyung Kim <namhyung@kernel.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>,
	Ian Rogers <irogers@google.com>,
	Kan Liang <kan.liang@linux.intel.com>
Cc: Jiri Olsa <jolsa@kernel.org>,
	Adrian Hunter <adrian.hunter@intel.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	linux-perf-users@vger.kernel.org
Subject: [PATCH 0/4] perf annotate-data: A couple of small updates
Date: Fri, 12 Apr 2024 11:33:06 -0700
Message-ID: <20240412183310.2518474-1-namhyung@kernel.org>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Hello,

I am working on improving quality of the data type profiling and I
found some issues.  One is when more than one variables are placed at
the same location.  Then it should find the correct one based on the
given info rather than checking the first one and bailing out.  This
one (patch 2) can go to the perf-tools tree.

Another issue is use of the stack pointe register when it's not the
frame base register.  I found a case where rbp is used as the frame
base but rsp is also used to point some stack variables.  And it
confuses itself how to interpret the type of the variable.

I think these are rare cases but it would depends on the code pattern
and compiler behavior.  Anyway I can see a tiny improvement in my data
with this change. :)

Thanks,
Namhyung


Namhyung Kim (4):
  perf annotate-data: Improve debug message with location info
  perf dwarf-aux: Check pointer offset when checking variables
  perf dwarf-aux: Check variable address range properly
  perf annotate-data: Handle RSP if it's not the FB register

 tools/perf/util/annotate-data.c | 126 +++++++++++++++++++++++++-------
 tools/perf/util/dwarf-aux.c     |  35 ++++++---
 2 files changed, 125 insertions(+), 36 deletions(-)


base-commit: 0ffc8fca5c15a70f32c8aff12c566bbd3991bd0a
-- 
2.44.0.683.g7961c838ac-goog