Received-SPF: pass (google.com: domain of linux-kernel+bounces-143223-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <9708f56f-dfe1-4425-abb8-dc7f1bdfd44d@intel.com>
Date: Fri, 12 Apr 2024 11:45:06 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 2/3] platform/x86/intel/ifs: trace: display batch num in
 hex
To: Jithu Joseph <jithu.joseph@intel.com>, <ilpo.jarvinen@linux.intel.com>,
	<hdegoede@redhat.com>, <markgross@kernel.org>
CC: <linux-kernel@vger.kernel.org>, <platform-driver-x86@vger.kernel.org>,
	<ashok.raj@intel.com>, <tony.luck@intel.com>, <rostedt@goodmis.org>,
	<ravi.v.shankar@intel.com>, <patches@lists.linux.dev>
References: <20240412172349.544064-1-jithu.joseph@intel.com>
 <20240412172349.544064-3-jithu.joseph@intel.com>
Content-Language: en-US
From: "Kuppuswamy, Sathyanarayanan" <sathyanarayanan.kuppuswamy@intel.com>
In-Reply-To: <20240412172349.544064-3-jithu.joseph@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cXdYY25MeFdBNDRoenB1OVB6djBTZ3oreVQ0VDhuc2FhbThTVHBiZUNXWEtj?=
 =?utf-8?B?SThxenBxV3dGR0VVU0QxYStGbkRDMFF2SmJXbmx5ZUsxWEpNTHRFUERzeXJN?=
 =?utf-8?B?c3psMU1MaVZLaTVXQkJydDQwQnFTNkxnZ0ZxbCtvQlJ5WFpLMTFLZVFZeE00?=
 =?utf-8?B?Lyt3OUdoRGhsblZTcklNVkJqT1FUenhNeVh2TjVrSTUrSnhlb20xWmt4ODZ0?=
 =?utf-8?B?cE5KYWlUd2R2eHhiS3dSLzRkVFdsL1FsTThxWUllOTB4WEJnVlRkck56OW5O?=
 =?utf-8?B?RXpWMUU4OXJhY0tkTFhSdmdpaTcxUU1YT3BDVnBMT1VzQjZMNlorV3dSYit1?=
 =?utf-8?B?TE1veHJFRFFxeGwxZVhMVWZRRGJCdGhzSTF4TDlxMlJGMkpsM2d4Rm1iMWRr?=
 =?utf-8?B?b1ByY2JSdXF2enpydGhvSEhKN1hFU3BGR3grdkxqbUpaaFhqZHNSWVBSdVFm?=
 =?utf-8?B?ak9rVndHMVVMSVZhRHhFNGh6Wm1LMUpjbGM3QklMcnZwaXRZa0xkY0hNUk1W?=
 =?utf-8?B?SWJoWXhhblpNK3M0NU1RV1o5Y3RuWmQ3aDFRampDMXF2TGIySFRiRys1NEJE?=
 =?utf-8?B?bzhJU3BTcXVoMDlwa0pieDkzeGpnS0xzOExqNHVybGNUWEFUS2JjQmRnVVYz?=
 =?utf-8?B?R2ZZWCt1NFlWcEJ0dGlNOTBzNStIU1puSWp0Ujc0U2F3bFpWODRJb1FQaUNP?=
 =?utf-8?B?V2x4d2pnc3JjNm5NZS9vQ05IQ2o0NmdYUGl0dHE1NkxWbWpRMjA3bjNaMDhu?=
 =?utf-8?B?b2FzelFmdHY1U3lWOHdMS0h6MmVPS1R1OFFsUk5GQmFGeXFuRFl5KzlYS3dx?=
 =?utf-8?B?aG9zNFRFY3ZsVFMxdG9zczJQTzlUL2c4WXBURWVZNlFHaGJLaFg5YWo0U0w1?=
 =?utf-8?B?RTB6TjZYVTJiWTUybmNzbzc3ai9UUVhPc2FIcmxHeXpjb0MxSW1CcDNSNDE4?=
 =?utf-8?B?Sk9LT2lZNVc0ZGk3VTV2dDN2ZlJYQ2k3aUdGOWxuQ1lOZ2tYNEZuS3l3dGtz?=
 =?utf-8?B?elF1MXZqK1dYdkVxT2Z3V1RLN0JnRFNPdFRBZXgvRkMvUmlVbnNWZVhWWTc4?=
 =?utf-8?B?ZWYzOVo1L2NpRmJBbHBJeWZ0VlZjazQvYkhxNWg4RGFGbVRWRDlPZnhJUHJQ?=
 =?utf-8?B?MUF4MzI3c092cG9FZnR1eTFJWmFBa0NhMEVDM1dlbUU1dVZ2N2tCcnlEUmlU?=
 =?utf-8?B?NnRMSGVrWDZIZU9CTXk2akRZdjJLQURXdFNDT09mYWRYY2l3Y2VpNUxBaXp0?=
 =?utf-8?B?cVFsaXBNbWMvT0VEM0g5bFNidDRKSXhoalB1cGZ0YVF1R2w3M0FMUENiWVNL?=
 =?utf-8?B?emhNcGFRRFphcDlFUXBOL2dLclQvTVY0TkxNUjJOR3IzN2RhNlpPRXd5WnBp?=
 =?utf-8?B?K2hNbWZicnYvZWFkY2E2VG5wOFBkQ1BLS1FBS0VXRUtPMXY5aklLZEJpMDh1?=
 =?utf-8?B?VURiOVp0eXo4OHVBSkVpZ0ZZd2p2ZmlWeWNOcVZPQllsU1lWeFowOWIyY3VM?=
 =?utf-8?B?TVZEVU10WGJpUHgrbFBwaU9sbmYrSXhFQzdIVHdBbXRIWW51VzJHUDcxT2s3?=
 =?utf-8?B?UWJSb3pCSVZJR0lOWGRkZ3lNdDFUTDJLZHVaWDRjRk50bVhHSjJiN3FWSzhL?=
 =?utf-8?B?cjM0MG1abCtPWGxnRHpTaHFsd3pSdjg1LzFxNzd3djRNWmlhWWJMUWtJY1cv?=
 =?utf-8?B?d2NCS0xML3ZmcFk2QjNtTm4xb0grbUloS1BNU1BOMFN3YVpteDJKMFAwSUtu?=
 =?utf-8?B?dG5pV0laVUZGSnJQOXl4Q1dBNlMwb1MyOUJKazJLYTRXM1hVWWIrUk0rYXBj?=
 =?utf-8?B?amZZK1VYS1ZUUGtFa1BMbU5ja3F1MWRNcHpNV0cyRjgvd1lOOEFSQmhZOGZo?=
 =?utf-8?B?d25Zc0YwYmVTRURwSzNlaGk4RGVta0Q3c2NoQXk3ckxqdGVIcEFVeGN0QkM2?=
 =?utf-8?B?eTNIdkFnZU5pRjE2bkRBNnh6ZXU2Zk1JYmZ3d1I0QUhhcldJK0ttV2t1MzVr?=
 =?utf-8?B?eUVlcEQ5eTV3alhnOEgzQ3lWYzY2bldDeWFGYkYvSUluYzFYNXJkajJtZDVq?=
 =?utf-8?B?TUFwcDRvWlY1SXQzYW1CZkIweHByUUlseWlrTE9aSTR5VUN2cktDRkhaLzBj?=
 =?utf-8?B?aDMyTHFSLzhpc0pBQnB2ZGxqcXRrM1AycUUzL1J1MzlFc0lBMmo1YzBDSVhj?=
 =?utf-8?B?aE9mQmlKZFNONmRSZE1Bdk1xSGY3TzJvQXJ0elFYWkRFZGVIbno4Syt6a0VI?=
 =?utf-8?Q?1KKKJCsSgnCBKspvmfsuQIfsssk+rD+RmEbz3yRqTg=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 1680aabc-d5af-49cd-8896-08dc5b20ad67
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB8279.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Apr 2024 18:45:08.7640
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6c9Zr4/D647u0uu1s0qcH0ApmTwZJ3ggaNsLG394UQQHKKO00dEbhNwXfYmzdIhyXdnCM1CjB6Ued8cCLpDW6ijYCkNL6CVK38n8QibQKrGkBNg/RgYep6HsN9NwH+E0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB4845
X-OriginatorOrg: intel.com


On 4/12/24 10:23 AM, Jithu Joseph wrote:
> In Field Scan test image files are named in ff-mm-ss-<batch02x>.scan
> format. Current trace output, prints the batch number in decimal format.
>
> Make it easier to correlate the trace line to a test image file by
> showing the batch number also in hex format.
>
> Add 0x prefix to all fields in the trace line to make the type explicit.
>
> Signed-off-by: Jithu Joseph <jithu.joseph@intel.com>
> Reviewed-by: Tony Luck <tony.luck@intel.com>
> Reviewed-by: Ashok Raj <ashok.raj@intel.com>
> ---

Reviewed-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>

>  include/trace/events/intel_ifs.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/trace/events/intel_ifs.h b/include/trace/events/intel_ifs.h
> index 8ce2de120f2d..0d88ebf2c980 100644
> --- a/include/trace/events/intel_ifs.h
> +++ b/include/trace/events/intel_ifs.h
> @@ -28,7 +28,7 @@ TRACE_EVENT(ifs_status,
>  		__entry->status	= status;
>  	),
>  
> -	TP_printk("batch: %.2d, start: %.4x, stop: %.4x, status: %.16llx",
> +	TP_printk("batch: 0x%.2x, start: 0x%.4x, stop: 0x%.4x, status: 0x%.16llx",
>  		__entry->batch,
>  		__entry->start,
>  		__entry->stop,

-- 
Sathyanarayanan Kuppuswamy
Linux Kernel Developer