Received: by 2002:ab2:69cc:0:b0:1f4:be93:e15a with SMTP id n12csp125576lqp; Fri, 12 Apr 2024 12:22:59 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWNUO1Vsm1UUoGN8lqkv64qY92uYTEZhreBTBMtvScWDfz5+vBIpQfbkd11WcgBnc+Ed/9mGL/kaNiP/V7d/WFc/sgYQ5V6Qv1skZh5ug== X-Google-Smtp-Source: AGHT+IHYlN/3D2Ki1W6n0j/xqgeg9M8MEpJ69YvCN5KN84SufOMMTgSEobiODAHk3WKzFEZz29Hw X-Received: by 2002:a05:6e02:154c:b0:36a:1e55:535b with SMTP id j12-20020a056e02154c00b0036a1e55535bmr3993330ilu.16.1712949779450; Fri, 12 Apr 2024 12:22:59 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712949779; cv=pass; d=google.com; s=arc-20160816; b=jnfIDbs8EQAFwH7IVXbmpvAAVHuYircfkNDn1gBnpIer/wlfTGb7Jm/O/+ekTuzKum 1ymPFdGTTMfb87B4t+I1duAI7V7eUNXCFN+kToPoHlGncxfH47KZZAPEPacL7/3Jg1He QACNusTYMMcOVM+1bqkT8nsYSuwZNo8K1XF1LdkP9EB6oZuU9ZCcCeUtzZ/yjAbX6yxo K4wonDXeeYZUWJqDwXZefaVdumaI3NrD+9trLG6HtU7+2b7p+BYO4CYpzAS4RTkwqRIC wT6raQx5mzXFawNCK86IytnY+VoxcaeQ7aBhVtq3Vw5i4VO6Hbxlg55A/4GATClBf11V I6sg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=hTlRjp+GLWBCq38BHZDRc8AYPNQSsRckMkxhoDVV6JE=; fh=B/JEExqQ0o/M46dV1T8vkhsaBOmc9yng/AVrFfzFkqY=; b=vvHup5y0vnaky6YfplqtnmgA2nPfaEqP/cG4wY3tCg/8iQHvazYzo7ZKkBKVwGYhaV o02OiA2P6TFj/oFVzFx5ZThsBd8DLdMP1BIDmWwUQunkVZkK2h5MsjuDD8ftg3odDQvO wU5OetIX1wMzyvwFQtenYJRgBVab2RnHCiW0RNDzwHR7n4TGn8dByKmMgK1yerwRZYJ1 R8ulsQOM1jv3BGpkgdNmOGEm3EauRGZdZkfCpKRCihmAcdQsY1TUxCcawrsn2oEA5nrA pHrwXJKyJ5sFGljq7FyXGQhBwk6gepZf11KHL9IthG1teGC8hJaBKSSMS9EWwNQHH68j 1ehg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=UZBEn244; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-kernel+bounces-143246-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-143246-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id n32-20020a634d60000000b005dd565d7626si3717601pgl.900.2024.04.12.12.22.59 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Apr 2024 12:22:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-143246-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=UZBEn244; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-kernel+bounces-143246-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-143246-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 4D480285C76 for ; Fri, 12 Apr 2024 19:22:30 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 89B0514F9EF; Fri, 12 Apr 2024 19:22:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="UZBEn244" Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3841E14F9EA for ; Fri, 12 Apr 2024 19:22:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712949744; cv=none; b=WgGVJ1e1wRFYiAartcETVmnxlwWOS1aAmetgY01J1/pD2NwwNrLUsz13OnmffgiK49cSx1LjMrML72huJgsdZ9hDqJ8gouzRl4ZRUbRlVqdn/TvMNTG+A81OXNCOWLYJTYn4nt72sgHGoWKEPdGiY/8o2cIXSAqw4pJj7n8rmIk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712949744; c=relaxed/simple; bh=rJJDW6M/uVgQhjBMv5U9Y/+x8Home6Qs2tK4Mimp7eo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=i/hh6F29NiymZoamTLUqyPV6oq9PvPNzxyaM6Uz6tgRZhc5vi704tdLQ0HEdb3O2dLoN2LOL2COTH4uJxRiioAhqR7dLNs6XMMY82RLjkO5txIqahAKeTsCiaidz5dU2zXRj1EM7OcRGokbvuKISQCzmWYdDItvjZmxML7mn3Dk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=UZBEn244; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712949742; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hTlRjp+GLWBCq38BHZDRc8AYPNQSsRckMkxhoDVV6JE=; b=UZBEn244Hb3j3Fl95AU/OMl8EzPewoxrk0cACApQk6UrUEcXbQf87d6MzJc3niXlgQv4nR sU4gTXaVTd2xvst483R/cSoel8SzRL+QHBRYSRChkJCER59npiTXjGuEscGhYCoJqesV60 tEwqDGqsQ3QjzRay5+/gy3OZ+oz4oO4= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-83-z3oD1CXXOCC78S8Ew5BmrQ-1; Fri, 12 Apr 2024 15:22:20 -0400 X-MC-Unique: z3oD1CXXOCC78S8Ew5BmrQ-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 0489E1049BC7; Fri, 12 Apr 2024 19:22:20 +0000 (UTC) Received: from cmirabil.redhat.com (unknown [10.22.10.2]) by smtp.corp.redhat.com (Postfix) with ESMTP id 731062DD51; Fri, 12 Apr 2024 19:22:19 +0000 (UTC) From: Charles Mirabile To: brauner@kernel.org Cc: hpa@zytor.com, jack@suse.cz, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, luto@kernel.org, torvalds@linux-foundation.org, viro@zeniv.linux.org.uk, Charles Mirabile Subject: [PATCH] Re: [PATCH] vfs: relax linkat() AT_EMPTY_PATH - aka flink() - requirements Date: Fri, 12 Apr 2024 15:22:17 -0400 Message-ID: <20240412192217.4172554-1-cmirabil@redhat.com> In-Reply-To: <20240412-vegetarisch-installieren-1152433bd1a7@brauner> References: <20240412-vegetarisch-installieren-1152433bd1a7@brauner> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.1 this is a nitpic, but if you are going to touch the comment on line 4654 I think you should fix the spelling mistake :^) handlink -> hard link Signed-off-by: Charles Mirabile --- fs/namei.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/namei.c b/fs/namei.c index 6d5b3f0d6ad3..9b806b108ed0 100644 --- a/fs/namei.c +++ b/fs/namei.c @@ -4651,7 +4651,7 @@ int do_linkat(int olddfd, struct filename *old, int newdfd, * To use null names we require CAP_DAC_READ_SEARCH or * that the open-time creds of the dfd matches current. * This ensures that not everyone will be able to create - * handlink using the passed file descriptor. + * hard links using the passed file descriptor. */ if (flags & AT_EMPTY_PATH) how |= LOOKUP_LINKAT_EMPTY; -- 2.44.0