Received-SPF: pass (google.com: domain of linux-kernel+bounces-143056-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <5ab77ba9-721a-413e-bb26-6c842679f61a@infradead.org>
Date: Fri, 12 Apr 2024 09:20:06 -0700
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [GIT PULL] tracing: Fixes for v6.9
To: Steven Rostedt <rostedt@goodmis.org>,
 Linus Torvalds <torvalds@linux-foundation.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
 Masami Hiramatsu <mhiramat@kernel.org>,
 Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
 Andrew Morton <akpm@linux-foundation.org>, Arnd Bergmann <arnd@arndb.de>,
 Prasad Pandit <pjp@fedoraproject.org>, Yang Li <yang.lee@linux.alibaba.com>
References: <20240412103204.453d912c@gandalf.local.home>
 <CAHk-=wgw2NW5tar-Xew614JZPKfyTdet5fC0mgwK+2sUsZ0Ekw@mail.gmail.com>
 <20240412121531.24669544@gandalf.local.home>
Content-Language: en-US
From: Randy Dunlap <rdunlap@infradead.org>
In-Reply-To: <20240412121531.24669544@gandalf.local.home>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit


On 4/12/24 9:15 AM, Steven Rostedt wrote:
> On Fri, 12 Apr 2024 09:07:18 -0700
> Linus Torvalds <torvalds@linux-foundation.org> wrote:
> 
>> On Fri, 12 Apr 2024 at 07:29, Steven Rostedt <rostedt@goodmis.org> wrote:
>>>
>>> - Replace bad tab with space in Kconfig for FTRACE_RECORD_RECURSION_SIZE  
>>
>> Argh. What parser is this? We need to fix this craziness.

something that fedora cares about.
out-of-tree I expect.

>> Yes, yes, we have "tabs and spaces" issues due to the fundamental
>> brokenness of make, and we can't get rid of *that* bogosity.
>>
>> But for our own Kconfig files? Whitespace is whitespace (ignoring
>> crazy unicode extensions), we need to get away from "tabs and spaces
>> act differently".
> 
> Note, the tab is here:
> 
> -	default	128
> +	default 128
>                ^
> 
> That is, the tab was between "default" and "128".
> 
> I'm really agnostic to if we care about it, and was questioning about
> taking it or not. But, it looks to be a hidden tab in a weird location,
> so I took it.

Yes, I'm about the same. My comments were:

"""
> Fix FTRACE_RECORD_RECURSION_SIZE entry, replace tab with

replace the tab between "default" and "128" with a space

> a space character. It helps Kconfig parsers to read file
> without error.

Parsers should accept either tab or space but this is a
reasonable change.
"""

Guess I wasn't forceful enough.